From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: julia@diku.dk
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap
Date: Sun, 13 Sep 2009 23:25:48 +0900 (JST) [thread overview]
Message-ID: <20090913.232548.253168283.anemo@mba.ocn.ne.jp> (raw)
In-Reply-To: <Pine.LNX.4.64.0909111820370.10552@pc-004.diku.dk>
On Fri, 11 Sep 2009 18:21:00 +0200 (CEST), Julia Lawall <julia@diku.dk> wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Error handling code following a kzalloc should free the allocated data.
> Error handling code following an ioremap should iounmap the allocated data.
>
> The semantic match that finds the first problem is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
Thank you for finding this out.
This patch add some correctness, but obviously incomplete: there are
more error pathes without iounmap/kfree/etc. in this function.
And I like goto-style cleanup, as Mark Brown said in reply for your
sound/soc patch.
Could you make a new patch?
---
Atsushi Nemoto
next prev parent reply other threads:[~2009-09-13 14:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-11 16:21 [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap Julia Lawall
2009-09-13 14:25 ` Atsushi Nemoto [this message]
2009-09-13 15:14 ` Julia Lawall
2009-09-13 15:33 ` Atsushi Nemoto
2009-09-13 15:49 ` Julia Lawall
2009-09-13 19:15 ` Julia Lawall
2009-09-14 14:56 ` Ralf Baechle
2009-09-15 5:03 ` Julia Lawall
2009-09-15 15:45 ` Atsushi Nemoto
2009-09-15 15:47 ` Julia Lawall
2009-09-15 15:56 ` Julia Lawall
2009-09-15 14:02 ` Ralf Rösch
2009-09-15 14:35 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090913.232548.253168283.anemo@mba.ocn.ne.jp \
--to=anemo@mba.ocn.ne.jp \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox