Re: [PATCH -next] drivers/staging/sm7xx: add a new framebuffer driver

Re: [PATCH -next] drivers/staging/sm7xx: add a new framebuffer driver

[Greg KH]

On Sun, Nov 08, 2009 at 05:39:01PM +0800, Wu wrote:
> From: Wu Zhangjin <wuzhangjin@gmail.com>
> 
> Yeeloong(2f) netbook has a sm712 video card, need this driver, but it is
> not ready to upstream yet, so, go to drivers/staing at first.
> 
> This source code is originally from Silicon Motion Technology Corp, and
> maintained in http://dev.lemote.com/code/linux_loongson
> 
> Thanks Simon for testing it on a little-endian x86 platform.
> 
> Thanks Olivier Croset <olivier.croset@actis-computer.com> for reporting
> the problem about __BIG_ENDIAN compiling problem and send a relative
> patch.
> 
> The suspend/resume and blank support are contributed by Jason from
> Silicon Motion Technology.
> 
> (Hi, Ralf, Could you please merge it into your linux-mips? So, we can
>  get a complete lemote-2f support with the last patchset.)

Ralf, want to take this through your tree or mine?

I don't care either way.

thanks,

greg k-h

Re: [PATCH -next] drivers/staging/sm7xx: add a new framebuffer driver

[Wu Zhangjin]

On Sun, 2009-11-08 at 17:39 +0800, Wu wrote:
[...]
> +/* Jason (08/14/2009)
> + * suspend function, called when the suspend event is triggered
> + */
> +static int smtcfb_suspend(struct pci_dev *pdev, pm_message_t msg)
> +{

__maybe_unused is needed before smtcfb_suspend() to let gcc not complain
about "function defined but not used" when CONFIG_PM is disabled.

[...]
> +static int smtcfb_resume(struct pci_dev *pdev)
> +{

Here too.

> +static struct pci_driver smtcfb_driver = {
> +	.name = "smtcfb",
> +	.id_table = smtcfb_pci_table,
> +	.probe = smtcfb_pci_probe,
> +	.remove = __devexit_p(smtcfb_pci_remove),
> +#ifdef CONFIG_PM
> +	.suspend = smtcfb_suspend,
> +	.resume = smtcfb_resume,
> +#endif
> +};
> +

Best Regards,
	Wu Zhangjin