Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: linux-mips@linux-mips.org, Yoichi Yuasa <yuasa@linux-mips.org>,
	Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Reverting old hack
Date: Sat, 20 Feb 2010 12:31:34 +0100	[thread overview]
Message-ID: <20100220113134.GA27194@linux-mips.org> (raw)

Below 9f7670e4ddd940d95e48997c2da51614e5fde2cf, an old hack which I
committed in December '07 I think mostly for Cobalt machines.  This is
now getting in the way - in fact the whole loop in
pcibios_fixup_device_resources() may have to go.  So I wonder if this
old hack is still necessary.  Only testing can answer so I'm going to
put a patch to revert this into the -queue tree for 2.6.34.

  Ralf

[MIPS] PCI: Make pcibios_fixup_device_resources ignore legacy resources.

There might be other reasons why a resource might be marked as fixed
such as a PCI UART holding the system console but until we use
IORESOURCE_PCI_FIXED that way also this will work.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

diff --git a/arch/mips/pci/pci.c b/arch/mips/pci/pci.c
index 589b745..6e6981f 100644
--- a/arch/mips/pci/pci.c
+++ b/arch/mips/pci/pci.c
@@ -242,6 +242,8 @@ static void pcibios_fixup_device_resources(struct pci_dev *dev,
 	for (i = 0; i < PCI_NUM_RESOURCES; i++) {
 		if (!dev->resource[i].start)
 			continue;
+		if (dev->resource[i].flags & IORESOURCE_PCI_FIXED)
+			continue;
 		if (dev->resource[i].flags & IORESOURCE_IO)
 			offset = hose->io_offset;
 		else if (dev->resource[i].flags & IORESOURCE_MEM)

             reply	other threads:[~2010-02-20 11:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-20 11:31 Ralf Baechle [this message]
2010-02-20 12:18 ` Reverting old hack Yoichi Yuasa
2010-02-20 14:57   ` Bjorn Helgaas
2010-02-21  7:45     ` Yoichi Yuasa
2010-02-22 20:55       ` Bjorn Helgaas
2010-02-22 23:51         ` Yoichi Yuasa
2010-02-23  0:15           ` Bjorn Helgaas
2010-02-23  0:50             ` Yoichi Yuasa
2010-02-21  2:57   ` Bjorn Helgaas
2010-02-22  0:09     ` Bjorn Helgaas
2010-02-22  5:07   ` Bjorn Helgaas
2010-02-22  6:39     ` Yoichi Yuasa
2010-02-22 13:28     ` Ralf Baechle
2010-02-23 23:01       ` Bjorn Helgaas
2010-02-24  0:03         ` Yoichi Yuasa
2010-02-24 16:41           ` Ralf Baechle
2010-02-24 16:59             ` Bjorn Helgaas
2010-02-24 17:41               ` Ralf Baechle
2010-02-24 20:53             ` Benjamin Herrenschmidt
2010-02-25  8:39             ` Yoichi Yuasa
2010-02-25 14:29               ` Ralf Baechle
2010-02-24 16:13         ` Ralf Baechle
2010-02-24 16:23           ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100220113134.GA27194@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=linux-mips@linux-mips.org \
    --cc=yuasa@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox