From: Yoichi Yuasa <yuasa@linux-mips.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: yuasa@linux-mips.org, Bjorn Helgaas <bjorn.helgaas@hp.com>,
linux-mips@linux-mips.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: Reverting old hack
Date: Thu, 25 Feb 2010 17:39:56 +0900 [thread overview]
Message-ID: <20100225173956.65cf8fa3.yuasa@linux-mips.org> (raw)
In-Reply-To: <20100224164100.GD5130@linux-mips.org>
On Wed, 24 Feb 2010 17:41:00 +0100
Ralf Baechle <ralf@linux-mips.org> wrote:
> On Wed, Feb 24, 2010 at 09:03:33AM +0900, Yoichi Yuasa wrote:
>
> > > approach Ben suggested long ago:
> > > http://marc.info/?l=linux-kernel&m=119733290624544&w=2
> >
> > It works fine with 2.6.34 queue tree.
> > pci.c change is already committed by Ralf.
>
> Which I just dropped from queue. To keep the tree bisectable removal of
> the old hack and adding the fixup should be done in the same patch so I'd
> go for Bjorn's patch.
>
> There is another somewhat theoretical correctness issue. Because the
> VIA SuperIO chip only decodes 24 bits of address space but port address
> space currently being configured as 32MB there is the theoretical
> possibility of I/O port addresses that alias with legacy addresses getting
> allocated.
>
> The complicated solution is to reserve all address range that potencially
> could cause such aliases. But with the PCI spec limiting port allocations
> for devices to a maximum of 256 bytes 16MB of port address space already is
> way more than one would ever expect to be used so I suggest to just limit
> the port address space to 16MB.
>
> Could you test the patch below?
It has no problem.
$ cat /proc/ioports
00000000-0000001f : reserved
00000020-00000021 : pic1
00000060-0000006f : reserved
00000070-00000077 : rtc_cmos
00000070-00000077 : rtc0
00000080-0000008f : reserved
000000a0-000000a1 : pic2
000000c0-000000df : reserved
00000170-00000177 : pata_via
000001f0-000001f7 : pata_via
00000376-00000376 : pata_via
000003f6-000003f6 : pata_via
00001000-00ffffff : PCI I/O
00001000-0000107f : 0000:00:07.0
00001000-0000107f : tulip
00001080-000010ff : 0000:00:0c.0
00001080-000010ff : tulip
00001400-0000141f : 0000:00:09.2
00001420-0000142f : 0000:00:09.1
00001420-0000142f : pata_via
Yoichi
next prev parent reply other threads:[~2010-02-25 8:40 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-20 11:31 Reverting old hack Ralf Baechle
2010-02-20 12:18 ` Yoichi Yuasa
2010-02-20 14:57 ` Bjorn Helgaas
2010-02-21 7:45 ` Yoichi Yuasa
2010-02-22 20:55 ` Bjorn Helgaas
2010-02-22 23:51 ` Yoichi Yuasa
2010-02-23 0:15 ` Bjorn Helgaas
2010-02-23 0:50 ` Yoichi Yuasa
2010-02-21 2:57 ` Bjorn Helgaas
2010-02-22 0:09 ` Bjorn Helgaas
2010-02-22 5:07 ` Bjorn Helgaas
2010-02-22 6:39 ` Yoichi Yuasa
2010-02-22 13:28 ` Ralf Baechle
2010-02-23 23:01 ` Bjorn Helgaas
2010-02-24 0:03 ` Yoichi Yuasa
2010-02-24 16:41 ` Ralf Baechle
2010-02-24 16:59 ` Bjorn Helgaas
2010-02-24 17:41 ` Ralf Baechle
2010-02-24 20:53 ` Benjamin Herrenschmidt
2010-02-25 8:39 ` Yoichi Yuasa [this message]
2010-02-25 14:29 ` Ralf Baechle
2010-02-24 16:13 ` Ralf Baechle
2010-02-24 16:23 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100225173956.65cf8fa3.yuasa@linux-mips.org \
--to=yuasa@linux-mips.org \
--cc=benh@kernel.crashing.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox