[PATCH -queue] MIPS: Move Loongson Makefile parts to their own Platform file (cont.)

[PATCH -queue] MIPS: Move Loongson Makefile parts to their own Platform file (cont.)

[Wu Zhangjin]

Hi, Ralf

I have fogotten to remove the -Werror in the Makefiles under loongson/
directory, this patch does it. could you please merge it into the commit "MIPS:
Move Loongson Makefile parts to their own Platform file".

Thanks & Regards,

Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
---
 arch/mips/loongson/common/cs5536/Makefile |    2 --
 arch/mips/loongson/fuloong-2e/Makefile    |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/mips/loongson/common/cs5536/Makefile b/arch/mips/loongson/common/cs5536/Makefile
index 510d4cd..f12e640 100644
--- a/arch/mips/loongson/common/cs5536/Makefile
+++ b/arch/mips/loongson/common/cs5536/Makefile
@@ -9,5 +9,3 @@ obj-$(CONFIG_CS5536) += cs5536_pci.o cs5536_ide.o cs5536_acc.o cs5536_ohci.o \
 # Enable cs5536 mfgpt Timer
 #
 obj-$(CONFIG_CS5536_MFGPT) += cs5536_mfgpt.o
-
-EXTRA_CFLAGS += -Werror
diff --git a/arch/mips/loongson/fuloong-2e/Makefile b/arch/mips/loongson/fuloong-2e/Makefile
index 3aba5fc..b762272 100644
--- a/arch/mips/loongson/fuloong-2e/Makefile
+++ b/arch/mips/loongson/fuloong-2e/Makefile
@@ -3,5 +3,3 @@
 #
 
 obj-y += irq.o reset.o
-
-EXTRA_CFLAGS += -Werror
-- 
1.6.5

Re: [PATCH -queue] MIPS: Move Loongson Makefile parts to their own Platform file (cont.)

[Ralf Baechle]

On Wed, Jun 02, 2010 at 04:53:00PM +0800, Wu Zhangjin wrote:

Thanks, folded into the existing patch.

 Ralf

Re: [PATCH -queue] MIPS: Move Loongson Makefile parts to their own Platform file (cont.)

[Dmitri Vorobiev]

On Wed, Jun 2, 2010 at 11:53 AM, Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> Hi, Ralf
>
> I have fogotten to remove the -Werror in the Makefiles under loongson/

I'm just curious: why would anyone want to remove -Werror? It's very
useful in most cases, IMO.

Dmitri

Re: [PATCH -queue] MIPS: Move Loongson Makefile parts to their own Platform file (cont.)

[Dmitri Vorobiev]

On Wed, Jun 2, 2010 at 11:53 AM, Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> Hi, Ralf
>
> I have fogotten to remove the -Werror in the Makefiles under loongson/

I'm just curious: why would anyone want to remove -Werror? It's very
useful in most cases, IMO.

Dmitri

Re: [PATCH -queue] MIPS: Move Loongson Makefile parts to their own Platform file (cont.)

[Ralf Baechle]

On Thu, Jun 03, 2010 at 02:10:26PM +0300, Dmitri Vorobiev wrote:

> > Hi, Ralf
> >
> > I have fogotten to remove the -Werror in the Makefiles under loongson/
> 
> I'm just curious: why would anyone want to remove -Werror? It's very
> useful in most cases, IMO.

arch/mips/Kbuild enables -Werror for all platforms.

  Ralf

Re: [PATCH -queue] MIPS: Move Loongson Makefile parts to their own Platform file (cont.)

[Dmitri Vorobiev]

On Thu, Jun 3, 2010 at 2:39 PM, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Thu, Jun 03, 2010 at 02:10:26PM +0300, Dmitri Vorobiev wrote:
>
>> > Hi, Ralf
>> >
>> > I have fogotten to remove the -Werror in the Makefiles under loongson/
>>
>> I'm just curious: why would anyone want to remove -Werror? It's very
>> useful in most cases, IMO.
>
> arch/mips/Kbuild enables -Werror for all platforms.

Looks like I'm failing to keep pace with life :)

Dmitri

Re: [PATCH -queue] MIPS: Move Loongson Makefile parts to their own Platform file (cont.)

[Dmitri Vorobiev]

On Thu, Jun 3, 2010 at 2:39 PM, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Thu, Jun 03, 2010 at 02:10:26PM +0300, Dmitri Vorobiev wrote:
>
>> > Hi, Ralf
>> >
>> > I have fogotten to remove the -Werror in the Makefiles under loongson/
>>
>> I'm just curious: why would anyone want to remove -Werror? It's very
>> useful in most cases, IMO.
>
> arch/mips/Kbuild enables -Werror for all platforms.

Looks like I'm failing to keep pace with life :)

Dmitri

Re: [PATCH -queue] MIPS: Move Loongson Makefile parts to their own Platform file (cont.)

[Ralf Baechle]

On Thu, Jun 03, 2010 at 03:04:13PM +0300, Dmitri Vorobiev wrote:

> >> > I have fogotten to remove the -Werror in the Makefiles under loongson/
> >>
> >> I'm just curious: why would anyone want to remove -Werror? It's very
> >> useful in most cases, IMO.
> >
> > arch/mips/Kbuild enables -Werror for all platforms.
> 
> Looks like I'm failing to keep pace with life :)

Soon you'll need a fiber from vger to your brain just to keep up with lkml ;-)

  Ralf