* [PATCH] MIPS: Separate two consecutive loads in memset.S
@ 2010-11-09 7:48 Tony Wu
2010-11-09 13:26 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Tony Wu @ 2010-11-09 7:48 UTC (permalink / raw)
To: linux-mips, ralf
partial_fixup is used in noreorder block.
Separating two consecutive loads can save one cycle on processors with
GPR intrelock and can fix load-use on processors that need a load delay slot.
Also do so for fwd_fixup.
Signed-off-by: Tony Wu <tung7970@gmail.com>
---
arch/mips/lib/memset.S | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/mips/lib/memset.S b/arch/mips/lib/memset.S
index 77dc3b2..606c8a9 100644
--- a/arch/mips/lib/memset.S
+++ b/arch/mips/lib/memset.S
@@ -161,16 +161,16 @@ FEXPORT(__bzero)
.Lfwd_fixup:
PTR_L t0, TI_TASK($28)
- LONG_L t0, THREAD_BUADDR(t0)
andi a2, 0x3f
+ LONG_L t0, THREAD_BUADDR(t0)
LONG_ADDU a2, t1
jr ra
LONG_SUBU a2, t0
.Lpartial_fixup:
PTR_L t0, TI_TASK($28)
- LONG_L t0, THREAD_BUADDR(t0)
andi a2, LONGMASK
+ LONG_L t0, THREAD_BUADDR(t0)
LONG_ADDU a2, t1
jr ra
LONG_SUBU a2, t0
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: Separate two consecutive loads in memset.S
2010-11-09 7:48 [PATCH] MIPS: Separate two consecutive loads in memset.S Tony Wu
@ 2010-11-09 13:26 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2010-11-09 13:26 UTC (permalink / raw)
To: Tony Wu; +Cc: linux-mips
On Tue, Nov 09, 2010 at 03:48:03PM +0800, Tony Wu wrote:
> partial_fixup is used in noreorder block.
>
> Separating two consecutive loads can save one cycle on processors with
> GPR intrelock and can fix load-use on processors that need a load delay slot.
>
> Also do so for fwd_fixup.
Patch is whitespace mangled; please resend.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-09 13:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-09 7:48 [PATCH] MIPS: Separate two consecutive loads in memset.S Tony Wu
2010-11-09 13:26 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox