Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: Matt Turner <mattst88@gmail.com>
Cc: Jean Delvare <khali@linux-fr.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH] I2C: SiByte: Convert the driver to make use of interrupts
Date: Mon, 6 Dec 2010 10:02:03 -0800	[thread overview]
Message-ID: <20101206180203.GA18478@ericsson.com> (raw)
In-Reply-To: <AANLkTikGgfBuj086eRvy4VzzyE2suJCL9z=SfmOiFiPx@mail.gmail.com>

On Mon, Dec 06, 2010 at 12:40:15PM -0500, Matt Turner wrote:
> On Mon, Dec 6, 2010 at 5:30 PM, Guenter Roeck
> <guenter.roeck@ericsson.com> wrote:
> > On Mon, Dec 06, 2010 at 01:38:14AM -0500, Matt Turner wrote:
> >> From: Maciej W. Rozycki <macro@linux-mips.org>
> >>
> >> This is a rewrite of large parts of the driver mainly so that it uses
> >> SMBus interrupts to offload the CPU from busy-waiting on status inputs.
> >> As a part of the overhaul of the init and exit calls, all accesses to the
> >> hardware got converted to use accessory functions via an ioremap() cookie.
> >>
> >> Minimally rebased by Matt Turner.
> >>
> >> Tested-by: Matt Turner <mattst88@gmail.com>
> >> Signed-off-by: Matt Turner <mattst88@gmail.com>
> >
> >
> > I applied the patch to my 1480 tree. Unfortunately, it doesn't work with my system.
> > As far as I can see, the driver does not get any interrupts.
> >
> > My tree is 2.6.32, though. Do you know if I might be missing some other relevant patch ?
> >
> > Thanks,
> > Guenter
> 
> I think this patch depends on
> http://www.linux-mips.org/archives/linux-mips/2010-12/msg00030.html
> 
I did apply the second patch as well, since you had mentioned it in your patch.
That did not help, though. Frankly, I don't see the dependency in the first place - the other 
patch only affects drivers/rtc/rtc-m41t80.c, and I would hope that SMBus support does not depend
on an rtc driver. Am I missing something ?

Thanks,
Guenter

  reply	other threads:[~2010-12-06 18:02 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06  6:38 [PATCH] I2C: SiByte: Convert the driver to make use of interrupts Matt Turner
2010-12-06 14:59 ` Guenter Roeck
2010-12-06 17:30 ` Guenter Roeck
2010-12-06 17:40   ` Matt Turner
2010-12-06 18:02     ` Guenter Roeck [this message]
2010-12-06 18:04       ` Matt Turner
2010-12-06 17:56   ` Maciej W. Rozycki
2010-12-06 18:02     ` Matt Turner
2010-12-07  2:26       ` Maciej W. Rozycki
2010-12-07  5:14         ` Guenter Roeck
2010-12-07 14:30           ` Maciej W. Rozycki
2010-12-07 14:41             ` Guenter Roeck
2010-12-07  6:23 ` Guenter Roeck
  -- strict thread matches above, loose matches on Subject: below --
2011-08-18 23:43 Matt Turner
2011-08-22 20:02 ` Guenter Roeck
2011-08-24 15:36 ` Matt Turner
2011-09-02 13:21   ` Jean Delvare
2011-09-02 13:35     ` Maciej W. Rozycki
2011-09-03  8:30 ` Jean Delvare
2011-10-31  9:53   ` Jean Delvare
2011-10-31  9:53     ` Jean Delvare
2012-01-10 14:38     ` Jean Delvare
2012-01-10 15:31       ` Maciej W. Rozycki
2012-01-12 21:19       ` Matt Turner
2012-03-31  6:23         ` Jean Delvare
2012-03-31 12:11           ` Matt Turner
2012-04-03 12:26             ` Maciej W. Rozycki
2012-06-30 16:35             ` Matt Turner
2012-07-19 21:01               ` Maciej W. Rozycki
2012-12-18 12:08                 ` Jean Delvare
2012-12-18 12:08                   ` Jean Delvare
2008-05-13  3:28 Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101206180203.GA18478@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=khali@linux-fr.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=macro@linux-mips.org \
    --cc=mattst88@gmail.com \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox