From: Guenter Roeck <guenter.roeck@ericsson.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Matt Turner <mattst88@gmail.com>,
Jean Delvare <khali@linux-fr.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>,
Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] I2C: SiByte: Convert the driver to make use of interrupts
Date: Tue, 7 Dec 2010 06:41:50 -0800 [thread overview]
Message-ID: <20101207144150.GA21872@ericsson.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1012070740130.17185@eddie.linux-mips.org>
On Tue, Dec 07, 2010 at 09:30:27AM -0500, Maciej W. Rozycki wrote:
> On Mon, 6 Dec 2010, Guenter Roeck wrote:
>
> > A quick look through sb1250 vs. sb1480 code shows that the 1480 uses different
> > interrupt numbers. The patch assigns the sb1250 interrupt numbers, so unless
> > I am missing something the code as written can not work for sb1480.
>
> That well could be -- I never had access to a BigSur board. The
> board-specific interrupt numbers should either be available from the board
> manual (I haven't checked if one has been released; I certainly have one
> for my SWARM) or quoted somewhere in our tree. Otherwise figuring them
> out by trial and error should be a trivial exercise for someone with
> actual hardware at hand.
>
I already sent a reply to the original patch - I confirmed that the interrupts are different.
Those are SOC interrupts, so they are CPU specific, not board specific. Code started working
after I replaced the sb1250 interrupts with bcm1480 interrupts.
Guenter
next prev parent reply other threads:[~2010-12-07 14:42 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-06 6:38 [PATCH] I2C: SiByte: Convert the driver to make use of interrupts Matt Turner
2010-12-06 14:59 ` Guenter Roeck
2010-12-06 17:30 ` Guenter Roeck
2010-12-06 17:40 ` Matt Turner
2010-12-06 18:02 ` Guenter Roeck
2010-12-06 18:04 ` Matt Turner
2010-12-06 17:56 ` Maciej W. Rozycki
2010-12-06 18:02 ` Matt Turner
2010-12-07 2:26 ` Maciej W. Rozycki
2010-12-07 5:14 ` Guenter Roeck
2010-12-07 14:30 ` Maciej W. Rozycki
2010-12-07 14:41 ` Guenter Roeck [this message]
2010-12-07 6:23 ` Guenter Roeck
-- strict thread matches above, loose matches on Subject: below --
2011-08-18 23:43 Matt Turner
2011-08-22 20:02 ` Guenter Roeck
2011-08-24 15:36 ` Matt Turner
2011-09-02 13:21 ` Jean Delvare
2011-09-02 13:35 ` Maciej W. Rozycki
2011-09-03 8:30 ` Jean Delvare
2011-10-31 9:53 ` Jean Delvare
2011-10-31 9:53 ` Jean Delvare
2012-01-10 14:38 ` Jean Delvare
2012-01-10 15:31 ` Maciej W. Rozycki
2012-01-12 21:19 ` Matt Turner
2012-03-31 6:23 ` Jean Delvare
2012-03-31 12:11 ` Matt Turner
2012-04-03 12:26 ` Maciej W. Rozycki
2012-06-30 16:35 ` Matt Turner
2012-07-19 21:01 ` Maciej W. Rozycki
2012-12-18 12:08 ` Jean Delvare
2012-12-18 12:08 ` Jean Delvare
2008-05-13 3:28 Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101207144150.GA21872@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=khali@linux-fr.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=mattst88@gmail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox