From: Ralf Baechle <ralf@linux-mips.org>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: trivial@kernel.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [RFC 3/5]arch:mips:pmc-sierra:msp71xx:Makefile Remove unused config in the Makefile.
Date: Fri, 8 Apr 2011 15:08:11 +0200 [thread overview]
Message-ID: <20110408130811.GA17431@linux-mips.org> (raw)
In-Reply-To: <1302022702-24541-3-git-send-email-justinmattock@gmail.com>
On Tue, Apr 05, 2011 at 09:58:20AM -0700, Justin P. Mattock wrote:
> The patch below removes an unused config variable found by using a kernel
> cleanup script.
> Note: I did try to cross compile these but hit erros while doing so..
> (gcc is not setup to cross compile) and am unsure if anymore needs to be done.
> Please have a look if/when anybody has free time.
NACK.
This need a rewrite, not just chainsawing. Your code was only touching
the makefile anyway, not the two referenced C files.
Ralf
Ralf
next prev parent reply other threads:[~2011-04-08 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1302022702-24541-1-git-send-email-justinmattock@gmail.com>
2011-04-05 16:58 ` [RFC 3/5]arch:mips:pmc-sierra:msp71xx:Makefile Remove unused config in the Makefile Justin P. Mattock
2011-04-08 13:08 ` Ralf Baechle [this message]
2011-04-08 15:10 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110408130811.GA17431@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=justinmattock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox