* [RFC 3/5]arch:mips:pmc-sierra:msp71xx:Makefile Remove unused config in the Makefile. [not found] <1302022702-24541-1-git-send-email-justinmattock@gmail.com> @ 2011-04-05 16:58 ` Justin P. Mattock 2011-04-08 13:08 ` Ralf Baechle 0 siblings, 1 reply; 3+ messages in thread From: Justin P. Mattock @ 2011-04-05 16:58 UTC (permalink / raw) To: trivial; +Cc: linux-kernel, Justin P. Mattock, Ralf Baechle, linux-mips The patch below removes an unused config variable found by using a kernel cleanup script. Note: I did try to cross compile these but hit erros while doing so.. (gcc is not setup to cross compile) and am unsure if anymore needs to be done. Please have a look if/when anybody has free time. Signed-off-by: Justin P. Mattock <justinmattock@gmail.com> CC: Ralf Baechle <ralf@linux-mips.org> CC: linux-mips@linux-mips.org --- arch/mips/pmc-sierra/msp71xx/Makefile | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/mips/pmc-sierra/msp71xx/Makefile b/arch/mips/pmc-sierra/msp71xx/Makefile index cefba77..9201c8b 100644 --- a/arch/mips/pmc-sierra/msp71xx/Makefile +++ b/arch/mips/pmc-sierra/msp71xx/Makefile @@ -3,7 +3,6 @@ # obj-y += msp_prom.o msp_setup.o msp_irq.o \ msp_time.o msp_serial.o msp_elb.o -obj-$(CONFIG_HAVE_GPIO_LIB) += gpio.o gpio_extended.o obj-$(CONFIG_PMC_MSP7120_GW) += msp_hwbutton.o obj-$(CONFIG_IRQ_MSP_SLP) += msp_irq_slp.o obj-$(CONFIG_IRQ_MSP_CIC) += msp_irq_cic.o msp_irq_per.o -- 1.7.4.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC 3/5]arch:mips:pmc-sierra:msp71xx:Makefile Remove unused config in the Makefile. 2011-04-05 16:58 ` [RFC 3/5]arch:mips:pmc-sierra:msp71xx:Makefile Remove unused config in the Makefile Justin P. Mattock @ 2011-04-08 13:08 ` Ralf Baechle 2011-04-08 15:10 ` Justin P. Mattock 0 siblings, 1 reply; 3+ messages in thread From: Ralf Baechle @ 2011-04-08 13:08 UTC (permalink / raw) To: Justin P. Mattock; +Cc: trivial, linux-kernel, linux-mips On Tue, Apr 05, 2011 at 09:58:20AM -0700, Justin P. Mattock wrote: > The patch below removes an unused config variable found by using a kernel > cleanup script. > Note: I did try to cross compile these but hit erros while doing so.. > (gcc is not setup to cross compile) and am unsure if anymore needs to be done. > Please have a look if/when anybody has free time. NACK. This need a rewrite, not just chainsawing. Your code was only touching the makefile anyway, not the two referenced C files. Ralf Ralf ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC 3/5]arch:mips:pmc-sierra:msp71xx:Makefile Remove unused config in the Makefile. 2011-04-08 13:08 ` Ralf Baechle @ 2011-04-08 15:10 ` Justin P. Mattock 0 siblings, 0 replies; 3+ messages in thread From: Justin P. Mattock @ 2011-04-08 15:10 UTC (permalink / raw) To: Ralf Baechle; +Cc: trivial, linux-kernel, linux-mips On 04/08/2011 06:08 AM, Ralf Baechle wrote: > On Tue, Apr 05, 2011 at 09:58:20AM -0700, Justin P. Mattock wrote: > >> The patch below removes an unused config variable found by using a kernel >> cleanup script. >> Note: I did try to cross compile these but hit erros while doing so.. >> (gcc is not setup to cross compile) and am unsure if anymore needs to be done. >> Please have a look if/when anybody has free time. > > NACK. > > This need a rewrite, not just chainsawing. Your code was only touching > the makefile anyway, not the two referenced C files. > > Ralf > > Ralf > alright!! Justin P. Mattock ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-08 15:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1302022702-24541-1-git-send-email-justinmattock@gmail.com>
2011-04-05 16:58 ` [RFC 3/5]arch:mips:pmc-sierra:msp71xx:Makefile Remove unused config in the Makefile Justin P. Mattock
2011-04-08 13:08 ` Ralf Baechle
2011-04-08 15:10 ` Justin P. Mattock
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox