From: Florian Fainelli <florian@openwrt.org>
To: Jonas Gorski <jonas.gorski@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: bcm63xx: Fix header_crc comment in bcm963xx_tag.h
Date: Fri, 8 Apr 2011 14:41:30 +0200 [thread overview]
Message-ID: <201104081441.30827.florian@openwrt.org> (raw)
In-Reply-To: <1302265935-23802-1-git-send-email-jonas.gorski@gmail.com>
On Friday 08 April 2011 14:32:15 Jonas Gorski wrote:
> The CRC32 actually includes the tag_version.
>
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Acked-by: Florian Fainelli <florian@openwrt.org>
> ---
>
> This was already wrong in the original Broadcom sources (and it still
> seems to be).
>
> arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h
> b/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h index 5325084..73c499f
> 100644
> --- a/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h
> +++ b/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h
> @@ -88,7 +88,7 @@ struct bcm_tag {
> char kernel_crc[CRC_LEN];
> /* 228-235: Unused at present */
> char reserved1[8];
> - /* 236-239: CRC32 of header excluding tagVersion */
> + /* 236-239: CRC32 of header excluding last 20 bytes */
> char header_crc[CRC_LEN];
> /* 240-255: Unused at present */
> char reserved2[16];
next prev parent reply other threads:[~2011-04-08 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 12:32 [PATCH] MIPS: bcm63xx: Fix header_crc comment in bcm963xx_tag.h Jonas Gorski
2011-04-08 12:41 ` Florian Fainelli [this message]
2011-04-08 12:45 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104081441.30827.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=jonas.gorski@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox