* [PATCH] MIPS: bcm63xx: Fix header_crc comment in bcm963xx_tag.h
@ 2011-04-08 12:32 Jonas Gorski
2011-04-08 12:41 ` Florian Fainelli
2011-04-08 12:45 ` Ralf Baechle
0 siblings, 2 replies; 3+ messages in thread
From: Jonas Gorski @ 2011-04-08 12:32 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, Florian Fainelli
The CRC32 actually includes the tag_version.
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
---
This was already wrong in the original Broadcom sources (and it still
seems to be).
arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h b/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h
index 5325084..73c499f 100644
--- a/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h
+++ b/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h
@@ -88,7 +88,7 @@ struct bcm_tag {
char kernel_crc[CRC_LEN];
/* 228-235: Unused at present */
char reserved1[8];
- /* 236-239: CRC32 of header excluding tagVersion */
+ /* 236-239: CRC32 of header excluding last 20 bytes */
char header_crc[CRC_LEN];
/* 240-255: Unused at present */
char reserved2[16];
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: bcm63xx: Fix header_crc comment in bcm963xx_tag.h
2011-04-08 12:32 [PATCH] MIPS: bcm63xx: Fix header_crc comment in bcm963xx_tag.h Jonas Gorski
@ 2011-04-08 12:41 ` Florian Fainelli
2011-04-08 12:45 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2011-04-08 12:41 UTC (permalink / raw)
To: Jonas Gorski; +Cc: Ralf Baechle, linux-mips
On Friday 08 April 2011 14:32:15 Jonas Gorski wrote:
> The CRC32 actually includes the tag_version.
>
> Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Acked-by: Florian Fainelli <florian@openwrt.org>
> ---
>
> This was already wrong in the original Broadcom sources (and it still
> seems to be).
>
> arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h
> b/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h index 5325084..73c499f
> 100644
> --- a/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h
> +++ b/arch/mips/include/asm/mach-bcm63xx/bcm963xx_tag.h
> @@ -88,7 +88,7 @@ struct bcm_tag {
> char kernel_crc[CRC_LEN];
> /* 228-235: Unused at present */
> char reserved1[8];
> - /* 236-239: CRC32 of header excluding tagVersion */
> + /* 236-239: CRC32 of header excluding last 20 bytes */
> char header_crc[CRC_LEN];
> /* 240-255: Unused at present */
> char reserved2[16];
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: bcm63xx: Fix header_crc comment in bcm963xx_tag.h
2011-04-08 12:32 [PATCH] MIPS: bcm63xx: Fix header_crc comment in bcm963xx_tag.h Jonas Gorski
2011-04-08 12:41 ` Florian Fainelli
@ 2011-04-08 12:45 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2011-04-08 12:45 UTC (permalink / raw)
To: Jonas Gorski; +Cc: linux-mips, Florian Fainelli
Thanks, applied.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-04-08 12:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-08 12:32 [PATCH] MIPS: bcm63xx: Fix header_crc comment in bcm963xx_tag.h Jonas Gorski
2011-04-08 12:41 ` Florian Fainelli
2011-04-08 12:45 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox