Linux MIPS Architecture development
 help / color / mirror / Atom feed
* [PATCH] MIPS: Fix build breakage in cpu-probe.c
@ 2011-05-13  0:24 David Daney
  2011-05-13  1:26 ` Kevin Cernekee
  2011-05-13  9:12 ` Ralf Baechle
  0 siblings, 2 replies; 4+ messages in thread
From: David Daney @ 2011-05-13  0:24 UTC (permalink / raw)
  To: linux-mips, ralf; +Cc: David Daney

Move set_elf_platform() above all its uses.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
---

linux-queue is currently broken, this fixes it.

 arch/mips/kernel/cpu-probe.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/mips/kernel/cpu-probe.c b/arch/mips/kernel/cpu-probe.c
index 054a640..bb133d1 100644
--- a/arch/mips/kernel/cpu-probe.c
+++ b/arch/mips/kernel/cpu-probe.c
@@ -291,6 +291,12 @@ static inline int cpu_has_confreg(void)
 #endif
 }
 
+static inline void set_elf_platform(int cpu, const char *plat)
+{
+	if (cpu == 0)
+		__elf_platform = plat;
+}
+
 /*
  * Get the FPU Implementation/Revision.
  */
@@ -781,12 +787,6 @@ static void __cpuinit decode_configs(struct cpuinfo_mips *c)
 		c->core = read_c0_ebase() & 0x3ff;
 }
 
-static inline void set_elf_platform(int cpu, const char *plat)
-{
-	if (cpu == 0)
-		__elf_platform = plat;
-}
-
 static inline void cpu_probe_mips(struct cpuinfo_mips *c, unsigned int cpu)
 {
 	decode_configs(c);
-- 
1.7.2.3

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] MIPS: Fix build breakage in cpu-probe.c
  2011-05-13  0:24 [PATCH] MIPS: Fix build breakage in cpu-probe.c David Daney
@ 2011-05-13  1:26 ` Kevin Cernekee
  2011-05-13  9:11   ` Ralf Baechle
  2011-05-13  9:12 ` Ralf Baechle
  1 sibling, 1 reply; 4+ messages in thread
From: Kevin Cernekee @ 2011-05-13  1:26 UTC (permalink / raw)
  To: David Daney; +Cc: linux-mips, ralf

On Thu, May 12, 2011 at 5:24 PM, David Daney <ddaney@caviumnetworks.com> wrote:
> Move set_elf_platform() above all its uses.

Whoops, should have retested the Loongson patch v1 with the
set_elf_platform patch v2.  Thanks for fixing this.

Acked-by: Kevin Cernekee <cernekee@gmail.com>

BTW: the commit messages got a little messed up on the two patches
that had a secondary "From:" header to override the author field.  Is
there something I should be doing differently here?

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] MIPS: Fix build breakage in cpu-probe.c
  2011-05-13  1:26 ` Kevin Cernekee
@ 2011-05-13  9:11   ` Ralf Baechle
  0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2011-05-13  9:11 UTC (permalink / raw)
  To: Kevin Cernekee; +Cc: David Daney, linux-mips

On Thu, May 12, 2011 at 06:26:09PM -0700, Kevin Cernekee wrote:

> BTW: the commit messages got a little messed up on the two patches
> that had a secondary "From:" header to override the author field.  Is
> there something I should be doing differently here?

You did exactly the right thing.  I messed up when manually converting the
patch files into the pseudo quilt format I'm using for linux-queue.

  Ralf

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] MIPS: Fix build breakage in cpu-probe.c
  2011-05-13  0:24 [PATCH] MIPS: Fix build breakage in cpu-probe.c David Daney
  2011-05-13  1:26 ` Kevin Cernekee
@ 2011-05-13  9:12 ` Ralf Baechle
  1 sibling, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2011-05-13  9:12 UTC (permalink / raw)
  To: David Daney; +Cc: linux-mips

Folded into the original patch.  Thanks!

  Ralf

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-05-13  9:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-13  0:24 [PATCH] MIPS: Fix build breakage in cpu-probe.c David Daney
2011-05-13  1:26 ` Kevin Cernekee
2011-05-13  9:11   ` Ralf Baechle
2011-05-13  9:12 ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox