reference to non-existent CONFIG_HAVE_GPIO_LIB variable?

reference to non-existent CONFIG_HAVE_GPIO_LIB variable?

[Robert P. J. Day]

  the current kernel source contains a Makefile reference to the above
Kconfig variable that does not appear to be defined anywhere.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: reference to non-existent CONFIG_HAVE_GPIO_LIB variable?

[Florian Fainelli]

Hello,

On Sunday 15 May 2011 01:05:58 Robert P. J. Day wrote:
>   the current kernel source contains a Makefile reference to the above
> Kconfig variable that does not appear to be defined anywhere.

It would help if you mention which Makefile references this Kconfig variable 
along with the changeset which introduced it.
--
Florian

Re: reference to non-existent CONFIG_HAVE_GPIO_LIB variable?

[Robert P. J. Day]

On Mon, 16 May 2011, Florian Fainelli wrote:

> Hello,
>
> On Sunday 15 May 2011 01:05:58 Robert P. J. Day wrote:
> >   the current kernel source contains a Makefile reference to the above
> > Kconfig variable that does not appear to be defined anywhere.
>
> It would help if you mention which Makefile references this Kconfig
> variable along with the changeset which introduced it.

  quite so, my bad.  here's the changeset:

$ git show 9fa32c6b
commit 9fa32c6b0275ab1e8b19f74fbfa3ed8411345db6
Author: Patrick Glass <patrickglass@gmail.com>
Date:   Mon Aug 18 14:41:30 2008 -0700

    MIPS: PMC MSP71XX gpio drivers

    This new gpio driver for PMC-Sierra's MSP71xx SoC allows
    standard api calls for access to the general and extended
    gpio's.

    Signed-off-by: Patrick Glass <patrickglass@gmail.com>
    Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

     create mode 100755 arch/mips/pmc-sierra/msp71xx/gpio.c
     create mode 100755 arch/mips/pmc-sierra/msp71xx/gpio_extended.c
     create mode 100755 include/asm-mips/pmc-sierra/msp71xx/gpio.h

diff --git a/arch/mips/pmc-sierra/msp71xx/Makefile
b/arch/mips/pmc-sierra/msp71xx/Make
index 4bba79c..e107f79 100644
--- a/arch/mips/pmc-sierra/msp71xx/Makefile
+++ b/arch/mips/pmc-sierra/msp71xx/Makefile
@@ -3,6 +3,7 @@
 #
 obj-y += msp_prom.o msp_setup.o msp_irq.o \
         msp_time.o msp_serial.o msp_elb.o
+obj-$(CONFIG_HAVE_GPIO_LIB) += gpio.o gpio_extended.o
 obj-$(CONFIG_PMC_MSP7120_GW) += msp_hwbutton.o
 obj-$(CONFIG_IRQ_MSP_SLP) += msp_irq_slp.o
 obj-$(CONFIG_IRQ_MSP_CIC) += msp_irq_cic.o
... etc etc ...

  but there is no Kconfig file that defines the HAVE_GPIO_LIB variable
that i can see.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: reference to non-existent CONFIG_HAVE_GPIO_LIB variable?

[Florian Fainelli]

Hello,

On Monday 16 May 2011 11:36:46 Robert P. J. Day wrote:
> On Mon, 16 May 2011, Florian Fainelli wrote:
> > Hello,
> > 
> > On Sunday 15 May 2011 01:05:58 Robert P. J. Day wrote:
> > >   the current kernel source contains a Makefile reference to the above
> > > 
> > > Kconfig variable that does not appear to be defined anywhere.
> > 
> > It would help if you mention which Makefile references this Kconfig
> > variable along with the changeset which introduced it.
> 
>   quite so, my bad.  here's the changeset:

Thank you. I think the author rather meant ARCH_WANT_OPTIONAL_GPIOLIB instead, 
can you build test a patch with this and submit it if you are happy with it?

> 
> $ git show 9fa32c6b
> commit 9fa32c6b0275ab1e8b19f74fbfa3ed8411345db6
> Author: Patrick Glass <patrickglass@gmail.com>
> Date:   Mon Aug 18 14:41:30 2008 -0700
> 
>     MIPS: PMC MSP71XX gpio drivers
> 
>     This new gpio driver for PMC-Sierra's MSP71xx SoC allows
>     standard api calls for access to the general and extended
>     gpio's.
> 
>     Signed-off-by: Patrick Glass <patrickglass@gmail.com>
>     Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
> 
>      create mode 100755 arch/mips/pmc-sierra/msp71xx/gpio.c
>      create mode 100755 arch/mips/pmc-sierra/msp71xx/gpio_extended.c
>      create mode 100755 include/asm-mips/pmc-sierra/msp71xx/gpio.h
> 
> diff --git a/arch/mips/pmc-sierra/msp71xx/Makefile
> b/arch/mips/pmc-sierra/msp71xx/Make
> index 4bba79c..e107f79 100644
> --- a/arch/mips/pmc-sierra/msp71xx/Makefile
> +++ b/arch/mips/pmc-sierra/msp71xx/Makefile
> @@ -3,6 +3,7 @@
>  #
>  obj-y += msp_prom.o msp_setup.o msp_irq.o \
>          msp_time.o msp_serial.o msp_elb.o
> +obj-$(CONFIG_HAVE_GPIO_LIB) += gpio.o gpio_extended.o
>  obj-$(CONFIG_PMC_MSP7120_GW) += msp_hwbutton.o
>  obj-$(CONFIG_IRQ_MSP_SLP) += msp_irq_slp.o
>  obj-$(CONFIG_IRQ_MSP_CIC) += msp_irq_cic.o
> ... etc etc ...
> 
>   but there is no Kconfig file that defines the HAVE_GPIO_LIB variable
> that i can see.
> 
> rday

Re: reference to non-existent CONFIG_HAVE_GPIO_LIB variable?

[Manuel Lauss]

On Mon, May 16, 2011 at 1:33 PM, Florian Fainelli <florian@openwrt.org> wrote:
> Hello,
>
> On Monday 16 May 2011 11:36:46 Robert P. J. Day wrote:
>> On Mon, 16 May 2011, Florian Fainelli wrote:
>> > Hello,
>> >
>> > On Sunday 15 May 2011 01:05:58 Robert P. J. Day wrote:
>> > >   the current kernel source contains a Makefile reference to the above
>> > >
>> > > Kconfig variable that does not appear to be defined anywhere.
>> >
>> > It would help if you mention which Makefile references this Kconfig
>> > variable along with the changeset which introduced it.
>>
>>   quite so, my bad.  here's the changeset:
>
> Thank you. I think the author rather meant ARCH_WANT_OPTIONAL_GPIOLIB instead,
> can you build test a patch with this and submit it if you are happy with it?

Looking at the sources of the two files, I think they can only be
built when CONFIG_GPIOLIB=y, so the following plus a
"select ARCH_WANT_OPTIONAL_GPIOLIB" entry to
arch/mips/pmc-sierra/Kconfig  should do the right thing:

-obj-$(CONFIG_HAVE_GPIO_LIB) += gpio.o gpio_extended.o
+obj-$(CONFIG_GPIOLIB) += gpio.o gpio_extended.o

Manuel

Re: reference to non-existent CONFIG_HAVE_GPIO_LIB variable?

[Ralf Baechle]

On Sat, May 14, 2011 at 07:05:58PM -0400, Robert P. J. Day wrote:

>   the current kernel source contains a Makefile reference to the above
> Kconfig variable that does not appear to be defined anywhere.

Commit 7444a72effa632fcd8edc566f880d96fe213c73b ["gpiolib: allow user-
selection"] plus the fixups in commit
09cd9527d621640d4dd231dff77b681e711d8e4b ["gpiolib: fix HAVE_GPIO_LIB
leftovers in asm-generic/gpio.h"] and maybe others changed the symbol
name.  Somehow this instance was missed - maybe because the code was
merged around the same timeframe.

  Ralf

Re: reference to non-existent CONFIG_HAVE_GPIO_LIB variable?

[Robert P. J. Day]

On Mon, 16 May 2011, Ralf Baechle wrote:

> On Sat, May 14, 2011 at 07:05:58PM -0400, Robert P. J. Day wrote:
>
> >   the current kernel source contains a Makefile reference to the above
> > Kconfig variable that does not appear to be defined anywhere.
>
> Commit 7444a72effa632fcd8edc566f880d96fe213c73b ["gpiolib: allow
> user- selection"] plus the fixups in commit
> 09cd9527d621640d4dd231dff77b681e711d8e4b ["gpiolib: fix
> HAVE_GPIO_LIB leftovers in asm-generic/gpio.h"] and maybe others
> changed the symbol name.  Somehow this instance was missed - maybe
> because the code was merged around the same timeframe.

  well, i'll just leave this with someone here, you can decide the
best way to resolve this.

rday

p.s.  if memory serves, there was another MIPS-related config variable
that was unreferenced.  i'll see if i can track it down.


-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================