* [PATCH 1/3] WATCHDOG: mtx1-wdt: use dev_{err,info} instead of printk()
@ 2011-06-02 12:54 Florian Fainelli
2011-06-02 13:04 ` Manuel Lauss
0 siblings, 1 reply; 2+ messages in thread
From: Florian Fainelli @ 2011-06-02 12:54 UTC (permalink / raw)
To: Wim Van Sebroeck, linux-mips, linux-watchdog, Manuel Lauss
Signed-off-by: Florian Fainelli <florian@openwrt.org>
---
diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
index 1479dc4..63df28c 100644
--- a/drivers/watchdog/mtx-1_wdt.c
+++ b/drivers/watchdog/mtx-1_wdt.c
@@ -224,11 +224,11 @@ static int __devinit mtx1_wdt_probe(struct platform_device *pdev)
ret = misc_register(&mtx1_wdt_misc);
if (ret < 0) {
- printk(KERN_ERR " mtx-1_wdt : failed to register\n");
+ dev_err(&pdev->dev, "failed to register\n");
return ret;
}
mtx1_wdt_start();
- printk(KERN_INFO "MTX-1 Watchdog driver\n");
+ dev_info(&pdev->dev, "MTX-1 Watchdog driver\n");
return 0;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH 1/3] WATCHDOG: mtx1-wdt: use dev_{err,info} instead of printk()
2011-06-02 12:54 [PATCH 1/3] WATCHDOG: mtx1-wdt: use dev_{err,info} instead of printk() Florian Fainelli
@ 2011-06-02 13:04 ` Manuel Lauss
0 siblings, 0 replies; 2+ messages in thread
From: Manuel Lauss @ 2011-06-02 13:04 UTC (permalink / raw)
To: Florian Fainelli; +Cc: Wim Van Sebroeck, linux-mips, linux-watchdog
Hi Florian,
On Thu, Jun 2, 2011 at 2:54 PM, Florian Fainelli <florian@openwrt.org> wrote:
>
> Signed-off-by: Florian Fainelli <florian@openwrt.org>
> ---
> diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
While you're at it, please change line 246 from
static struct platform_driver mtx1_wdt = {
to
static struct platform_driver mtx1_wdt_driver = {
to get rid of a really annoying section mismatch warning.
Thanks!
Manuel Lauss
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-06-02 13:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-02 12:54 [PATCH 1/3] WATCHDOG: mtx1-wdt: use dev_{err,info} instead of printk() Florian Fainelli
2011-06-02 13:04 ` Manuel Lauss
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox