* [PATCH 02/11] arch/mips: do not use EXTRA_CFLAGS
[not found] <1313384834-24433-1-git-send-email-lacombar@gmail.com>
@ 2011-08-15 5:07 ` Arnaud Lacombe
2011-08-15 9:45 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Arnaud Lacombe @ 2011-08-15 5:07 UTC (permalink / raw)
To: linux-kernel; +Cc: Arnaud Lacombe, Sam Ravnborg, linux-mips
Usage of these flags has been deprecated for nearly 4 years by:
commit f77bf01425b11947eeb3b5b54685212c302741b8
Author: Sam Ravnborg <sam@neptun.(none)>
Date: Mon Oct 15 22:25:06 2007 +0200
kbuild: introduce ccflags-y, asflags-y and ldflags-y
Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command
line use. By default, gmake(1) do not override command line setting, so this is
likely to result in build failure or unexpected behavior.
Replace their usage by Kbuild's `{as,cc,ld}flags-y'.
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-mips@linux-mips.org
---
arch/mips/netlogic/xlr/Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/netlogic/xlr/Makefile b/arch/mips/netlogic/xlr/Makefile
index 9bd3f73..2dca585 100644
--- a/arch/mips/netlogic/xlr/Makefile
+++ b/arch/mips/netlogic/xlr/Makefile
@@ -2,4 +2,4 @@ obj-y += setup.o platform.o irq.o setup.o time.o
obj-$(CONFIG_SMP) += smp.o smpboot.o
obj-$(CONFIG_EARLY_PRINTK) += xlr_console.o
-EXTRA_CFLAGS += -Werror
+ccflags-y += -Werror
--
1.7.6.153.g78432
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 02/11] arch/mips: do not use EXTRA_CFLAGS
2011-08-15 5:07 ` [PATCH 02/11] arch/mips: do not use EXTRA_CFLAGS Arnaud Lacombe
@ 2011-08-15 9:45 ` Sergei Shtylyov
2011-08-15 13:55 ` Ralf Baechle
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2011-08-15 9:45 UTC (permalink / raw)
To: Arnaud Lacombe; +Cc: linux-kernel, Sam Ravnborg, linux-mips
Hello.
On 15-08-2011 9:07, Arnaud Lacombe wrote:
> Usage of these flags has been deprecated for nearly 4 years by:
> commit f77bf01425b11947eeb3b5b54685212c302741b8
> Author: Sam Ravnborg<sam@neptun.(none)>
> Date: Mon Oct 15 22:25:06 2007 +0200
> kbuild: introduce ccflags-y, asflags-y and ldflags-y
> Moreover, these flags (at least EXTRA_CFLAGS) have been documented for command
> line use. By default, gmake(1) do not override command line setting, so this is
> likely to result in build failure or unexpected behavior.
> Replace their usage by Kbuild's `{as,cc,ld}flags-y'.
> Cc: Sam Ravnborg<sam@ravnborg.org>
> Cc: linux-mips@linux-mips.org
You didn't sign off.
WBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 02/11] arch/mips: do not use EXTRA_CFLAGS
2011-08-15 9:45 ` Sergei Shtylyov
@ 2011-08-15 13:55 ` Ralf Baechle
2011-08-15 16:19 ` Arnaud Lacombe
0 siblings, 1 reply; 6+ messages in thread
From: Ralf Baechle @ 2011-08-15 13:55 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Arnaud Lacombe, linux-kernel, Sam Ravnborg, linux-mips
On Mon, Aug 15, 2011 at 01:45:04PM +0400, Sergei Shtylyov wrote:
> You didn't sign off.
True - but I won't make a big fuzz about that for a one-line. I'm sure
Arnaud will vow to do right the next time :-)
Applied. Thanks, Arnaud!
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 02/11] arch/mips: do not use EXTRA_CFLAGS
2011-08-15 13:55 ` Ralf Baechle
@ 2011-08-15 16:19 ` Arnaud Lacombe
2011-08-15 17:28 ` Jayachandran C.
0 siblings, 1 reply; 6+ messages in thread
From: Arnaud Lacombe @ 2011-08-15 16:19 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Sergei Shtylyov, linux-kernel, Sam Ravnborg, linux-mips
Hi,
On Mon, Aug 15, 2011 at 9:55 AM, Ralf Baechle <ralf@linux-mips.org> wrote:
> On Mon, Aug 15, 2011 at 01:45:04PM +0400, Sergei Shtylyov wrote:
>
>> You didn't sign off.
>
> True - but I won't make a big fuzz about that for a one-line. I'm sure
> Arnaud will vow to do right the next time :-)
>
You are welcome to slap me. If it's not too late:
Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
- Arnaud
> Applied. Thanks, Arnaud!
>
> Ralf
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 02/11] arch/mips: do not use EXTRA_CFLAGS
2011-08-15 16:19 ` Arnaud Lacombe
@ 2011-08-15 17:28 ` Jayachandran C.
2011-08-16 10:05 ` Ralf Baechle
0 siblings, 1 reply; 6+ messages in thread
From: Jayachandran C. @ 2011-08-15 17:28 UTC (permalink / raw)
To: Arnaud Lacombe
Cc: Ralf Baechle, Sergei Shtylyov, linux-kernel, Sam Ravnborg,
linux-mips
On Mon, Aug 15, 2011 at 9:49 PM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> Hi,
>
> On Mon, Aug 15, 2011 at 9:55 AM, Ralf Baechle <ralf@linux-mips.org> wrote:
>> On Mon, Aug 15, 2011 at 01:45:04PM +0400, Sergei Shtylyov wrote:
>>
>>> You didn't sign off.
>>
>> True - but I won't make a big fuzz about that for a one-line. I'm sure
>> Arnaud will vow to do right the next time :-)
>>
> You are welcome to slap me. If it's not too late:
>
> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
Thanks for fixing this up. Looks like an acked-by is not needed :)
JC (Netlogic XLR/XLS maintainer)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 02/11] arch/mips: do not use EXTRA_CFLAGS
2011-08-15 17:28 ` Jayachandran C.
@ 2011-08-16 10:05 ` Ralf Baechle
0 siblings, 0 replies; 6+ messages in thread
From: Ralf Baechle @ 2011-08-16 10:05 UTC (permalink / raw)
To: Jayachandran C.
Cc: Arnaud Lacombe, Sergei Shtylyov, linux-kernel, Sam Ravnborg,
linux-mips
On Mon, Aug 15, 2011 at 10:58:27PM +0530, Jayachandran C. wrote:
> On Mon, Aug 15, 2011 at 9:49 PM, Arnaud Lacombe <lacombar@gmail.com> wrote:
> > Hi,
> >
> > On Mon, Aug 15, 2011 at 9:55 AM, Ralf Baechle <ralf@linux-mips.org> wrote:
> >> On Mon, Aug 15, 2011 at 01:45:04PM +0400, Sergei Shtylyov wrote:
> >>
> >>> You didn't sign off.
> >>
> >> True - but I won't make a big fuzz about that for a one-line. I'm sure
> >> Arnaud will vow to do right the next time :-)
> >>
> > You are welcome to slap me. If it's not too late:
> >
> > Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
>
> Thanks for fixing this up. Looks like an acked-by is not needed :)
No - but generally an Acked-by: a maintainer or Reviewed-by: or Tested-by:
somebody else is always welcome. The more eyeballs, the better :-)
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-08-16 10:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1313384834-24433-1-git-send-email-lacombar@gmail.com>
2011-08-15 5:07 ` [PATCH 02/11] arch/mips: do not use EXTRA_CFLAGS Arnaud Lacombe
2011-08-15 9:45 ` Sergei Shtylyov
2011-08-15 13:55 ` Ralf Baechle
2011-08-15 16:19 ` Arnaud Lacombe
2011-08-15 17:28 ` Jayachandran C.
2011-08-16 10:05 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox