* [PATCH 1/2] MIPS: JZ4740: fix '#include guard' in serial.h
@ 2012-10-15 21:38 Antony Pavlov
2012-10-15 21:38 ` [PATCH 2/2] MIPS: JZ4740: add missing header file to serial.h Antony Pavlov
0 siblings, 1 reply; 5+ messages in thread
From: Antony Pavlov @ 2012-10-15 21:38 UTC (permalink / raw)
To: linux-mips; +Cc: Ralf Baechle, Lars-Peter Clausen, Antony Pavlov
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
arch/mips/jz4740/serial.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/jz4740/serial.h b/arch/mips/jz4740/serial.h
index b9fe3ad..aa5a939 100644
--- a/arch/mips/jz4740/serial.h
+++ b/arch/mips/jz4740/serial.h
@@ -14,6 +14,7 @@
*/
#ifndef __MIPS_JZ4740_SERIAL_H__
+#define __MIPS_JZ4740_SERIAL_H__
void jz4740_serial_out(struct uart_port *p, int offset, int value);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] MIPS: JZ4740: add missing header file to serial.h
2012-10-15 21:38 [PATCH 1/2] MIPS: JZ4740: fix '#include guard' in serial.h Antony Pavlov
@ 2012-10-15 21:38 ` Antony Pavlov
2012-10-16 8:19 ` Geert Uytterhoeven
2012-10-17 14:59 ` Ralf Baechle
0 siblings, 2 replies; 5+ messages in thread
From: Antony Pavlov @ 2012-10-15 21:38 UTC (permalink / raw)
To: linux-mips; +Cc: Ralf Baechle, Lars-Peter Clausen, Antony Pavlov
The 'uart_port' struct is used in the declaration of
the jz4740_serial_out() function.
This commit adds the missing header file containing
declaration of the 'uart_port' struct.
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
arch/mips/jz4740/serial.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/mips/jz4740/serial.h b/arch/mips/jz4740/serial.h
index aa5a939..dfc155c 100644
--- a/arch/mips/jz4740/serial.h
+++ b/arch/mips/jz4740/serial.h
@@ -16,6 +16,8 @@
#ifndef __MIPS_JZ4740_SERIAL_H__
#define __MIPS_JZ4740_SERIAL_H__
+#include <linux/serial_core.h>
+
void jz4740_serial_out(struct uart_port *p, int offset, int value);
#endif
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] MIPS: JZ4740: add missing header file to serial.h
2012-10-15 21:38 ` [PATCH 2/2] MIPS: JZ4740: add missing header file to serial.h Antony Pavlov
@ 2012-10-16 8:19 ` Geert Uytterhoeven
2012-10-17 15:03 ` Ralf Baechle
2012-10-17 14:59 ` Ralf Baechle
1 sibling, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2012-10-16 8:19 UTC (permalink / raw)
To: Antony Pavlov; +Cc: linux-mips, Ralf Baechle, Lars-Peter Clausen
On Mon, Oct 15, 2012 at 11:38 PM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> The 'uart_port' struct is used in the declaration of
> the jz4740_serial_out() function.
It only needs a forward declaration, as it just references the pointer type.
> This commit adds the missing header file containing
> declaration of the 'uart_port' struct.
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> ---
> arch/mips/jz4740/serial.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/jz4740/serial.h b/arch/mips/jz4740/serial.h
> index aa5a939..dfc155c 100644
> --- a/arch/mips/jz4740/serial.h
> +++ b/arch/mips/jz4740/serial.h
> @@ -16,6 +16,8 @@
> #ifndef __MIPS_JZ4740_SERIAL_H__
> #define __MIPS_JZ4740_SERIAL_H__
>
> +#include <linux/serial_core.h>
> +
I.e. you can just use instead:
struct uart_port;
> void jz4740_serial_out(struct uart_port *p, int offset, int value);
>
> #endif
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] MIPS: JZ4740: add missing header file to serial.h
2012-10-16 8:19 ` Geert Uytterhoeven
@ 2012-10-17 15:03 ` Ralf Baechle
0 siblings, 0 replies; 5+ messages in thread
From: Ralf Baechle @ 2012-10-17 15:03 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Antony Pavlov, linux-mips, Lars-Peter Clausen
On Tue, Oct 16, 2012 at 10:19:33AM +0200, Geert Uytterhoeven wrote:
> On Mon, Oct 15, 2012 at 11:38 PM, Antony Pavlov <antonynpavlov@gmail.com> wrote:
> > The 'uart_port' struct is used in the declaration of
> > the jz4740_serial_out() function.
>
> It only needs a forward declaration, as it just references the pointer type.
>
> > This commit adds the missing header file containing
> > declaration of the 'uart_port' struct.
> >
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > ---
> > arch/mips/jz4740/serial.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/mips/jz4740/serial.h b/arch/mips/jz4740/serial.h
> > index aa5a939..dfc155c 100644
> > --- a/arch/mips/jz4740/serial.h
> > +++ b/arch/mips/jz4740/serial.h
> > @@ -16,6 +16,8 @@
> > #ifndef __MIPS_JZ4740_SERIAL_H__
> > #define __MIPS_JZ4740_SERIAL_H__
> >
> > +#include <linux/serial_core.h>
> > +
>
> I.e. you can just use instead:
>
> struct uart_port;
>
> > void jz4740_serial_out(struct uart_port *p, int offset, int value);
> >
> > #endif
Serial_core.h drags in eerythign and the kitchen sink so I really prefer
the forward declaration.
Ralf
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] MIPS: JZ4740: add missing header file to serial.h
2012-10-15 21:38 ` [PATCH 2/2] MIPS: JZ4740: add missing header file to serial.h Antony Pavlov
2012-10-16 8:19 ` Geert Uytterhoeven
@ 2012-10-17 14:59 ` Ralf Baechle
1 sibling, 0 replies; 5+ messages in thread
From: Ralf Baechle @ 2012-10-17 14:59 UTC (permalink / raw)
To: Antony Pavlov; +Cc: linux-mips, Lars-Peter Clausen
Thanks, applied.
Ralf
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-17 15:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-15 21:38 [PATCH 1/2] MIPS: JZ4740: fix '#include guard' in serial.h Antony Pavlov
2012-10-15 21:38 ` [PATCH 2/2] MIPS: JZ4740: add missing header file to serial.h Antony Pavlov
2012-10-16 8:19 ` Geert Uytterhoeven
2012-10-17 15:03 ` Ralf Baechle
2012-10-17 14:59 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox