* [PATCH 12/19] net/ethernet/sgi/ioc3-eth: Use module_pci_driver to register driver [not found] <1369176146-19383-1-git-send-email-peterhuewe@gmx.de> @ 2013-05-21 22:58 ` Peter Huewe 2013-05-21 22:58 ` Peter Huewe 2013-05-22 7:53 ` Ralf Baechle 0 siblings, 2 replies; 3+ messages in thread From: Peter Huewe @ 2013-05-21 22:58 UTC (permalink / raw) To: David S. Miller Cc: Peter Huewe, Ralf Baechle, open list:IOC3 ETHERNET DRIVER, open list:NETWORKING DRIVERS, open list Removing some boilerplate by using module_pci_driver instead of calling register and unregister in the otherwise empty init/exit functions. Signed-off-by: Peter Huewe <peterhuewe@gmx.de> --- drivers/net/ethernet/sgi/ioc3-eth.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c index 7ed08c3..ffa7843 100644 --- a/drivers/net/ethernet/sgi/ioc3-eth.c +++ b/drivers/net/ethernet/sgi/ioc3-eth.c @@ -1398,16 +1398,6 @@ static struct pci_driver ioc3_driver = { .remove = ioc3_remove_one, }; -static int __init ioc3_init_module(void) -{ - return pci_register_driver(&ioc3_driver); -} - -static void __exit ioc3_cleanup_module(void) -{ - pci_unregister_driver(&ioc3_driver); -} - static int ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev) { unsigned long data; @@ -1677,9 +1667,7 @@ static void ioc3_set_multicast_list(struct net_device *dev) netif_wake_queue(dev); /* Let us get going again. */ } +module_pci_driver(ioc3_driver); MODULE_AUTHOR("Ralf Baechle <ralf@linux-mips.org>"); MODULE_DESCRIPTION("SGI IOC3 Ethernet driver"); MODULE_LICENSE("GPL"); - -module_init(ioc3_init_module); -module_exit(ioc3_cleanup_module); -- 1.8.1.5 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 12/19] net/ethernet/sgi/ioc3-eth: Use module_pci_driver to register driver 2013-05-21 22:58 ` [PATCH 12/19] net/ethernet/sgi/ioc3-eth: Use module_pci_driver to register driver Peter Huewe @ 2013-05-21 22:58 ` Peter Huewe 2013-05-22 7:53 ` Ralf Baechle 1 sibling, 0 replies; 3+ messages in thread From: Peter Huewe @ 2013-05-21 22:58 UTC (permalink / raw) To: David S. Miller Cc: Peter Huewe, Ralf Baechle, open list:IOC3 ETHERNET DRIVER, open list:NETWORKING DRIVERS, open list Removing some boilerplate by using module_pci_driver instead of calling register and unregister in the otherwise empty init/exit functions. Signed-off-by: Peter Huewe <peterhuewe@gmx.de> --- drivers/net/ethernet/sgi/ioc3-eth.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/net/ethernet/sgi/ioc3-eth.c b/drivers/net/ethernet/sgi/ioc3-eth.c index 7ed08c3..ffa7843 100644 --- a/drivers/net/ethernet/sgi/ioc3-eth.c +++ b/drivers/net/ethernet/sgi/ioc3-eth.c @@ -1398,16 +1398,6 @@ static struct pci_driver ioc3_driver = { .remove = ioc3_remove_one, }; -static int __init ioc3_init_module(void) -{ - return pci_register_driver(&ioc3_driver); -} - -static void __exit ioc3_cleanup_module(void) -{ - pci_unregister_driver(&ioc3_driver); -} - static int ioc3_start_xmit(struct sk_buff *skb, struct net_device *dev) { unsigned long data; @@ -1677,9 +1667,7 @@ static void ioc3_set_multicast_list(struct net_device *dev) netif_wake_queue(dev); /* Let us get going again. */ } +module_pci_driver(ioc3_driver); MODULE_AUTHOR("Ralf Baechle <ralf@linux-mips.org>"); MODULE_DESCRIPTION("SGI IOC3 Ethernet driver"); MODULE_LICENSE("GPL"); - -module_init(ioc3_init_module); -module_exit(ioc3_cleanup_module); -- 1.8.1.5 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 12/19] net/ethernet/sgi/ioc3-eth: Use module_pci_driver to register driver 2013-05-21 22:58 ` [PATCH 12/19] net/ethernet/sgi/ioc3-eth: Use module_pci_driver to register driver Peter Huewe 2013-05-21 22:58 ` Peter Huewe @ 2013-05-22 7:53 ` Ralf Baechle 1 sibling, 0 replies; 3+ messages in thread From: Ralf Baechle @ 2013-05-22 7:53 UTC (permalink / raw) To: Peter Huewe Cc: David S. Miller, open list:IOC3 ETHERNET DRIVER, open list:NETWORKING DRIVERS, open list On Wed, May 22, 2013 at 12:58:07AM +0200, Peter Huewe wrote: Looks good. Ralf ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-05-22 7:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1369176146-19383-1-git-send-email-peterhuewe@gmx.de>
2013-05-21 22:58 ` [PATCH 12/19] net/ethernet/sgi/ioc3-eth: Use module_pci_driver to register driver Peter Huewe
2013-05-21 22:58 ` Peter Huewe
2013-05-22 7:53 ` Ralf Baechle
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox