From: Ralf Baechle <ralf@linux-mips.org>
To: Markos Chandras <markos.chandras@imgtec.com>
Cc: linux-mips@linux-mips.org, "Steven J. Hill" <Steven.Hill@imgtec.com>
Subject: Re: [PATCH] MIPS: ftrace: Add missing CONFIG_DYNAMIC_FTRACE
Date: Mon, 10 Jun 2013 18:21:01 +0200 [thread overview]
Message-ID: <20130610162101.GE5303@linux-mips.org> (raw)
In-Reply-To: <1370864126-24931-1-git-send-email-markos.chandras@imgtec.com>
On Mon, Jun 10, 2013 at 12:35:26PM +0100, Markos Chandras wrote:
> arch_ftrace_update_code and ftrace_modify_all_code are only
> available if CONFIG_DYNAMIC_FTRACE is selected.
>
> Fixes the following build problem on MIPS randconfig:
>
> arch/mips/kernel/ftrace.c: In function 'arch_ftrace_update_code':
> arch/mips/kernel/ftrace.c:31:2: error: implicit declaration of function
> 'ftrace_modify_all_code' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
Patch is looking ok but I'm wonder abou thte SoB headers. Since you
appear to be the patch author and are sending your own patch, one would
only expect your own SoB. So I assume Steve's SoB was really meant to be
an Acked-by:? Sam ealso for the other patch I accepted moments ago.
Ralf
prev parent reply other threads:[~2013-06-10 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 11:35 [PATCH] MIPS: ftrace: Add missing CONFIG_DYNAMIC_FTRACE Markos Chandras
2013-06-10 11:35 ` Markos Chandras
2013-06-10 16:21 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130610162101.GE5303@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Steven.Hill@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox