* [PATCH] MIPS: ftrace: Add missing CONFIG_DYNAMIC_FTRACE
@ 2013-06-10 11:35 Markos Chandras
2013-06-10 11:35 ` Markos Chandras
2013-06-10 16:21 ` Ralf Baechle
0 siblings, 2 replies; 3+ messages in thread
From: Markos Chandras @ 2013-06-10 11:35 UTC (permalink / raw)
To: linux-mips; +Cc: Markos Chandras, Steven J. Hill
arch_ftrace_update_code and ftrace_modify_all_code are only
available if CONFIG_DYNAMIC_FTRACE is selected.
Fixes the following build problem on MIPS randconfig:
arch/mips/kernel/ftrace.c: In function 'arch_ftrace_update_code':
arch/mips/kernel/ftrace.c:31:2: error: implicit declaration of function
'ftrace_modify_all_code' [-Werror=implicit-function-declaration]
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
---
arch/mips/kernel/ftrace.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c
index cf5509f..dba90ec 100644
--- a/arch/mips/kernel/ftrace.c
+++ b/arch/mips/kernel/ftrace.c
@@ -25,12 +25,16 @@
#define MCOUNT_OFFSET_INSNS 4
#endif
+#ifdef CONFIG_DYNAMIC_FTRACE
+
/* Arch override because MIPS doesn't need to run this from stop_machine() */
void arch_ftrace_update_code(int command)
{
ftrace_modify_all_code(command);
}
+#endif
+
/*
* Check if the address is in kernel space
*
--
1.8.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] MIPS: ftrace: Add missing CONFIG_DYNAMIC_FTRACE
2013-06-10 11:35 [PATCH] MIPS: ftrace: Add missing CONFIG_DYNAMIC_FTRACE Markos Chandras
@ 2013-06-10 11:35 ` Markos Chandras
2013-06-10 16:21 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Markos Chandras @ 2013-06-10 11:35 UTC (permalink / raw)
To: linux-mips; +Cc: Markos Chandras, Steven J. Hill
arch_ftrace_update_code and ftrace_modify_all_code are only
available if CONFIG_DYNAMIC_FTRACE is selected.
Fixes the following build problem on MIPS randconfig:
arch/mips/kernel/ftrace.c: In function 'arch_ftrace_update_code':
arch/mips/kernel/ftrace.c:31:2: error: implicit declaration of function
'ftrace_modify_all_code' [-Werror=implicit-function-declaration]
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
---
arch/mips/kernel/ftrace.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c
index cf5509f..dba90ec 100644
--- a/arch/mips/kernel/ftrace.c
+++ b/arch/mips/kernel/ftrace.c
@@ -25,12 +25,16 @@
#define MCOUNT_OFFSET_INSNS 4
#endif
+#ifdef CONFIG_DYNAMIC_FTRACE
+
/* Arch override because MIPS doesn't need to run this from stop_machine() */
void arch_ftrace_update_code(int command)
{
ftrace_modify_all_code(command);
}
+#endif
+
/*
* Check if the address is in kernel space
*
--
1.8.2.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] MIPS: ftrace: Add missing CONFIG_DYNAMIC_FTRACE
2013-06-10 11:35 [PATCH] MIPS: ftrace: Add missing CONFIG_DYNAMIC_FTRACE Markos Chandras
2013-06-10 11:35 ` Markos Chandras
@ 2013-06-10 16:21 ` Ralf Baechle
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2013-06-10 16:21 UTC (permalink / raw)
To: Markos Chandras; +Cc: linux-mips, Steven J. Hill
On Mon, Jun 10, 2013 at 12:35:26PM +0100, Markos Chandras wrote:
> arch_ftrace_update_code and ftrace_modify_all_code are only
> available if CONFIG_DYNAMIC_FTRACE is selected.
>
> Fixes the following build problem on MIPS randconfig:
>
> arch/mips/kernel/ftrace.c: In function 'arch_ftrace_update_code':
> arch/mips/kernel/ftrace.c:31:2: error: implicit declaration of function
> 'ftrace_modify_all_code' [-Werror=implicit-function-declaration]
>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> Signed-off-by: Steven J. Hill <Steven.Hill@imgtec.com>
Patch is looking ok but I'm wonder abou thte SoB headers. Since you
appear to be the patch author and are sending your own patch, one would
only expect your own SoB. So I assume Steve's SoB was really meant to be
an Acked-by:? Sam ealso for the other patch I accepted moments ago.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-10 16:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-10 11:35 [PATCH] MIPS: ftrace: Add missing CONFIG_DYNAMIC_FTRACE Markos Chandras
2013-06-10 11:35 ` Markos Chandras
2013-06-10 16:21 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox