From: Ralf Baechle <ralf@linux-mips.org>
To: Florian Fainelli <florian@openwrt.org>
Cc: Markos Chandras <markos.chandras@imgtec.com>,
Linux-MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: Kconfig: Add missing MODULES dependency to VPE_LOADER
Date: Fri, 28 Jun 2013 16:21:10 +0200 [thread overview]
Message-ID: <20130628142110.GO10727@linux-mips.org> (raw)
In-Reply-To: <CAGVrzcbyzgM8fnmO31eKMqDokV2gjS6Ds=Qd84Mz71ipvEDtqg@mail.gmail.com>
On Fri, Jun 28, 2013 at 02:40:17PM +0100, Florian Fainelli wrote:
> 2013/6/28 Ralf Baechle <ralf@linux-mips.org>:
> > On Fri, Jun 28, 2013 at 01:25:27PM +0100, Markos Chandras wrote:
> >
> >> The vpe.c code uses the 'struct module' which is only available if
> >> CONFIG_MODULES is selected.
> >>
> >> Also fixes the following build problem on a lantiq allmodconfig:
> >> In file included from arch/mips/kernel/vpe.c:41:0:
> >> include/linux/moduleloader.h: In function 'apply_relocate':
> >> include/linux/moduleloader.h:48:63: error: dereferencing pointer
> >> to incomplete type
> >> include/linux/moduleloader.h: In function 'apply_relocate_add':
> >> include/linux/moduleloader.h:70:63: error: dereferencing pointer
> >> to incomplete type
> >>
> >> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> >> Reviewed-by: James Hogan <james.hogan@imgtec.com>
> >
> > Sigh. One more bug in the thing. It first of all shouldn't have been
> > designed recycling so much code from the module loader in inapropriate
> > ways.
> >
> > I'm going to apply the patch - but as usual whenver I have to touch the
> > VPE loader, kspd or rtlx I feel like a blunt chainsaw would be the right
> > way to fix this code.
> >
> > SPUFS is a special filesystem which was designed to use the Playstation 3's
> > synergetic elements. The code is in arch/powerpc/platforms/cell/spufs
> > and it's a far, cleaner interface to other processing thingies, be they
> > synergetic elements, or other cores, VPEs and TCs running bare metal
> > code or strage things like custom processors.
>
> Would not remoteproc be a simpler interface these days to load
> bare-metal ELF code into one of these things?
Once upon a time long before remoteproc was invented there was agreement
that SPUFS would be the way to go. Yes, remoteproc might be worth a
closer look.
Ralf
prev parent reply other threads:[~2013-06-28 14:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-28 12:25 [PATCH] MIPS: Kconfig: Add missing MODULES dependency to VPE_LOADER Markos Chandras
2013-06-28 12:25 ` Markos Chandras
2013-06-28 13:31 ` Ralf Baechle
2013-06-28 13:40 ` Florian Fainelli
2013-06-28 14:21 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130628142110.GO10727@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox