[PATCH] MIPS: Kconfig: Add missing MODULES dependency to VPE_LOADER

[PATCH] MIPS: Kconfig: Add missing MODULES dependency to VPE_LOADER

[Markos Chandras]

The vpe.c code uses the 'struct module' which is only available if
CONFIG_MODULES is selected.

Also fixes the following build problem on a lantiq allmodconfig:
In file included from arch/mips/kernel/vpe.c:41:0:
include/linux/moduleloader.h: In function 'apply_relocate':
include/linux/moduleloader.h:48:63: error: dereferencing pointer
to incomplete type
include/linux/moduleloader.h: In function 'apply_relocate_add':
include/linux/moduleloader.h:70:63: error: dereferencing pointer
to incomplete type

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
---
 arch/mips/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 8f5e646..77a6598 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -1929,7 +1929,7 @@ config MIPS_MT_FPAFF
 
 config MIPS_VPE_LOADER
 	bool "VPE loader support."
-	depends on SYS_SUPPORTS_MULTITHREADING
+	depends on SYS_SUPPORTS_MULTITHREADING && MODULES
 	select CPU_MIPSR2_IRQ_VI
 	select CPU_MIPSR2_IRQ_EI
 	select MIPS_MT
-- 
1.8.2.1

[PATCH] MIPS: Kconfig: Add missing MODULES dependency to VPE_LOADER

[Markos Chandras]

The vpe.c code uses the 'struct module' which is only available if
CONFIG_MODULES is selected.

Also fixes the following build problem on a lantiq allmodconfig:
In file included from arch/mips/kernel/vpe.c:41:0:
include/linux/moduleloader.h: In function 'apply_relocate':
include/linux/moduleloader.h:48:63: error: dereferencing pointer
to incomplete type
include/linux/moduleloader.h: In function 'apply_relocate_add':
include/linux/moduleloader.h:70:63: error: dereferencing pointer
to incomplete type

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Reviewed-by: James Hogan <james.hogan@imgtec.com>
---
 arch/mips/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 8f5e646..77a6598 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -1929,7 +1929,7 @@ config MIPS_MT_FPAFF
 
 config MIPS_VPE_LOADER
 	bool "VPE loader support."
-	depends on SYS_SUPPORTS_MULTITHREADING
+	depends on SYS_SUPPORTS_MULTITHREADING && MODULES
 	select CPU_MIPSR2_IRQ_VI
 	select CPU_MIPSR2_IRQ_EI
 	select MIPS_MT
-- 
1.8.2.1

Re: [PATCH] MIPS: Kconfig: Add missing MODULES dependency to VPE_LOADER

[Ralf Baechle]

On Fri, Jun 28, 2013 at 01:25:27PM +0100, Markos Chandras wrote:

> The vpe.c code uses the 'struct module' which is only available if
> CONFIG_MODULES is selected.
> 
> Also fixes the following build problem on a lantiq allmodconfig:
> In file included from arch/mips/kernel/vpe.c:41:0:
> include/linux/moduleloader.h: In function 'apply_relocate':
> include/linux/moduleloader.h:48:63: error: dereferencing pointer
> to incomplete type
> include/linux/moduleloader.h: In function 'apply_relocate_add':
> include/linux/moduleloader.h:70:63: error: dereferencing pointer
> to incomplete type
> 
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> Reviewed-by: James Hogan <james.hogan@imgtec.com>

Sigh.  One more bug in the thing.  It first of all shouldn't have been
designed recycling so much code from the module loader in inapropriate
ways.

I'm going to apply the patch - but as usual whenver I have to touch the
VPE loader, kspd or rtlx I feel like a blunt chainsaw would be the right
way to fix this code.

SPUFS is a special filesystem which was designed to use the Playstation 3's
synergetic elements.  The code is in arch/powerpc/platforms/cell/spufs
and it's a far, cleaner interface to other processing thingies, be they
synergetic elements, or other cores, VPEs and TCs running bare metal
code or strage things like custom processors.

See also Documentation/filesystems/spufs.txt in the kernel code or the
spufs(7) man page.

I'm not suggesting to strictly use the same interface as SPUFS but rather
as a template.

Doing things spufs style will also mean relocation will have to be
performed in userspace again.  That code exists in modutils for the
2.4 kernel.

  Ralf

Re: [PATCH] MIPS: Kconfig: Add missing MODULES dependency to VPE_LOADER

[Florian Fainelli]

2013/6/28 Ralf Baechle <ralf@linux-mips.org>:
> On Fri, Jun 28, 2013 at 01:25:27PM +0100, Markos Chandras wrote:
>
>> The vpe.c code uses the 'struct module' which is only available if
>> CONFIG_MODULES is selected.
>>
>> Also fixes the following build problem on a lantiq allmodconfig:
>> In file included from arch/mips/kernel/vpe.c:41:0:
>> include/linux/moduleloader.h: In function 'apply_relocate':
>> include/linux/moduleloader.h:48:63: error: dereferencing pointer
>> to incomplete type
>> include/linux/moduleloader.h: In function 'apply_relocate_add':
>> include/linux/moduleloader.h:70:63: error: dereferencing pointer
>> to incomplete type
>>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> Reviewed-by: James Hogan <james.hogan@imgtec.com>
>
> Sigh.  One more bug in the thing.  It first of all shouldn't have been
> designed recycling so much code from the module loader in inapropriate
> ways.
>
> I'm going to apply the patch - but as usual whenver I have to touch the
> VPE loader, kspd or rtlx I feel like a blunt chainsaw would be the right
> way to fix this code.
>
> SPUFS is a special filesystem which was designed to use the Playstation 3's
> synergetic elements.  The code is in arch/powerpc/platforms/cell/spufs
> and it's a far, cleaner interface to other processing thingies, be they
> synergetic elements, or other cores, VPEs and TCs running bare metal
> code or strage things like custom processors.

Would not remoteproc be a simpler interface these days to load
bare-metal ELF code into one of these things?
--
Florian

Re: [PATCH] MIPS: Kconfig: Add missing MODULES dependency to VPE_LOADER

[Ralf Baechle]

On Fri, Jun 28, 2013 at 02:40:17PM +0100, Florian Fainelli wrote:

> 2013/6/28 Ralf Baechle <ralf@linux-mips.org>:
> > On Fri, Jun 28, 2013 at 01:25:27PM +0100, Markos Chandras wrote:
> >
> >> The vpe.c code uses the 'struct module' which is only available if
> >> CONFIG_MODULES is selected.
> >>
> >> Also fixes the following build problem on a lantiq allmodconfig:
> >> In file included from arch/mips/kernel/vpe.c:41:0:
> >> include/linux/moduleloader.h: In function 'apply_relocate':
> >> include/linux/moduleloader.h:48:63: error: dereferencing pointer
> >> to incomplete type
> >> include/linux/moduleloader.h: In function 'apply_relocate_add':
> >> include/linux/moduleloader.h:70:63: error: dereferencing pointer
> >> to incomplete type
> >>
> >> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> >> Reviewed-by: James Hogan <james.hogan@imgtec.com>
> >
> > Sigh.  One more bug in the thing.  It first of all shouldn't have been
> > designed recycling so much code from the module loader in inapropriate
> > ways.
> >
> > I'm going to apply the patch - but as usual whenver I have to touch the
> > VPE loader, kspd or rtlx I feel like a blunt chainsaw would be the right
> > way to fix this code.
> >
> > SPUFS is a special filesystem which was designed to use the Playstation 3's
> > synergetic elements.  The code is in arch/powerpc/platforms/cell/spufs
> > and it's a far, cleaner interface to other processing thingies, be they
> > synergetic elements, or other cores, VPEs and TCs running bare metal
> > code or strage things like custom processors.
> 
> Would not remoteproc be a simpler interface these days to load
> bare-metal ELF code into one of these things?

Once upon a time long before remoteproc was invented there was agreement
that SPUFS would be the way to go.  Yes, remoteproc might be worth a
closer look.

  Ralf