* [PATCH] SOUND: au1x: Fix build
@ 2013-07-31 8:15 Ralf Baechle
2013-07-31 9:06 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Ralf Baechle @ 2013-07-31 8:15 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, alsa-devel
Cc: Manuel Lauss, Mark Brown, linux-mips
d8b51c11ff5a70244753ba60abfd47088cf4dcd4 [ASoC: ac97c: Use
module_platform_driver()] broke the build:
CC sound/soc/au1x/ac97c.o
/home/ralf/src/linux/upstream-sfr/sound/soc/au1x/ac97c.c:344:1: error: expected identifier or ‘(’ before ‘&’ token
/home/ralf/src/linux/upstream-sfr/sound/soc/au1x/ac97c.c:344:1: error: pasting "__initcall_" and "&" does not give a valid preprocessing token
/home/ralf/src/linux/upstream-sfr/sound/soc/au1x/ac97c.c:344:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘&’ token
/home/ralf/src/linux/upstream-sfr/sound/soc/au1x/ac97c.c:344:1: error: expected identifier or ‘(’ before ‘&’ token
/home/ralf/src/linux/upstream-sfr/sound/soc/au1x/ac97c.c:344:1: error: pasting "__exitcall_" and "&" does not give a valid preprocessing token
/home/ralf/src/linux/upstream-sfr/sound/soc/au1x/ac97c.c:344:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘&’ token
/home/ralf/src/linux/upstream-sfr/sound/soc/au1x/ac97c.c:334:31: warning: ‘au1xac97c_driver’ defined but not used [-Wunused-variable]
make[5]: *** [sound/soc/au1x/ac97c.o] Error 1
make[4]: *** [sound/soc/au1x] Error 2
make[3]: *** [sound/soc] Error 2
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
diff --git a/sound/soc/au1x/ac97c.c b/sound/soc/au1x/ac97c.c
index d6f7694..c8a2de1 100644
--- a/sound/soc/au1x/ac97c.c
+++ b/sound/soc/au1x/ac97c.c
@@ -341,7 +341,7 @@ static struct platform_driver au1xac97c_driver = {
.remove = au1xac97c_drvremove,
};
-module_platform_driver(&au1xac97c_driver);
+module_platform_driver(au1xac97c_driver);
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("Au1000/1500/1100 AC97C ASoC driver");
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] SOUND: au1x: Fix build
2013-07-31 8:15 [PATCH] SOUND: au1x: Fix build Ralf Baechle
@ 2013-07-31 9:06 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-07-31 9:06 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Liam Girdwood, alsa-devel, Manuel Lauss, linux-mips
[-- Attachment #1: Type: text/plain, Size: 245 bytes --]
On Wed, Jul 31, 2013 at 10:15:19AM +0200, Ralf Baechle wrote:
> d8b51c11ff5a70244753ba60abfd47088cf4dcd4 [ASoC: ac97c: Use
> module_platform_driver()] broke the build:
Applied. Please do try to use subject lines appropriate for the
subsystem.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-31 9:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-31 8:15 [PATCH] SOUND: au1x: Fix build Ralf Baechle
2013-07-31 9:06 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox