From: Ralf Baechle <ralf@linux-mips.org>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [MIPS] CP0 PRId and CP1 FPIR register access masks
Date: Tue, 17 Sep 2013 18:19:57 +0200 [thread overview]
Message-ID: <20130917161957.GH22468@linux-mips.org> (raw)
In-Reply-To: <alpine.LFD.2.03.1309171641260.5967@linux-mips.org>
On Tue, Sep 17, 2013 at 04:58:10PM +0100, Maciej W. Rozycki wrote:
> Replace hardcoded CP0 PRId and CP1 FPIR register access masks throughout.
> The change does not touch places that use shifted or partial masks.
>
> Signed-off-by: Maciej W. Rozycki <macro@linux-mips.org>
> ---
> Ralf,
>
> Please apply. I think the places ignored by this change should be
> further reviewed, especially the shifted masks that can likely remove the
> shifts and rely on compiler optimisation instead. I decided to make this
> change as straightforward as possible to avoid accidental breakage in code
> I have no way to test. Also partial masks are probably better handled
> with macros rather than hardcoded constants scattered throughout. I can
> see steps have been taken towards this already (PRID_REV_ENCODE_*).
Looks ok, queud for 3.13.
But while it's cleaner, I think the idiom read_c0_prid() & some_MASK is
so common that maybe something like
#define read_c0_prid_imp() (read_c0_prid() & PRID_IMP_MASK)
#define read_c0_prid_rev() (read_c0_prid() & PRID_REV_MASK)
#define read_c0_prid_comp() (read_c0_prid() & PRID_COMP_MASK)
should be introduced as a next step.
Ralf
next prev parent reply other threads:[~2013-09-17 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 15:58 [MIPS] CP0 PRId and CP1 FPIR register access masks Maciej W. Rozycki
2013-09-17 16:19 ` Ralf Baechle [this message]
2013-09-17 16:59 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130917161957.GH22468@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox