From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
Subject: Re: [MIPS] CP0 PRId and CP1 FPIR register access masks
Date: Tue, 17 Sep 2013 17:59:09 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.03.1309171752430.5967@linux-mips.org> (raw)
In-Reply-To: <20130917161957.GH22468@linux-mips.org>
On Tue, 17 Sep 2013, Ralf Baechle wrote:
> But while it's cleaner, I think the idiom read_c0_prid() & some_MASK is
> so common that maybe something like
>
> #define read_c0_prid_imp() (read_c0_prid() & PRID_IMP_MASK)
> #define read_c0_prid_rev() (read_c0_prid() & PRID_REV_MASK)
> #define read_c0_prid_comp() (read_c0_prid() & PRID_COMP_MASK)
>
> should be introduced as a next step.
In some places maybe. Other need several parts of PRId examined and
using these accessors would be a pessimisation (GCC cannot combine
multiple read_c0_prid() calls into one). Some further places should
probably use current_cpu_data.processor_id instead. Maybe even most
should. Overall I'm not sure how much use these macros would get after
all.
Maciej
prev parent reply other threads:[~2013-09-17 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 15:58 [MIPS] CP0 PRId and CP1 FPIR register access masks Maciej W. Rozycki
2013-09-17 16:19 ` Ralf Baechle
2013-09-17 16:59 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.03.1309171752430.5967@linux-mips.org \
--to=macro@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox