From: Ralf Baechle <ralf@linux-mips.org>
To: Markos Chandras <markos.chandras@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well
Date: Wed, 18 Sep 2013 13:33:34 +0200 [thread overview]
Message-ID: <20130918113333.GL22468@linux-mips.org> (raw)
In-Reply-To: <20130918111053.GK22468@linux-mips.org>
On Wed, Sep 18, 2013 at 01:10:53PM +0200, Ralf Baechle wrote:
> > The CMP code is only designed to work with SMP configurations.
> > Fixes multiple build problems on certain randconfigs:
>
> Applied - but I think the logic here may be backwards from a user's
> perspective. Shouldn't a user be asked for SMP first, then for
> possible platform suboptions (CMP, VSMP, SMTC) of SMP?
Also the "if SMP" in Kconfig
config MIPS_CMP
bool "MIPS CMP framework support"
depends on SYS_SUPPORTS_MIPS_CMP
+ select SMP
select SYNC_R4K
select SYS_SUPPORTS_SMP
select SYS_SUPPORTS_SCHED_SMT if SMP
^^^^^^
now does look a bit silly, doesn't it? I wonder what the original intention
was, possibly CMP support but only a uniprocessor kernel, that is
MIPS_CMP=y would enable the GIC only, something like that?
Ralf
prev parent reply other threads:[~2013-09-18 11:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 9:47 [PATCH] MIPS: Kconfig: CMP support needs to select SMP as well Markos Chandras
2013-09-06 9:47 ` Markos Chandras
2013-09-18 11:10 ` Ralf Baechle
2013-09-18 11:28 ` Markos Chandras
2013-09-18 11:28 ` Markos Chandras
2013-09-18 11:33 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130918113333.GL22468@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox