From: Ralf Baechle <ralf@linux-mips.org>
To: Huacai Chen <chenhc@lemote.com>
Cc: John Crispin <john@phrozen.org>,
linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>,
Hongliang Tao <taohl@lemote.com>, Hua Yan <yanh@lemote.com>
Subject: Re: [PATCH V12 00/13] MIPS: Add Loongson-3 based machines support
Date: Thu, 26 Sep 2013 14:45:36 +0200 [thread overview]
Message-ID: <20130926124536.GC31496@linux-mips.org> (raw)
In-Reply-To: <1380100546-8302-1-git-send-email-chenhc@lemote.com>
On Wed, Sep 25, 2013 at 05:15:34PM +0800, Huacai Chen wrote:
Generally this patchset is still adding an eyewatering number of
#ifdef CONFIG_CPU_LOONGSON2/3s to the code. What we had in the existing
code base was already ugly. So I just went through arch/mips removing
many of the existing ifdefs.
Will push that out to upstream-sfr a little later this afternoon.
This means, your patchset is not going to apply cleanly anymore!
Also I'm wondering about these two uses of CONFIG_CPU_LOONGSON2:
arch/mips/mm/tlbex.c:#if defined(CONFIG_32BIT) || defined(CONFIG_CPU_LOONGSON2)
arch/mips/mm/tlbex.c:#if defined(CONFIG_32BIT) || defined(CONFIG_CPU_LOONGSON2)
Why would we want to treat a Loongson2 - a 64 bit CPU after all - as a 32 bit
CPU? Can you explain?
Thanks!
Ralf
prev parent reply other threads:[~2013-09-26 12:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 9:15 [PATCH V12 00/13] MIPS: Add Loongson-3 based machines support Huacai Chen
2013-09-25 9:15 ` [PATCH V12 01/12] MIPS: Loongson: Add basic Loongson-3 definition Huacai Chen
2013-09-25 21:17 ` David Daney
2013-09-25 9:15 ` [PATCH V12 02/12] MIPS: Loongson: Add basic Loongson-3 CPU support Huacai Chen
2013-09-25 9:15 ` [PATCH V12 03/12] MIPS: Loongson 3: Add Lemote-3A machtypes definition Huacai Chen
2013-09-25 9:15 ` [PATCH V12 04/12] MIPS: Loongson: Add UEFI-like firmware interface support Huacai Chen
2013-09-25 9:15 ` [PATCH V12 05/12] MIPS: Loongson 3: Add HT-linked PCI support Huacai Chen
2013-09-25 9:15 ` [PATCH V12 06/12] MIPS: Loongson 3: Add IRQ init and dispatch support Huacai Chen
2013-09-25 9:15 ` [PATCH V12 07/12] MIPS: Loongson 3: Add serial port support Huacai Chen
2013-09-25 9:15 ` [PATCH V12 08/12] MIPS: Loongson: Add swiotlb to support big memory (>4GB) Huacai Chen
2013-09-25 9:15 ` [PATCH V12 09/12] MIPS: Loongson: Add Loongson-3 Kconfig options Huacai Chen
2013-09-25 21:20 ` David Daney
2013-09-25 9:15 ` [PATCH V12 10/12] MIPS: Loongson 3: Add Loongson-3 SMP support Huacai Chen
2013-09-25 9:15 ` [PATCH V12 11/12] MIPS: Loongson 3: Add CPU hotplug support Huacai Chen
2013-09-25 9:15 ` [PATCH V12 12/12] MIPS: Loongson: Add a Loongson-3 default config file Huacai Chen
2013-09-26 12:45 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130926124536.GC31496@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=chenhc@lemote.com \
--cc=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
--cc=taohl@lemote.com \
--cc=wuzhangjin@gmail.com \
--cc=yanh@lemote.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox