From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney.cavm@gmail.com>
Cc: Lars Persson <lars.persson@axis.com>,
linux-mips@linux-mips.org, Lars Persson <larper@axis.com>
Subject: Re: [PATCH v2] MIPS: Remove race window in page fault handling
Date: Fri, 8 Aug 2014 22:47:05 +0200 [thread overview]
Message-ID: <20140808204705.GH29898@linux-mips.org> (raw)
In-Reply-To: <53E500E4.5020509@gmail.com>
On Fri, Aug 08, 2014 at 09:55:00AM -0700, David Daney wrote:
> >+static inline void set_pte_at(struct mm_struct *mm, unsigned long addr,
> >+ pte_t *ptep, pte_t pteval);
> >+
>
> Is it possible to reorder the code such that this declaration is not
> necessary?
That's not as obvious as one might think initially. set_pte_at needs
to be defined after set_pte but before clear_pte which is calling set_pte_at.
Of both set_pte and clear_pte there are two #ifdefd variants.
set_pte_at is a fairly small function only but it's invoked quite a few
times so I was a little concerned about the effect on I'm experimenting with
outlining set_pte_at entirely. ip22_defconfig with the patch applied as
posted; this is the effect on code size.
text data bss dec hex filename
3790118 175304 84544 4049966 3dcc2e vmlinux as posted
3789062 175304 84544 4048910 3dc80e vmlinux set_pte_at outlined
Ralf
next prev parent reply other threads:[~2014-08-08 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 13:47 [PATCH v2] MIPS: Remove race window in page fault handling Lars Persson
2014-08-08 16:55 ` David Daney
2014-08-08 20:47 ` Ralf Baechle [this message]
2014-08-15 8:03 ` Lars Persson
2014-08-15 11:01 ` Ralf Baechle
2014-08-15 12:08 ` Lars Persson
2014-08-19 15:22 ` Ralf Baechle
2014-08-19 15:47 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140808204705.GH29898@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ddaney.cavm@gmail.com \
--cc=larper@axis.com \
--cc=lars.persson@axis.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox