From: Ralf Baechle <ralf@linux-mips.org>
To: Lars Persson <lars.persson@axis.com>
Cc: David Daney <ddaney.cavm@gmail.com>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Subject: Re: [PATCH v2] MIPS: Remove race window in page fault handling
Date: Tue, 19 Aug 2014 17:22:46 +0200 [thread overview]
Message-ID: <20140819152246.GF11547@linux-mips.org> (raw)
In-Reply-To: <1408104536.19220.7.camel@lnxlarper.se.axis.com>
On Fri, Aug 15, 2014 at 02:08:56PM +0200, Lars Persson wrote:
> This one was tricky to track down. We had sporadic SIGILLs in
> multi-threaded apps for a long time. Eventually we got a test case that
> triggered more page cache evictions and the frequency of SIGILLs
> increased enough to catch it with a JTAG debugger.
>
> Kernel call stacks showed one thread handling an illegal instruction
> exception while another thread was somewhere around the
> set_pte_at/update_mmu_cache calls for the same page.
Some of those coherency bugs are almost impossibly hard to track down
and fix properly!
Anyway, I'm going to send the outlined version of your fix to Linus.
Ralf
next prev parent reply other threads:[~2014-08-19 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 13:47 [PATCH v2] MIPS: Remove race window in page fault handling Lars Persson
2014-08-08 16:55 ` David Daney
2014-08-08 20:47 ` Ralf Baechle
2014-08-15 8:03 ` Lars Persson
2014-08-15 11:01 ` Ralf Baechle
2014-08-15 12:08 ` Lars Persson
2014-08-19 15:22 ` Ralf Baechle [this message]
2014-08-19 15:47 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140819152246.GF11547@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ddaney.cavm@gmail.com \
--cc=lars.persson@axis.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox