From: Jayachandran C. <jchandra@broadcom.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Huacai Chen <chenhc@lemote.com>, John Crispin <john@phrozen.org>,
"Steven J. Hill" <Steven.Hill@imgtec.com>,
Aurelien Jarno <aurelien@aurel32.net>,
<linux-mips@linux-mips.org>, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>
Subject: Re: [PATCH 1/2] MIPS: Move CPU topology macros to topology.h
Date: Wed, 13 Aug 2014 05:48:50 +0530 [thread overview]
Message-ID: <20140813001849.GA27602@jayachandranc.netlogicmicro.com> (raw)
In-Reply-To: <20140808134738.GG29898@linux-mips.org>
On Fri, Aug 08, 2014 at 03:47:38PM +0200, Ralf Baechle wrote:
> Jayachandran,
>
> could you convert the netlogic platforms to use this scheme, too?
> We then could drop the #ifdefs introduced by this patch.
The same sequence is used by ip27 platform as well, so I think the
ifndef may still be needed. This is the same ifndef pattern we use
for all our mach-generic/*.h vs. mach-<platform>/*.h
On second thought, I am not sure if the changes in Huacai's patch
has to be in asm/topology.h, probably this has to be in
mach-generic/topology.h
JC.
WARNING: multiple messages have this Message-ID (diff)
From: Jayachandran C. <jchandra@broadcom.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Huacai Chen <chenhc@lemote.com>, John Crispin <john@phrozen.org>,
"Steven J. Hill" <Steven.Hill@imgtec.com>,
Aurelien Jarno <aurelien@aurel32.net>,
linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>
Subject: Re: [PATCH 1/2] MIPS: Move CPU topology macros to topology.h
Date: Wed, 13 Aug 2014 05:48:50 +0530 [thread overview]
Message-ID: <20140813001849.GA27602@jayachandranc.netlogicmicro.com> (raw)
Message-ID: <20140813001850.jpNeEHGgB3gb2ga9IIScRwsIoy3dRDWh64rtF85SXg4@z> (raw)
In-Reply-To: <20140808134738.GG29898@linux-mips.org>
On Fri, Aug 08, 2014 at 03:47:38PM +0200, Ralf Baechle wrote:
> Jayachandran,
>
> could you convert the netlogic platforms to use this scheme, too?
> We then could drop the #ifdefs introduced by this patch.
The same sequence is used by ip27 platform as well, so I think the
ifndef may still be needed. This is the same ifndef pattern we use
for all our mach-generic/*.h vs. mach-<platform>/*.h
On second thought, I am not sure if the changes in Huacai's patch
has to be in asm/topology.h, probably this has to be in
mach-generic/topology.h
JC.
next prev parent reply other threads:[~2014-08-13 0:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 3:16 [PATCH 1/2] MIPS: Move CPU topology macros to topology.h Huacai Chen
2014-08-08 3:16 ` [PATCH 2/2] MIPS: Loongson: Fix COP2 usage for preemptible kernel Huacai Chen
2014-08-08 12:12 ` Sergei Shtylyov
2014-08-08 13:47 ` [PATCH 1/2] MIPS: Move CPU topology macros to topology.h Ralf Baechle
2014-08-13 0:18 ` Jayachandran C. [this message]
2014-08-13 0:18 ` Jayachandran C.
2014-08-20 3:57 ` Huacai Chen
2014-08-22 4:18 ` [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h Jayachandran C
2014-08-22 4:18 ` Jayachandran C
2014-08-22 4:18 ` [PATCH 2/2] MIPS: Move topology macros to topology.h Jayachandran C
2014-08-22 4:18 ` Jayachandran C
2014-08-25 13:20 ` [PATCH 1/2] MIPS: Netlogic: Use MIPS topology.h Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140813001849.GA27602@jayachandranc.netlogicmicro.com \
--to=jchandra@broadcom.com \
--cc=Steven.Hill@imgtec.com \
--cc=aurelien@aurel32.net \
--cc=chenhc@lemote.com \
--cc=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox