From: Ralf Baechle <ralf@linux-mips.org>
To: Huacai Chen <chenhc@lemote.com>
Cc: John Crispin <john@phrozen.org>,
"Steven J. Hill" <Steven.Hill@imgtec.com>,
linux-mips@linux-mips.org, Fuxin Zhang <zhangfx@lemote.com>,
Zhangjin Wu <wuzhangjin@gmail.com>,
Hongliang Tao <taohl@lemote.com>
Subject: Re: [PATCH V2 04/12] MIPS: Loongson: Introduce and use cpu_has_coherent_cache feature
Date: Tue, 11 Nov 2014 11:05:19 +0100 [thread overview]
Message-ID: <20141111100518.GC27259@linux-mips.org> (raw)
In-Reply-To: <1415081610-25639-5-git-send-email-chenhc@lemote.com>
On Tue, Nov 04, 2014 at 02:13:25PM +0800, Huacai Chen wrote:
> Loongson-3 maintains cache coherency by hardware. So we introduce a cpu
> feature named cpu_has_coherent_cache and use it to modify MIPS's cache
> flushing functions.
You've modified all the local_* functions which means the r4k_on_each_cpu()
in r4k___flush_cache_all(), r4k_flush_cache_sigtramp() otc. will still be
executed.
Your change is correct - but I think it can be optimized if we can assume
that all CPUs have a coherent cache by moving the check into the caller.
smp_call_function() can be fairly expensive in particular on big systems!
Ralf
next prev parent reply other threads:[~2014-11-11 10:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 6:13 [PATCH V2 00/12] MIPS: Loongson-3: Improve kernel functionality Huacai Chen
2014-11-04 6:13 ` [PATCH V2 01/12] MIPS: Loongson: Fix the write-combine CCA value setting Huacai Chen
2014-11-11 10:13 ` Ralf Baechle
2014-11-04 6:13 ` [PATCH V2 02/12] MIPS: Loongson: set Loongson-3's ISA level to MIPS64R1 Huacai Chen
2014-11-10 16:59 ` Ralf Baechle
2014-11-11 1:14 ` Huacai Chen
2014-11-11 9:33 ` Ralf Baechle
2014-11-04 6:13 ` [PATCH V2 03/12] MIPS: Loongson-3: Add PHYS48_TO_HT40 support Huacai Chen
2014-11-11 10:15 ` Ralf Baechle
2014-11-04 6:13 ` [PATCH V2 04/12] MIPS: Loongson: Introduce and use cpu_has_coherent_cache feature Huacai Chen
2014-11-11 10:05 ` Ralf Baechle [this message]
2014-11-04 6:13 ` [PATCH V2 05/12] MIPS: Loongson: Allow booting from any core Huacai Chen
2014-11-11 10:15 ` Ralf Baechle
2014-11-04 6:13 ` [PATCH V2 06/12] MIPS: Loongson: Improve LEFI firmware interface Huacai Chen
2014-11-11 10:16 ` Ralf Baechle
2014-11-04 6:13 ` [PATCH V2 07/12] MIPS: Loongson: Add Loongson-3A/3B GPIO support Huacai Chen
2014-11-11 10:18 ` Ralf Baechle
2014-11-11 12:45 ` Huacai Chen
2014-11-04 6:13 ` [PATCH V2 08/12] MIPS: Loongson-3: Add CPU Hwmon platform driver Huacai Chen
2014-11-11 10:23 ` Ralf Baechle
2014-11-11 12:44 ` Huacai Chen
2014-11-04 6:13 ` [PATCH V2 09/12] MIPS: Loongson-3: Add chipset ACPI " Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111100518.GC27259@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Steven.Hill@imgtec.com \
--cc=chenhc@lemote.com \
--cc=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
--cc=taohl@lemote.com \
--cc=wuzhangjin@gmail.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox