Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 01/11] MIPS: push .set arch=r4000 into the functions needing it
Date: Tue, 11 Nov 2014 15:19:36 +0100	[thread overview]
Message-ID: <20141111141935.GB29662@linux-mips.org> (raw)
In-Reply-To: <1411551942-11153-2-git-send-email-paul.burton@imgtec.com>

On Wed, Sep 24, 2014 at 10:45:32AM +0100, Paul Burton wrote:

> The {save,restore}_fp_context{,32} functions require that the assembler
> allows the use of sdc instructions on any FP register, and this is
> acomplished by setting the arch to r4000. However this has the effect
> of enabling the assembler to use mips64 instructions in the expansion
> of pseudo-instructions. This was done in the (now-reverted) commit
> eec43a224cf1 "MIPS: Save/restore MSA context around signals" which
> led to my mistakenly believing that there was an assembler bug, when
> in reality the assembler was just emitting mips64 instructions. Avoid
> the issue for future commits which will add code to r4k_fpu.S by
> pushing the .set arch=r4000 directives into the functions that require
> it, and remove the spurious assertion declaring the assembler bug.

I'm getting rejects applying patches 1 and 2 of this series and 3 looks
like it's likely not to apply either.  I suspect that's due to a
conflict with 842dfc11 (MIPS: Fix build with binutils 2.24.51+).  Can
you respin?

Thanks!

  Ralf

  parent reply	other threads:[~2014-11-11 14:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24  9:45 [PATCH 00/11] FP/MSA fixes Paul Burton
2014-09-24  9:45 ` Paul Burton
2014-09-24  9:45 ` [PATCH 01/11] MIPS: push .set arch=r4000 into the functions needing it Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-11-11 14:19   ` Ralf Baechle [this message]
2014-09-24  9:45 ` [PATCH 02/11] MIPS: assume at as source/dest of MSA copy/insert instructions Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24  9:45 ` [PATCH 03/11] MIPS: remove MSA macro recursion Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24  9:45 ` [PATCH 04/11] MIPS: wrap cfcmsa & ctcmsa accesses for toolchains with MSA support Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24 12:08   ` James Hogan
2014-09-24 12:08     ` James Hogan
2014-09-25  9:23     ` Paul Burton
2014-09-25  9:23       ` Paul Burton
2014-09-25 10:24       ` James Hogan
2014-09-25 10:24         ` James Hogan
2014-09-24  9:45 ` [PATCH 05/11] MIPS: clear MSACSR cause bits when handling MSA FP exception Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24 11:10   ` Sergei Shtylyov
2014-09-25  9:20     ` [PATCH v2 " Paul Burton
2014-09-25  9:20       ` Paul Burton
2014-09-24  9:45 ` [PATCH 06/11] MIPS: fix mfc1 & mfhc1 emulation for mips64 systems Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24  9:45 ` [PATCH 07/11] MIPS: ensure FCSR cause bits are clear after invoking FPU emulator Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24  9:45 ` [PATCH 08/11] MIPS: prevent FP context set via ptrace being discarded Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24  9:45 ` [PATCH 09/11] MIPS: disable FPU if the mode is unsupported Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24  9:45 ` [PATCH 10/11] Revert "MIPS: Don't assume 64-bit FP registers for context switch" Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24  9:45 ` [PATCH 11/11] MIPS: MSA: Fix big-endian FPR_IDX implementation Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24 13:00 ` [PATCH 00/11] FP/MSA fixes James Hogan
2014-09-24 13:00   ` James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141111141935.GB29662@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=linux-mips@linux-mips.org \
    --cc=paul.burton@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox