Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: James Hogan <james.hogan@imgtec.com>
To: Paul Burton <paul.burton@imgtec.com>, <linux-mips@linux-mips.org>
Subject: Re: [PATCH 00/11] FP/MSA fixes
Date: Wed, 24 Sep 2014 14:00:46 +0100	[thread overview]
Message-ID: <5422C07E.6080300@imgtec.com> (raw)
In-Reply-To: <1411551942-11153-1-git-send-email-paul.burton@imgtec.com>

On 24/09/14 10:45, Paul Burton wrote:
> This series fixes a bunch of bugs, both build & runtime, with FP & MSA
> support. Most of them only affect systems with the new FP modes & MSA
> support enabled but patch 6 in particular is more general, fixing
> problems for mips64 systems.

I don't claim to be particularly familiar with much of this code, but
FWIW I've read it through and haven't spotted anything wrong aside from
what has already been mentioned.

Thanks
James

> 
> James Hogan (2):
>   Revert "MIPS: Don't assume 64-bit FP registers for context switch"
>   MIPS: MSA: Fix big-endian FPR_IDX implementation
> 
> Paul Burton (9):
>   MIPS: push .set arch=r4000 into the functions needing it
>   MIPS: assume at as source/dest of MSA copy/insert instructions
>   MIPS: remove MSA macro recursion
>   MIPS: wrap cfcmsa & ctcmsa accesses for toolchains with MSA support
>   MIPS: clear MSACSR cause bits when handling MSA FP exception
>   MIPS: fix mfc1 & mfhc1 emulation for mips64 systems
>   MIPS: ensure FCSR cause bits are clear after invoking FPU emulator
>   MIPS: prevent FP context set via ptrace being discarded
>   MIPS: disable FPU if the mode is unsupported
> 
>  arch/mips/include/asm/asmmacro-32.h | 128 ++++++++++-----------
>  arch/mips/include/asm/asmmacro.h    | 218 +++++++++++++++++++++---------------
>  arch/mips/include/asm/fpu.h         |  19 ++--
>  arch/mips/include/asm/processor.h   |   2 +-
>  arch/mips/kernel/asm-offsets.c      |  66 -----------
>  arch/mips/kernel/genex.S            |  11 +-
>  arch/mips/kernel/ptrace.c           |  30 ++++-
>  arch/mips/kernel/r4k_fpu.S          |  13 ++-
>  arch/mips/kernel/traps.c            |  17 +--
>  arch/mips/math-emu/cp1emu.c         |   6 +-
>  10 files changed, 262 insertions(+), 248 deletions(-)
> 

WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Paul Burton <paul.burton@imgtec.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH 00/11] FP/MSA fixes
Date: Wed, 24 Sep 2014 14:00:46 +0100	[thread overview]
Message-ID: <5422C07E.6080300@imgtec.com> (raw)
Message-ID: <20140924130046.TM2Klle5G3aCo5hRpU9-bPxoeGnp5Rv17zOEdYp9kvs@z> (raw)
In-Reply-To: <1411551942-11153-1-git-send-email-paul.burton@imgtec.com>

On 24/09/14 10:45, Paul Burton wrote:
> This series fixes a bunch of bugs, both build & runtime, with FP & MSA
> support. Most of them only affect systems with the new FP modes & MSA
> support enabled but patch 6 in particular is more general, fixing
> problems for mips64 systems.

I don't claim to be particularly familiar with much of this code, but
FWIW I've read it through and haven't spotted anything wrong aside from
what has already been mentioned.

Thanks
James

> 
> James Hogan (2):
>   Revert "MIPS: Don't assume 64-bit FP registers for context switch"
>   MIPS: MSA: Fix big-endian FPR_IDX implementation
> 
> Paul Burton (9):
>   MIPS: push .set arch=r4000 into the functions needing it
>   MIPS: assume at as source/dest of MSA copy/insert instructions
>   MIPS: remove MSA macro recursion
>   MIPS: wrap cfcmsa & ctcmsa accesses for toolchains with MSA support
>   MIPS: clear MSACSR cause bits when handling MSA FP exception
>   MIPS: fix mfc1 & mfhc1 emulation for mips64 systems
>   MIPS: ensure FCSR cause bits are clear after invoking FPU emulator
>   MIPS: prevent FP context set via ptrace being discarded
>   MIPS: disable FPU if the mode is unsupported
> 
>  arch/mips/include/asm/asmmacro-32.h | 128 ++++++++++-----------
>  arch/mips/include/asm/asmmacro.h    | 218 +++++++++++++++++++++---------------
>  arch/mips/include/asm/fpu.h         |  19 ++--
>  arch/mips/include/asm/processor.h   |   2 +-
>  arch/mips/kernel/asm-offsets.c      |  66 -----------
>  arch/mips/kernel/genex.S            |  11 +-
>  arch/mips/kernel/ptrace.c           |  30 ++++-
>  arch/mips/kernel/r4k_fpu.S          |  13 ++-
>  arch/mips/kernel/traps.c            |  17 +--
>  arch/mips/math-emu/cp1emu.c         |   6 +-
>  10 files changed, 262 insertions(+), 248 deletions(-)
> 

  parent reply	other threads:[~2014-09-24 13:00 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24  9:45 [PATCH 00/11] FP/MSA fixes Paul Burton
2014-09-24  9:45 ` Paul Burton
2014-09-24  9:45 ` [PATCH 01/11] MIPS: push .set arch=r4000 into the functions needing it Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-11-11 14:19   ` Ralf Baechle
2014-09-24  9:45 ` [PATCH 02/11] MIPS: assume at as source/dest of MSA copy/insert instructions Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24  9:45 ` [PATCH 03/11] MIPS: remove MSA macro recursion Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24  9:45 ` [PATCH 04/11] MIPS: wrap cfcmsa & ctcmsa accesses for toolchains with MSA support Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24 12:08   ` James Hogan
2014-09-24 12:08     ` James Hogan
2014-09-25  9:23     ` Paul Burton
2014-09-25  9:23       ` Paul Burton
2014-09-25 10:24       ` James Hogan
2014-09-25 10:24         ` James Hogan
2014-09-24  9:45 ` [PATCH 05/11] MIPS: clear MSACSR cause bits when handling MSA FP exception Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24 11:10   ` Sergei Shtylyov
2014-09-25  9:20     ` [PATCH v2 " Paul Burton
2014-09-25  9:20       ` Paul Burton
2014-09-24  9:45 ` [PATCH 06/11] MIPS: fix mfc1 & mfhc1 emulation for mips64 systems Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24  9:45 ` [PATCH 07/11] MIPS: ensure FCSR cause bits are clear after invoking FPU emulator Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24  9:45 ` [PATCH 08/11] MIPS: prevent FP context set via ptrace being discarded Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24  9:45 ` [PATCH 09/11] MIPS: disable FPU if the mode is unsupported Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24  9:45 ` [PATCH 10/11] Revert "MIPS: Don't assume 64-bit FP registers for context switch" Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24  9:45 ` [PATCH 11/11] MIPS: MSA: Fix big-endian FPR_IDX implementation Paul Burton
2014-09-24  9:45   ` Paul Burton
2014-09-24 13:00 ` James Hogan [this message]
2014-09-24 13:00   ` [PATCH 00/11] FP/MSA fixes James Hogan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5422C07E.6080300@imgtec.com \
    --to=james.hogan@imgtec.com \
    --cc=linux-mips@linux-mips.org \
    --cc=paul.burton@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox