From: Ralf Baechle <ralf@linux-mips.org>
To: Markos Chandras <markos.chandras@imgtec.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: math-emu: cp1emu: Fix closing bracket for the d_fmt case
Date: Fri, 17 Jul 2015 10:04:05 +0200 [thread overview]
Message-ID: <20150717080405.GC9084@linux-mips.org> (raw)
In-Reply-To: <1437052005-14520-1-git-send-email-markos.chandras@imgtec.com>
On Thu, Jul 16, 2015 at 02:06:45PM +0100, Markos Chandras wrote:
> The double format (d_fmt) case uses an opening bracket which then
> closes at the end of the word format (w_fmt). This can be rather confusing
> so add the closing bracket at the end of the d_fmt case and use another one
> for the w_fmt one.
Heh. There used to be a construct like
switch (foo)
case val1:
if (bla) {
...
case val2:
} else {
case val3:
}
}
in the kernel and even though entirely correct I received several bug
reports for it. One reportes even suggested a bug report against GCC!
So queued for peace of mind in 4.3. Thanks!
Ralf
prev parent reply other threads:[~2015-07-17 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 13:06 [PATCH] MIPS: math-emu: cp1emu: Fix closing bracket for the d_fmt case Markos Chandras
2015-07-16 13:06 ` Markos Chandras
2015-07-17 8:04 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150717080405.GC9084@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=markos.chandras@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox