[PATCH] MIPS: math-emu: cp1emu: Fix closing bracket for the d_fmt case

[PATCH] MIPS: math-emu: cp1emu: Fix closing bracket for the d_fmt case

[Markos Chandras]

The double format (d_fmt) case uses an opening bracket which then
closes at the end of the word format (w_fmt). This can be rather confusing
so add the closing bracket at the end of the d_fmt case and use another one
for the w_fmt one.

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
 arch/mips/math-emu/cp1emu.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/mips/math-emu/cp1emu.c b/arch/mips/math-emu/cp1emu.c
index 712f17a2ecf2..cd858953a783 100644
--- a/arch/mips/math-emu/cp1emu.c
+++ b/arch/mips/math-emu/cp1emu.c
@@ -2021,8 +2021,11 @@ dcopuop:
 			break;
 		}
 		break;
+	}
+
+	case w_fmt: {
+		union ieee754dp fs;
 
-	case w_fmt:
 		switch (MIPSInst_FUNC(ir)) {
 		case fcvts_op:
 			/* convert word to single precision real */
-- 
2.4.5

[PATCH] MIPS: math-emu: cp1emu: Fix closing bracket for the d_fmt case

[Markos Chandras]

The double format (d_fmt) case uses an opening bracket which then
closes at the end of the word format (w_fmt). This can be rather confusing
so add the closing bracket at the end of the d_fmt case and use another one
for the w_fmt one.

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
 arch/mips/math-emu/cp1emu.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/arch/mips/math-emu/cp1emu.c b/arch/mips/math-emu/cp1emu.c
index 712f17a2ecf2..cd858953a783 100644
--- a/arch/mips/math-emu/cp1emu.c
+++ b/arch/mips/math-emu/cp1emu.c
@@ -2021,8 +2021,11 @@ dcopuop:
 			break;
 		}
 		break;
+	}
+
+	case w_fmt: {
+		union ieee754dp fs;
 
-	case w_fmt:
 		switch (MIPSInst_FUNC(ir)) {
 		case fcvts_op:
 			/* convert word to single precision real */
-- 
2.4.5

Re: [PATCH] MIPS: math-emu: cp1emu: Fix closing bracket for the d_fmt case

[Ralf Baechle]

On Thu, Jul 16, 2015 at 02:06:45PM +0100, Markos Chandras wrote:

> The double format (d_fmt) case uses an opening bracket which then
> closes at the end of the word format (w_fmt). This can be rather confusing
> so add the closing bracket at the end of the d_fmt case and use another one
> for the w_fmt one.

Heh.  There used to be a construct like

  switch (foo)
  case val1:
	if (bla) {
		...
  case val2:
	} else {
  case val3:
	}
  }

in the kernel and even though entirely correct I received several bug
reports for it.  One reportes even suggested a bug report against GCC!

So queued for peace of mind in 4.3.  Thanks!

  Ralf