* [PATCH] MIPS: dts: tl_wr1043nd_v1: fix "aliases" node name
@ 2016-01-14 8:20 Antony Pavlov
2016-01-14 14:45 ` Alban
2016-01-15 18:48 ` David Daney
0 siblings, 2 replies; 6+ messages in thread
From: Antony Pavlov @ 2016-01-14 8:20 UTC (permalink / raw)
To: linux-mips; +Cc: Antony Pavlov, Alban Bedel, devicetree
The correct name for aliases node is "aliases" not "alias".
An overview of the "aliases" node usage can be found
on the device tree usage page at devicetree.org [1].
Also please see chapter 3.3 ("Aliases node") of the ePAPR 1.1 [2].
[1] http://devicetree.org/Device_Tree_Usage#aliases_Node
[2] https://www.power.org/documentation/epapr-version-1-1/
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Cc: Alban Bedel <albeu@free.fr>
Cc: linux-mips@linux-mips.org
Cc: devicetree@vger.kernel.org
---
arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
index 003015a..4b6d38c 100644
--- a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
+++ b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
@@ -9,7 +9,7 @@
compatible = "tplink,tl-wr1043nd-v1", "qca,ar9132";
model = "TP-Link TL-WR1043ND Version 1";
- alias {
+ aliases {
serial0 = "/ahb/apb/uart@18020000";
};
--
2.6.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] MIPS: dts: tl_wr1043nd_v1: fix "aliases" node name
2016-01-14 8:20 [PATCH] MIPS: dts: tl_wr1043nd_v1: fix "aliases" node name Antony Pavlov
@ 2016-01-14 14:45 ` Alban
2016-01-15 18:48 ` David Daney
1 sibling, 0 replies; 6+ messages in thread
From: Alban @ 2016-01-14 14:45 UTC (permalink / raw)
To: Antony Pavlov; +Cc: Alban, linux-mips, devicetree
On Thu, 14 Jan 2016 11:20:57 +0300
Antony Pavlov <antonynpavlov@gmail.com> wrote:
> The correct name for aliases node is "aliases" not "alias".
>
> An overview of the "aliases" node usage can be found
> on the device tree usage page at devicetree.org [1].
>
> Also please see chapter 3.3 ("Aliases node") of the ePAPR 1.1 [2].
>
> [1] http://devicetree.org/Device_Tree_Usage#aliases_Node
> [2] https://www.power.org/documentation/epapr-version-1-1/
Acked-by: Alban Bedel <albeu@free.fr>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> Cc: Alban Bedel <albeu@free.fr>
> Cc: linux-mips@linux-mips.org
> Cc: devicetree@vger.kernel.org
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] MIPS: dts: tl_wr1043nd_v1: fix "aliases" node name
2016-01-14 8:20 [PATCH] MIPS: dts: tl_wr1043nd_v1: fix "aliases" node name Antony Pavlov
2016-01-14 14:45 ` Alban
@ 2016-01-15 18:48 ` David Daney
2016-01-16 5:02 ` Antony Pavlov
1 sibling, 1 reply; 6+ messages in thread
From: David Daney @ 2016-01-15 18:48 UTC (permalink / raw)
To: Antony Pavlov; +Cc: linux-mips, Alban Bedel, devicetree
On 01/14/2016 12:20 AM, Antony Pavlov wrote:
> The correct name for aliases node is "aliases" not "alias".
>
> An overview of the "aliases" node usage can be found
> on the device tree usage page at devicetree.org [1].
>
> Also please see chapter 3.3 ("Aliases node") of the ePAPR 1.1 [2].
>
> [1] http://devicetree.org/Device_Tree_Usage#aliases_Node
> [2] https://www.power.org/documentation/epapr-version-1-1/
>
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> Cc: Alban Bedel <albeu@free.fr>
> Cc: linux-mips@linux-mips.org
> Cc: devicetree@vger.kernel.org
> ---
> arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> index 003015a..4b6d38c 100644
> --- a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> +++ b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> @@ -9,7 +9,7 @@
> compatible = "tplink,tl-wr1043nd-v1", "qca,ar9132";
> model = "TP-Link TL-WR1043ND Version 1";
>
> - alias {
> + aliases {
> serial0 = "/ahb/apb/uart@18020000";
> };
What uses this alias? If the answer is nothing (likely, as it was
broken and nobody seems to have noticed), just remove the whole thing.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] MIPS: dts: tl_wr1043nd_v1: fix "aliases" node name
2016-01-15 18:48 ` David Daney
@ 2016-01-16 5:02 ` Antony Pavlov
2016-01-19 23:43 ` Alban
0 siblings, 1 reply; 6+ messages in thread
From: Antony Pavlov @ 2016-01-16 5:02 UTC (permalink / raw)
To: David Daney; +Cc: linux-mips, Alban Bedel, devicetree
On Fri, 15 Jan 2016 10:48:21 -0800
David Daney <ddaney.cavm@gmail.com> wrote:
> On 01/14/2016 12:20 AM, Antony Pavlov wrote:
> > The correct name for aliases node is "aliases" not "alias".
> >
> > An overview of the "aliases" node usage can be found
> > on the device tree usage page at devicetree.org [1].
> >
> > Also please see chapter 3.3 ("Aliases node") of the ePAPR 1.1 [2].
> >
> > [1] http://devicetree.org/Device_Tree_Usage#aliases_Node
> > [2] https://www.power.org/documentation/epapr-version-1-1/
> >
> > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > Cc: Alban Bedel <albeu@free.fr>
> > Cc: linux-mips@linux-mips.org
> > Cc: devicetree@vger.kernel.org
> > ---
> > arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> > index 003015a..4b6d38c 100644
> > --- a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> > +++ b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> > @@ -9,7 +9,7 @@
> > compatible = "tplink,tl-wr1043nd-v1", "qca,ar9132";
> > model = "TP-Link TL-WR1043ND Version 1";
> >
> > - alias {
> > + aliases {
> > serial0 = "/ahb/apb/uart@18020000";
> > };
>
> What uses this alias? If the answer is nothing (likely, as it was
> broken and nobody seems to have noticed), just remove the whole thing.
I have used ar9132_tl_wr1043nd_v1.dts as a template for AR9331-based board dts-file.
AR9331 uses it's own very special UART implementation (the ar933x_uart.c driver is used).
ar933x_uart.c relies on alias and does not work if alias is not set.
I have not yet runned linux on TL-WR1034ND, but I suppose that uart alias is not
actually used for TL-WR1034ND and this aliases node can be safely removed.
Alban, have you any comments?
--
Best regards,
Antony Pavlov
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] MIPS: dts: tl_wr1043nd_v1: fix "aliases" node name
2016-01-16 5:02 ` Antony Pavlov
@ 2016-01-19 23:43 ` Alban
2016-01-20 15:22 ` Antony Pavlov
0 siblings, 1 reply; 6+ messages in thread
From: Alban @ 2016-01-19 23:43 UTC (permalink / raw)
To: Antony Pavlov; +Cc: Aban Bedel, David Daney, linux-mips, devicetree
On Sat, 16 Jan 2016 08:02:05 +0300
Antony Pavlov <antonynpavlov@gmail.com> wrote:
> On Fri, 15 Jan 2016 10:48:21 -0800
> David Daney <ddaney.cavm@gmail.com> wrote:
>
> > On 01/14/2016 12:20 AM, Antony Pavlov wrote:
> > > The correct name for aliases node is "aliases" not "alias".
> > >
> > > An overview of the "aliases" node usage can be found
> > > on the device tree usage page at devicetree.org [1].
> > >
> > > Also please see chapter 3.3 ("Aliases node") of the ePAPR 1.1 [2].
> > >
> > > [1] http://devicetree.org/Device_Tree_Usage#aliases_Node
> > > [2] https://www.power.org/documentation/epapr-version-1-1/
> > >
> > > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > > Cc: Alban Bedel <albeu@free.fr>
> > > Cc: linux-mips@linux-mips.org
> > > Cc: devicetree@vger.kernel.org
> > > ---
> > > arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> > > b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts index
> > > 003015a..4b6d38c 100644 ---
> > > a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts +++
> > > b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts @@ -9,7 +9,7 @@
> > > compatible = "tplink,tl-wr1043nd-v1", "qca,ar9132";
> > > model = "TP-Link TL-WR1043ND Version 1";
> > >
> > > - alias {
> > > + aliases {
> > > serial0 = "/ahb/apb/uart@18020000";
> > > };
> >
> > What uses this alias? If the answer is nothing (likely, as it was
> > broken and nobody seems to have noticed), just remove the whole
> > thing.
>
> I have used ar9132_tl_wr1043nd_v1.dts as a template for AR9331-based
> board dts-file. AR9331 uses it's own very special UART implementation
> (the ar933x_uart.c driver is used). ar933x_uart.c relies on alias and
> does not work if alias is not set. I have not yet runned linux on
> TL-WR1034ND, but I suppose that uart alias is not actually used for
> TL-WR1034ND and this aliases node can be safely removed.
>
> Alban, have you any comments?
David is right, we should just remove it.
Alban
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] MIPS: dts: tl_wr1043nd_v1: fix "aliases" node name
2016-01-19 23:43 ` Alban
@ 2016-01-20 15:22 ` Antony Pavlov
0 siblings, 0 replies; 6+ messages in thread
From: Antony Pavlov @ 2016-01-20 15:22 UTC (permalink / raw)
To: Alban; +Cc: David Daney, linux-mips, devicetree
On Wed, 20 Jan 2016 00:43:36 +0100
Alban <albeu@free.fr> wrote:
> On Sat, 16 Jan 2016 08:02:05 +0300
> Antony Pavlov <antonynpavlov@gmail.com> wrote:
>
> > On Fri, 15 Jan 2016 10:48:21 -0800
> > David Daney <ddaney.cavm@gmail.com> wrote:
> >
> > > On 01/14/2016 12:20 AM, Antony Pavlov wrote:
> > > > The correct name for aliases node is "aliases" not "alias".
> > > >
> > > > An overview of the "aliases" node usage can be found
> > > > on the device tree usage page at devicetree.org [1].
> > > >
> > > > Also please see chapter 3.3 ("Aliases node") of the ePAPR 1.1 [2].
> > > >
> > > > [1] http://devicetree.org/Device_Tree_Usage#aliases_Node
> > > > [2] https://www.power.org/documentation/epapr-version-1-1/
> > > >
> > > > Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> > > > Cc: Alban Bedel <albeu@free.fr>
> > > > Cc: linux-mips@linux-mips.org
> > > > Cc: devicetree@vger.kernel.org
> > > > ---
> > > > arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> > > > b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts index
> > > > 003015a..4b6d38c 100644 ---
> > > > a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts +++
> > > > b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts @@ -9,7 +9,7 @@
> > > > compatible = "tplink,tl-wr1043nd-v1", "qca,ar9132";
> > > > model = "TP-Link TL-WR1043ND Version 1";
> > > >
> > > > - alias {
> > > > + aliases {
> > > > serial0 = "/ahb/apb/uart@18020000";
> > > > };
> > >
> > > What uses this alias? If the answer is nothing (likely, as it was
> > > broken and nobody seems to have noticed), just remove the whole
> > > thing.
> >
> > I have used ar9132_tl_wr1043nd_v1.dts as a template for AR9331-based
> > board dts-file. AR9331 uses it's own very special UART implementation
> > (the ar933x_uart.c driver is used). ar933x_uart.c relies on alias and
> > does not work if alias is not set. I have not yet runned linux on
> > TL-WR1034ND, but I suppose that uart alias is not actually used for
> > TL-WR1034ND and this aliases node can be safely removed.
> >
> > Alban, have you any comments?
>
> David is right, we should just remove it.
Ok.
Several days ago I have got one TP-Link WR1043ND v1.8, so I can prepare
the patch, check it on my real hardware and then send it to the maillist.
--
Best regards,
Antony Pavlov
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-20 14:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-14 8:20 [PATCH] MIPS: dts: tl_wr1043nd_v1: fix "aliases" node name Antony Pavlov
2016-01-14 14:45 ` Alban
2016-01-15 18:48 ` David Daney
2016-01-16 5:02 ` Antony Pavlov
2016-01-19 23:43 ` Alban
2016-01-20 15:22 ` Antony Pavlov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox