* [PATCH 1/3] MIPS: dts: qca: ar9132_tl_wr1043nd_v1.dts: drop unused alias node
[not found] <1453370345-16688-1-git-send-email-antonynpavlov@gmail.com>
@ 2016-01-21 9:59 ` Antony Pavlov
2016-01-21 10:31 ` Alban
2016-01-21 9:59 ` [PATCH 2/3] MIPS: dts: qca: ar9132: drop unused extosc mentions Antony Pavlov
2016-01-21 9:59 ` [PATCH 3/3] MIPS: dts: qca: ar9132: use short references for uart and spi nodes Antony Pavlov
2 siblings, 1 reply; 5+ messages in thread
From: Antony Pavlov @ 2016-01-21 9:59 UTC (permalink / raw)
To: devicetree; +Cc: Antony Pavlov, Alban Bedel, linux-mips
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Cc: Alban Bedel <albeu@free.fr>
Cc: linux-mips@linux-mips.org
Cc: devicetree@vger.kernel.org
---
arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts | 4 ----
1 file changed, 4 deletions(-)
diff --git a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
index 003015a..a6108f8 100644
--- a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
+++ b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
@@ -9,10 +9,6 @@
compatible = "tplink,tl-wr1043nd-v1", "qca,ar9132";
model = "TP-Link TL-WR1043ND Version 1";
- alias {
- serial0 = "/ahb/apb/uart@18020000";
- };
-
memory@0 {
device_type = "memory";
reg = <0x0 0x2000000>;
--
2.6.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/3] MIPS: dts: qca: ar9132_tl_wr1043nd_v1.dts: drop unused alias node
2016-01-21 9:59 ` [PATCH 1/3] MIPS: dts: qca: ar9132_tl_wr1043nd_v1.dts: drop unused alias node Antony Pavlov
@ 2016-01-21 10:31 ` Alban
0 siblings, 0 replies; 5+ messages in thread
From: Alban @ 2016-01-21 10:31 UTC (permalink / raw)
To: Antony Pavlov; +Cc: Aban Bedel, devicetree, linux-mips
On Thu, 21 Jan 2016 12:59:03 +0300
Antony Pavlov <antonynpavlov@gmail.com> wrote:
This will need at least a small log that explain that why it is useless.
This board only have this one serial, so replacing the default of 0
with 0 does nothing usefull.
Alban
> Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
> Cc: Alban Bedel <albeu@free.fr>
> Cc: linux-mips@linux-mips.org
> Cc: devicetree@vger.kernel.org
> ---
> arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> index 003015a..a6108f8 100644
> --- a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> +++ b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
> @@ -9,10 +9,6 @@
> compatible = "tplink,tl-wr1043nd-v1", "qca,ar9132";
> model = "TP-Link TL-WR1043ND Version 1";
>
> - alias {
> - serial0 = "/ahb/apb/uart@18020000";
> - };
> -
> memory@0 {
> device_type = "memory";
> reg = <0x0 0x2000000>;
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 2/3] MIPS: dts: qca: ar9132: drop unused extosc mentions
[not found] <1453370345-16688-1-git-send-email-antonynpavlov@gmail.com>
2016-01-21 9:59 ` [PATCH 1/3] MIPS: dts: qca: ar9132_tl_wr1043nd_v1.dts: drop unused alias node Antony Pavlov
@ 2016-01-21 9:59 ` Antony Pavlov
2016-01-21 10:52 ` Alban
2016-01-21 9:59 ` [PATCH 3/3] MIPS: dts: qca: ar9132: use short references for uart and spi nodes Antony Pavlov
2 siblings, 1 reply; 5+ messages in thread
From: Antony Pavlov @ 2016-01-21 9:59 UTC (permalink / raw)
To: devicetree; +Cc: Antony Pavlov, Alban Bedel, linux-mips
At the moment ar913x_clocks_init() does not use extosc node at all,
the reference clock rate is hardcoded inside arch/mips/ath79/clock.c
#define AR913X_BASE_FREQ 5000000
...
static void __init ar913x_clocks_init(void)
{
ref_rate = AR913X_BASE_FREQ;
...
ath79_add_sys_clkdev("ref", ref_rate);
Also please see the commits 'MIPS: ath79: Fix the ar913x reference clock rate'
and 'MIPS: ath79: Fix the ar724x clock calculation' in Alban Bedel's
github ath79 branch https://github.com/AlbanBedel/linux/tree/ath79
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Cc: Alban Bedel <albeu@free.fr>
Cc: linux-mips@linux-mips.org
Cc: devicetree@vger.kernel.org
---
arch/mips/boot/dts/qca/ar9132.dtsi | 3 ---
arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts | 10 ----------
2 files changed, 13 deletions(-)
diff --git a/arch/mips/boot/dts/qca/ar9132.dtsi b/arch/mips/boot/dts/qca/ar9132.dtsi
index 13d0439..84787e30 100644
--- a/arch/mips/boot/dts/qca/ar9132.dtsi
+++ b/arch/mips/boot/dts/qca/ar9132.dtsi
@@ -87,9 +87,6 @@
"qca,ar9130-pll";
reg = <0x18050000 0x20>;
- clock-names = "ref";
- /* The board must provides the ref clock */
-
#clock-cells = <1>;
clock-output-names = "cpu", "ddr", "ahb";
};
diff --git a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
index a6108f8..10905f6 100644
--- a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
+++ b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
@@ -14,21 +14,11 @@
reg = <0x0 0x2000000>;
};
- extosc: oscillator {
- compatible = "fixed-clock";
- #clock-cells = <0>;
- clock-frequency = <40000000>;
- };
-
ahb {
apb {
uart@18020000 {
status = "okay";
};
-
- pll-controller@18050000 {
- clocks = <&extosc>;
- };
};
spi@1f000000 {
--
2.6.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 2/3] MIPS: dts: qca: ar9132: drop unused extosc mentions
2016-01-21 9:59 ` [PATCH 2/3] MIPS: dts: qca: ar9132: drop unused extosc mentions Antony Pavlov
@ 2016-01-21 10:52 ` Alban
0 siblings, 0 replies; 5+ messages in thread
From: Alban @ 2016-01-21 10:52 UTC (permalink / raw)
To: Antony Pavlov; +Cc: Aban Bedel, devicetree, linux-mips
On Thu, 21 Jan 2016 12:59:04 +0300
Antony Pavlov <antonynpavlov@gmail.com> wrote:
> At the moment ar913x_clocks_init() does not use extosc node at all,
> the reference clock rate is hardcoded inside arch/mips/ath79/clock.c
>
> #define AR913X_BASE_FREQ 5000000
>
> ...
>
> static void __init ar913x_clocks_init(void)
> {
> ref_rate = AR913X_BASE_FREQ;
>
> ...
>
> ath79_add_sys_clkdev("ref", ref_rate);
>
> Also please see the commits 'MIPS: ath79: Fix the ar913x reference clock rate'
> and 'MIPS: ath79: Fix the ar724x clock calculation' in Alban Bedel's
> github ath79 branch https://github.com/AlbanBedel/linux/tree/ath79
Yes, the reference clock definition is not yet used by the code, but
the binding define it as required. This is because a proper
implementation would need the reference clock rate.
It would be better to fix the code to get rid of the hard coded rates
when using DT. I haven't done so yet because I wanted to first get DT
support without too many changes, but that's on the TODO list along with
moving to drivers/clk.
Alban
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/3] MIPS: dts: qca: ar9132: use short references for uart and spi nodes
[not found] <1453370345-16688-1-git-send-email-antonynpavlov@gmail.com>
2016-01-21 9:59 ` [PATCH 1/3] MIPS: dts: qca: ar9132_tl_wr1043nd_v1.dts: drop unused alias node Antony Pavlov
2016-01-21 9:59 ` [PATCH 2/3] MIPS: dts: qca: ar9132: drop unused extosc mentions Antony Pavlov
@ 2016-01-21 9:59 ` Antony Pavlov
2 siblings, 0 replies; 5+ messages in thread
From: Antony Pavlov @ 2016-01-21 9:59 UTC (permalink / raw)
To: devicetree; +Cc: Antony Pavlov, Alban Bedel, linux-mips
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
Cc: Alban Bedel <albeu@free.fr>
Cc: linux-mips@linux-mips.org
Cc: devicetree@vger.kernel.org
---
arch/mips/boot/dts/qca/ar9132.dtsi | 4 +-
arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts | 70 +++++++++++-------------
2 files changed, 35 insertions(+), 39 deletions(-)
diff --git a/arch/mips/boot/dts/qca/ar9132.dtsi b/arch/mips/boot/dts/qca/ar9132.dtsi
index 84787e30..f197815 100644
--- a/arch/mips/boot/dts/qca/ar9132.dtsi
+++ b/arch/mips/boot/dts/qca/ar9132.dtsi
@@ -52,7 +52,7 @@
#qca,ddr-wb-channel-cells = <1>;
};
- uart@18020000 {
+ uart: uart@18020000 {
compatible = "ns8250";
reg = <0x18020000 0x20>;
interrupts = <3>;
@@ -122,7 +122,7 @@
};
};
- spi@1f000000 {
+ spi: spi@1f000000 {
compatible = "qca,ar9132-spi", "qca,ar7100-spi";
reg = <0x1f000000 0x10>;
diff --git a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
index 10905f6..533d6e8 100644
--- a/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
+++ b/arch/mips/boot/dts/qca/ar9132_tl_wr1043nd_v1.dts
@@ -14,43 +14,6 @@
reg = <0x0 0x2000000>;
};
- ahb {
- apb {
- uart@18020000 {
- status = "okay";
- };
- };
-
- spi@1f000000 {
- status = "okay";
- num-cs = <1>;
-
- flash@0 {
- #address-cells = <1>;
- #size-cells = <1>;
- compatible = "s25sl064a";
- reg = <0>;
- spi-max-frequency = <25000000>;
-
- partition@0 {
- label = "u-boot";
- reg = <0x000000 0x020000>;
- };
-
- partition@1 {
- label = "firmware";
- reg = <0x020000 0x7D0000>;
- };
-
- partition@2 {
- label = "art";
- reg = <0x7F0000 0x010000>;
- read-only;
- };
- };
- };
- };
-
gpio-keys {
compatible = "gpio-keys-polled";
#address-cells = <1>;
@@ -96,3 +59,36 @@
};
};
};
+
+&uart {
+ status = "okay";
+};
+
+&spi {
+ status = "okay";
+ num-cs = <1>;
+
+ flash@0 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "s25sl064a";
+ reg = <0>;
+ spi-max-frequency = <25000000>;
+
+ partition@0 {
+ label = "u-boot";
+ reg = <0x000000 0x020000>;
+ };
+
+ partition@1 {
+ label = "firmware";
+ reg = <0x020000 0x7D0000>;
+ };
+
+ partition@2 {
+ label = "art";
+ reg = <0x7F0000 0x010000>;
+ read-only;
+ };
+ };
+};
--
2.6.2
^ permalink raw reply related [flat|nested] 5+ messages in thread