From: James Hogan <james.hogan@imgtec.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: <linux-mips@linux-mips.org>, Paul Burton <paul.burton@imgtec.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH 1/4] MIPS: Use copy_s.fmt rather than copy_u.fmt
Date: Fri, 15 Apr 2016 11:15:36 +0100 [thread overview]
Message-ID: <20160415101536.GC7859@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <20160415095941.GI1524@linux-mips.org>
[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]
On Fri, Apr 15, 2016 at 11:59:41AM +0200, Ralf Baechle wrote:
> On Fri, Apr 15, 2016 at 10:07:23AM +0100, James Hogan wrote:
>
> > From: Paul Burton <paul.burton@imgtec.com>
> >
> > In revision 1.12 of the MSA specification, the copy_u.w instruction has
> > been removed for MIPS32 & the copy_u.d instruction has been removed for
> > MIPS64. Newer toolchains (eg. Codescape SDK essentials 2015.10) will
> > complain about this like so:
> >
> > arch/mips/kernel/r4k_fpu.S:290: Error: opcode not supported on this
> > processor: mips32r2 (mips32r2) `copy_u.w $1,$w26[3]'
> >
> > Since we always copy to the width of a GPR, simply use copy_s instead of
> > copy_u to fix this.
> >
> > Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> > Signed-off-by: James Hogan <james.hogan@imgtec.com>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > Cc: linux-mips@linux-mips.org
> > Cc: <stable@vger.kernel.org> # 4.1.x-
>
> Looking good but seems to apply only to 4.3+
>
> Ralf
Yes, sorry. Without bf82cb30c7e58b3a9742f0a45962ebdf51befac7 I figured
the changes in r4k_fpu.S can be easily skipped, but actually I should
have looked deeper as the macros aren't even used until that commit.
Could you change the stable tag to 4.3 please.
Thanks!
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org, Paul Burton <paul.burton@imgtec.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/4] MIPS: Use copy_s.fmt rather than copy_u.fmt
Date: Fri, 15 Apr 2016 11:15:36 +0100 [thread overview]
Message-ID: <20160415101536.GC7859@jhogan-linux.le.imgtec.org> (raw)
Message-ID: <20160415101536.DbwAhEzV3nMKKk_7NvPLAfiko3AIn6W5DrtbQfQKkZI@z> (raw)
In-Reply-To: <20160415095941.GI1524@linux-mips.org>
[-- Attachment #1: Type: text/plain, Size: 1284 bytes --]
On Fri, Apr 15, 2016 at 11:59:41AM +0200, Ralf Baechle wrote:
> On Fri, Apr 15, 2016 at 10:07:23AM +0100, James Hogan wrote:
>
> > From: Paul Burton <paul.burton@imgtec.com>
> >
> > In revision 1.12 of the MSA specification, the copy_u.w instruction has
> > been removed for MIPS32 & the copy_u.d instruction has been removed for
> > MIPS64. Newer toolchains (eg. Codescape SDK essentials 2015.10) will
> > complain about this like so:
> >
> > arch/mips/kernel/r4k_fpu.S:290: Error: opcode not supported on this
> > processor: mips32r2 (mips32r2) `copy_u.w $1,$w26[3]'
> >
> > Since we always copy to the width of a GPR, simply use copy_s instead of
> > copy_u to fix this.
> >
> > Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> > Signed-off-by: James Hogan <james.hogan@imgtec.com>
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > Cc: linux-mips@linux-mips.org
> > Cc: <stable@vger.kernel.org> # 4.1.x-
>
> Looking good but seems to apply only to 4.3+
>
> Ralf
Yes, sorry. Without bf82cb30c7e58b3a9742f0a45962ebdf51befac7 I figured
the changes in r4k_fpu.S can be easily skipped, but actually I should
have looked deeper as the macros aren't even used until that commit.
Could you change the stable tag to 4.3 please.
Thanks!
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-04-15 10:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-15 9:07 [PATCH 0/4] MIPS: MSA fixes James Hogan
2016-04-15 9:07 ` James Hogan
2016-04-15 9:07 ` [PATCH 1/4] MIPS: Use copy_s.fmt rather than copy_u.fmt James Hogan
2016-04-15 9:07 ` James Hogan
2016-04-15 9:59 ` Ralf Baechle
2016-04-15 10:15 ` James Hogan [this message]
2016-04-15 10:15 ` James Hogan
2016-04-15 10:28 ` Ralf Baechle
2016-04-15 9:07 ` [PATCH 2/4] MIPS: Fix MSA ld_*/st_* asm macros to use PTR_ADDU James Hogan
2016-04-15 9:07 ` James Hogan
2016-04-15 9:07 ` [PATCH 3/4] MIPS: Fix MSA assembly with big thread offsets James Hogan
2016-04-15 9:07 ` James Hogan
2016-04-15 9:07 ` [PATCH 4/4] MIPS: Fix MSA assembly warnings James Hogan
2016-04-15 9:07 ` James Hogan
2016-04-15 10:11 ` [PATCH 0/4] MIPS: MSA fixes Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415101536.GC7859@jhogan-linux.le.imgtec.org \
--to=james.hogan@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox