Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Jan Glauber <jan.glauber@caviumnetworks.com>
To: Paul Burton <paul.burton@imgtec.com>
Cc: <linux-i2c@vger.kernel.org>, <linux-mips@linux-mips.org>,
	David Daney <david.daney@cavium.com>,
	Peter Swain <pswain@cavium.com>, Wolfram Sang <wsa@the-dreams.de>,
	"Steven J. Hill" <Steven.Hill@cavium.com>
Subject: Re: [PATCH 2/2] i2c: octeon: Fix waiting for operation completion
Date: Fri, 11 Nov 2016 09:57:07 +0100	[thread overview]
Message-ID: <20161111085707.GC16907@hardcore> (raw)
In-Reply-To: <1595446.2T31j1Ekg5@np-p-burton>

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

> As you can see octeon_i2c_driver_init never returns. Are you able to test on 
> one of your MIPS-based systems?
> 
> Thanks,
>     Paul

Hi Paul,

we can reproduce the problem on our side, but I don't have direct access
to a MIPS system so I'm still just guessing what happens. If you want
you can try the attached patches.

I'm trying to get rid of the polling around the interrupt altogether.
It works fine on Thunderx, sometimes I run into an interrupt timeout 
after a lost-arbitration but recovery/retry is able to clean that up.

Please also revert 70121f7 as before. The last patch adds some debugging
output to see if we run into timeouts or recovery.

thanks,
Jan



WARNING: multiple messages have this Message-ID (diff)
From: Jan Glauber <jan.glauber@caviumnetworks.com>
To: Paul Burton <paul.burton@imgtec.com>
Cc: linux-i2c@vger.kernel.org, linux-mips@linux-mips.org,
	David Daney <david.daney@cavium.com>,
	Peter Swain <pswain@cavium.com>, Wolfram Sang <wsa@the-dreams.de>,
	"Steven J. Hill" <Steven.Hill@cavium.com>
Subject: Re: [PATCH 2/2] i2c: octeon: Fix waiting for operation completion
Date: Fri, 11 Nov 2016 09:57:07 +0100	[thread overview]
Message-ID: <20161111085707.GC16907@hardcore> (raw)
Message-ID: <20161111085707.q8P71DEEFNYsuTX_UVIqFQU-4kvFOFB1aTM3ZOcnlec@z> (raw)
In-Reply-To: <1595446.2T31j1Ekg5@np-p-burton>

[-- Attachment #1: Type: text/plain, Size: 675 bytes --]

> As you can see octeon_i2c_driver_init never returns. Are you able to test on 
> one of your MIPS-based systems?
> 
> Thanks,
>     Paul

Hi Paul,

we can reproduce the problem on our side, but I don't have direct access
to a MIPS system so I'm still just guessing what happens. If you want
you can try the attached patches.

I'm trying to get rid of the polling around the interrupt altogether.
It works fine on Thunderx, sometimes I run into an interrupt timeout 
after a lost-arbitration but recovery/retry is able to clean that up.

Please also revert 70121f7 as before. The last patch adds some debugging
output to see if we run into timeouts or recovery.

thanks,
Jan

[-- Attachment #2: 0001-i2c-octeon-thunderx-TWSI-software-reset-in-recovery.patch --]
[-- Type: text/x-diff, Size: 0 bytes --]



  parent reply	other threads:[~2016-11-11  8:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-07 20:09 [PATCH 1/2] i2c: octeon: Fix register access Paul Burton
2016-11-07 20:09 ` Paul Burton
2016-11-07 20:09 ` [PATCH 2/2] i2c: octeon: Fix waiting for operation completion Paul Burton
2016-11-07 20:09   ` Paul Burton
2016-11-08  9:20   ` Jan Glauber
2016-11-08  9:20     ` Jan Glauber
2016-11-09 13:41   ` Jan Glauber
2016-11-09 13:41     ` Jan Glauber
2016-11-09 14:07     ` Paul Burton
2016-11-09 14:07       ` Paul Burton
2016-11-09 14:38       ` Jan Glauber
2016-11-09 14:38         ` Jan Glauber
2016-11-11  8:57       ` Jan Glauber [this message]
2016-11-11  8:57         ` Jan Glauber
2016-11-11 20:51         ` Steven J. Hill
2016-11-11 20:51           ` Steven J. Hill
2016-11-11 22:11           ` David Daney
2016-11-11 22:11             ` David Daney
2016-11-08  7:13 ` [PATCH 1/2] i2c: octeon: Fix register access Jan Glauber
2016-11-08  7:13   ` Jan Glauber
2016-11-09 14:09   ` Paul Burton
2016-11-09 14:09     ` Paul Burton
2016-11-09 14:43     ` Jan Glauber
2016-11-09 14:43       ` Jan Glauber
2016-11-10 20:17   ` Wolfram Sang
2016-11-11  7:00     ` Jan Glauber
2016-11-11  7:00       ` Jan Glauber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161111085707.GC16907@hardcore \
    --to=jan.glauber@caviumnetworks.com \
    --cc=Steven.Hill@cavium.com \
    --cc=david.daney@cavium.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=paul.burton@imgtec.com \
    --cc=pswain@cavium.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox