From: Ralf Baechle <ralf@linux-mips.org>
To: "Steven J. Hill" <Steven.Hill@cavium.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH 1/5] MIPS: FW: Make fw_init_cmdline() to be __weak.
Date: Wed, 21 Dec 2016 18:10:16 +0100 [thread overview]
Message-ID: <20161221171015.GA13689@linux-mips.org> (raw)
In-Reply-To: <b14ef49d-f39c-4e13-2da8-ab94804395a2@cavium.com>
On Tue, Nov 22, 2016 at 01:43:54PM -0600, Steven J. Hill wrote:
> Some bootloaders pass the kernel parameters in different registers.
> Allow for platform-specific initialization of the command line.
>
> Signed-off-by: Steven J. Hill <Steven.Hill@cavium.com>
> ---
> arch/mips/include/asm/fw/fw.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/include/asm/fw/fw.h b/arch/mips/include/asm/fw/fw.h
> index d0ef8b4..0fcd63e 100644
> --- a/arch/mips/include/asm/fw/fw.h
> +++ b/arch/mips/include/asm/fw/fw.h
> @@ -21,7 +21,7 @@
> #define fw_argv(index) ((char *)(long)_fw_argv[(index)])
> #define fw_envp(index) ((char *)(long)_fw_envp[(index)])
>
> -extern void fw_init_cmdline(void);
> +extern void __weak fw_init_cmdline(void);
> extern char *fw_getcmdline(void);
> extern void fw_meminit(void);
> extern char *fw_getenv(char *name);
Nice try - expect it doesn't work.
The definition of the function needs to be marked __weak; marking the
declaration will only kindly express your wishes to GCC and it being
GCC will ignore them ;-)
Ralf
next prev parent reply other threads:[~2016-12-21 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 19:43 [PATCH 1/5] MIPS: FW: Make fw_init_cmdline() to be __weak Steven J. Hill
2016-11-22 19:43 ` Steven J. Hill
2016-12-21 17:10 ` Ralf Baechle [this message]
2016-12-21 18:08 ` David Daney
2016-12-21 18:08 ` David Daney
2016-12-21 18:09 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221171015.GA13689@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Steven.Hill@cavium.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox