From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney@caviumnetworks.com>
Cc: "Steven J. Hill" <Steven.Hill@cavium.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH 1/5] MIPS: FW: Make fw_init_cmdline() to be __weak.
Date: Wed, 21 Dec 2016 19:09:56 +0100 [thread overview]
Message-ID: <20161221180956.GA5561@linux-mips.org> (raw)
In-Reply-To: <892fff47-d83e-fbb5-92a5-248d6e3a3eea@caviumnetworks.com>
On Wed, Dec 21, 2016 at 10:08:11AM -0800, David Daney wrote:
> On 12/21/2016 09:10 AM, Ralf Baechle wrote:
> > On Tue, Nov 22, 2016 at 01:43:54PM -0600, Steven J. Hill wrote:
> >
> > > Some bootloaders pass the kernel parameters in different registers.
> > > Allow for platform-specific initialization of the command line.
> > >
> > > Signed-off-by: Steven J. Hill <Steven.Hill@cavium.com>
> > > ---
> > > arch/mips/include/asm/fw/fw.h | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/mips/include/asm/fw/fw.h b/arch/mips/include/asm/fw/fw.h
> > > index d0ef8b4..0fcd63e 100644
> > > --- a/arch/mips/include/asm/fw/fw.h
> > > +++ b/arch/mips/include/asm/fw/fw.h
> > > @@ -21,7 +21,7 @@
> > > #define fw_argv(index) ((char *)(long)_fw_argv[(index)])
> > > #define fw_envp(index) ((char *)(long)_fw_envp[(index)])
> > >
> > > -extern void fw_init_cmdline(void);
> > > +extern void __weak fw_init_cmdline(void);
> > > extern char *fw_getcmdline(void);
> > > extern void fw_meminit(void);
> > > extern char *fw_getenv(char *name);
> >
> > Nice try - expect it doesn't work.
>
> Ralf, Can you drop this unneeded patch, and still apply the other OCTEON
> KASLR patches in this set?
Already done and pushed a few minutes ago.
Ralf
prev parent reply other threads:[~2016-12-21 18:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-22 19:43 [PATCH 1/5] MIPS: FW: Make fw_init_cmdline() to be __weak Steven J. Hill
2016-11-22 19:43 ` Steven J. Hill
2016-12-21 17:10 ` Ralf Baechle
2016-12-21 18:08 ` David Daney
2016-12-21 18:08 ` David Daney
2016-12-21 18:09 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221180956.GA5561@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Steven.Hill@cavium.com \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox