From: James Hogan <james.hogan@imgtec.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: <linux-mips@linux-mips.org>, <ralf@linux-mips.org>,
<john@phrozen.org>, <hauke.mehrtens@lantiq.com>
Subject: Re: [PATCH] MIPS: Lantiq: Keep ethernet enabled during boot
Date: Mon, 13 Feb 2017 21:56:11 +0000 [thread overview]
Message-ID: <20170213215610.GL24226@jhogan-linux.le.imgtec.org> (raw)
In-Reply-To: <20170119132009.55709-1-nbd@nbd.name>
[-- Attachment #1: Type: text/plain, Size: 2877 bytes --]
On Thu, Jan 19, 2017 at 02:20:09PM +0100, Felix Fietkau wrote:
> Disabling ethernet during reboot (only to enable it again when the
> ethernet driver attaches) can put the chip into a faulty state where it
> corrupts the header of all incoming packets.
>
> This happens if packets arrive during the time window where the core is
> disabled, and it can be easily reproduced by rebooting while sending a
> flood ping to the broadcast address.
>
> Cc: john@phrozen.org
> Cc: hauke.mehrtens@lantiq.com
> Cc: stable@vger.kernel.org
> Fixes: 95135bfa7ead ("MIPS: Lantiq: Deactivate most of the devices by default")
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
Applied
Thanks
James
> ---
> arch/mips/lantiq/xway/sysctrl.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c
> index 236193b5210b..9a61671c00a7 100644
> --- a/arch/mips/lantiq/xway/sysctrl.c
> +++ b/arch/mips/lantiq/xway/sysctrl.c
> @@ -545,7 +545,7 @@ void __init ltq_soc_init(void)
> clkdev_add_pmu("1a800000.pcie", "msi", 1, 1, PMU1_PCIE2_MSI);
> clkdev_add_pmu("1a800000.pcie", "pdi", 1, 1, PMU1_PCIE2_PDI);
> clkdev_add_pmu("1a800000.pcie", "ctl", 1, 1, PMU1_PCIE2_CTL);
> - clkdev_add_pmu("1e108000.eth", NULL, 1, 0, PMU_SWITCH | PMU_PPE_DP);
> + clkdev_add_pmu("1e108000.eth", NULL, 0, 0, PMU_SWITCH | PMU_PPE_DP);
> clkdev_add_pmu("1da00000.usif", "NULL", 1, 0, PMU_USIF);
> clkdev_add_pmu("1e103100.deu", NULL, 1, 0, PMU_DEU);
> } else if (of_machine_is_compatible("lantiq,ar10")) {
> @@ -553,7 +553,7 @@ void __init ltq_soc_init(void)
> ltq_ar10_fpi_hz(), ltq_ar10_pp32_hz());
> clkdev_add_pmu("1e101000.usb", "ctl", 1, 0, PMU_USB0);
> clkdev_add_pmu("1e106000.usb", "ctl", 1, 0, PMU_USB1);
> - clkdev_add_pmu("1e108000.eth", NULL, 1, 0, PMU_SWITCH |
> + clkdev_add_pmu("1e108000.eth", NULL, 0, 0, PMU_SWITCH |
> PMU_PPE_DP | PMU_PPE_TC);
> clkdev_add_pmu("1da00000.usif", "NULL", 1, 0, PMU_USIF);
> clkdev_add_pmu("1f203000.rcu", "gphy", 1, 0, PMU_GPHY);
> @@ -575,11 +575,11 @@ void __init ltq_soc_init(void)
> clkdev_add_pmu(NULL, "ahb", 1, 0, PMU_AHBM | PMU_AHBS);
>
> clkdev_add_pmu("1da00000.usif", "NULL", 1, 0, PMU_USIF);
> - clkdev_add_pmu("1e108000.eth", NULL, 1, 0,
> + clkdev_add_pmu("1e108000.eth", NULL, 0, 0,
> PMU_SWITCH | PMU_PPE_DPLUS | PMU_PPE_DPLUM |
> PMU_PPE_EMA | PMU_PPE_TC | PMU_PPE_SLL01 |
> PMU_PPE_QSB | PMU_PPE_TOP);
> - clkdev_add_pmu("1f203000.rcu", "gphy", 1, 0, PMU_GPHY);
> + clkdev_add_pmu("1f203000.rcu", "gphy", 0, 0, PMU_GPHY);
> clkdev_add_pmu("1e103000.sdio", NULL, 1, 0, PMU_SDIO);
> clkdev_add_pmu("1e103100.deu", NULL, 1, 0, PMU_DEU);
> clkdev_add_pmu("1e116000.mei", "dfe", 1, 0, PMU_DFE);
> --
> 2.11.0
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: James Hogan <james.hogan@imgtec.com>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, john@phrozen.org,
hauke.mehrtens@lantiq.com
Subject: Re: [PATCH] MIPS: Lantiq: Keep ethernet enabled during boot
Date: Mon, 13 Feb 2017 21:56:11 +0000 [thread overview]
Message-ID: <20170213215610.GL24226@jhogan-linux.le.imgtec.org> (raw)
Message-ID: <20170213215611.oByDgrz6ciFWsEgtGSgZ3YvNUxs4UgVBmhLJQNiM7c4@z> (raw)
In-Reply-To: <20170119132009.55709-1-nbd@nbd.name>
[-- Attachment #1: Type: text/plain, Size: 2877 bytes --]
On Thu, Jan 19, 2017 at 02:20:09PM +0100, Felix Fietkau wrote:
> Disabling ethernet during reboot (only to enable it again when the
> ethernet driver attaches) can put the chip into a faulty state where it
> corrupts the header of all incoming packets.
>
> This happens if packets arrive during the time window where the core is
> disabled, and it can be easily reproduced by rebooting while sending a
> flood ping to the broadcast address.
>
> Cc: john@phrozen.org
> Cc: hauke.mehrtens@lantiq.com
> Cc: stable@vger.kernel.org
> Fixes: 95135bfa7ead ("MIPS: Lantiq: Deactivate most of the devices by default")
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
Applied
Thanks
James
> ---
> arch/mips/lantiq/xway/sysctrl.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/mips/lantiq/xway/sysctrl.c b/arch/mips/lantiq/xway/sysctrl.c
> index 236193b5210b..9a61671c00a7 100644
> --- a/arch/mips/lantiq/xway/sysctrl.c
> +++ b/arch/mips/lantiq/xway/sysctrl.c
> @@ -545,7 +545,7 @@ void __init ltq_soc_init(void)
> clkdev_add_pmu("1a800000.pcie", "msi", 1, 1, PMU1_PCIE2_MSI);
> clkdev_add_pmu("1a800000.pcie", "pdi", 1, 1, PMU1_PCIE2_PDI);
> clkdev_add_pmu("1a800000.pcie", "ctl", 1, 1, PMU1_PCIE2_CTL);
> - clkdev_add_pmu("1e108000.eth", NULL, 1, 0, PMU_SWITCH | PMU_PPE_DP);
> + clkdev_add_pmu("1e108000.eth", NULL, 0, 0, PMU_SWITCH | PMU_PPE_DP);
> clkdev_add_pmu("1da00000.usif", "NULL", 1, 0, PMU_USIF);
> clkdev_add_pmu("1e103100.deu", NULL, 1, 0, PMU_DEU);
> } else if (of_machine_is_compatible("lantiq,ar10")) {
> @@ -553,7 +553,7 @@ void __init ltq_soc_init(void)
> ltq_ar10_fpi_hz(), ltq_ar10_pp32_hz());
> clkdev_add_pmu("1e101000.usb", "ctl", 1, 0, PMU_USB0);
> clkdev_add_pmu("1e106000.usb", "ctl", 1, 0, PMU_USB1);
> - clkdev_add_pmu("1e108000.eth", NULL, 1, 0, PMU_SWITCH |
> + clkdev_add_pmu("1e108000.eth", NULL, 0, 0, PMU_SWITCH |
> PMU_PPE_DP | PMU_PPE_TC);
> clkdev_add_pmu("1da00000.usif", "NULL", 1, 0, PMU_USIF);
> clkdev_add_pmu("1f203000.rcu", "gphy", 1, 0, PMU_GPHY);
> @@ -575,11 +575,11 @@ void __init ltq_soc_init(void)
> clkdev_add_pmu(NULL, "ahb", 1, 0, PMU_AHBM | PMU_AHBS);
>
> clkdev_add_pmu("1da00000.usif", "NULL", 1, 0, PMU_USIF);
> - clkdev_add_pmu("1e108000.eth", NULL, 1, 0,
> + clkdev_add_pmu("1e108000.eth", NULL, 0, 0,
> PMU_SWITCH | PMU_PPE_DPLUS | PMU_PPE_DPLUM |
> PMU_PPE_EMA | PMU_PPE_TC | PMU_PPE_SLL01 |
> PMU_PPE_QSB | PMU_PPE_TOP);
> - clkdev_add_pmu("1f203000.rcu", "gphy", 1, 0, PMU_GPHY);
> + clkdev_add_pmu("1f203000.rcu", "gphy", 0, 0, PMU_GPHY);
> clkdev_add_pmu("1e103000.sdio", NULL, 1, 0, PMU_SDIO);
> clkdev_add_pmu("1e103100.deu", NULL, 1, 0, PMU_DEU);
> clkdev_add_pmu("1e116000.mei", "dfe", 1, 0, PMU_DFE);
> --
> 2.11.0
>
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2017-02-13 21:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 13:20 [PATCH] MIPS: Lantiq: Keep ethernet enabled during boot Felix Fietkau
2017-02-12 8:03 ` John Crispin
2017-02-13 21:56 ` James Hogan [this message]
2017-02-13 21:56 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213215610.GL24226@jhogan-linux.le.imgtec.org \
--to=james.hogan@imgtec.com \
--cc=hauke.mehrtens@lantiq.com \
--cc=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
--cc=nbd@nbd.name \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox