BC47xx build errors

BC47xx build errors

[Ralf Baechle]

A less than smart build test system has flagged the following build error:

  CC      arch/mips/bcm47xx/irq.o
In file included from arch/mips/bcm47xx/irq.c:32:0:
./arch/mips/include/asm/mach-bcm47xx/bcm47xx.h:34:1: error: expected identifier
+before
+‘}’ token
 };

I don't have any .config or anything for this error.  While trying to
reproduce this error I tried to build bcm47xx_defconfig but with
CONFIG_BCM47XX_SSB and CONFIG_BCM47XX_BCMA disabled.  That resulted in
the following build error:

  CC	  arch/mips/bcm47xx/irq.o
In file included from arch/mips/bcm47xx/irq.c:32:0:
./arch/mips/include/asm/mach-bcm47xx/bcm47xx.h:34:1: error: empty enum is
+invalid
 };
 ^
scripts/Makefile.build:302: recipe for target 'arch/mips/bcm47xx/irq.o' failed
make[1]: *** [arch/mips/bcm47xx/irq.o] Error 1
Makefile:1663: recipe for target 'arch/mips/bcm47xx/irq.o' failed

  Ralf

Re: BC47xx build errors

[Florian Fainelli]

On 27/06/2017 16:16, Ralf Baechle wrote:
> A less than smart build test system has flagged the following build error:
> 
>   CC      arch/mips/bcm47xx/irq.o
> In file included from arch/mips/bcm47xx/irq.c:32:0:
> ./arch/mips/include/asm/mach-bcm47xx/bcm47xx.h:34:1: error: expected identifier
> +before
> +‘}’ token
>  };
> 
> I don't have any .config or anything for this error.  While trying to
> reproduce this error I tried to build bcm47xx_defconfig but with
> CONFIG_BCM47XX_SSB and CONFIG_BCM47XX_BCMA disabled.  That resulted in
> the following build error:

I am not sure if we should define an invalid bus type enum value just to
avoid creating an empty enum or simply making sure that neither
CONFIG_BCM47XX_SSB nor CONFIG_BCM47XX_BCMA can be disabled with
CONFIG_BCM47XX, as clearly this would not result in a functioning
kernel, Rafal, Hauke, thoughts?

> 
>   CC	  arch/mips/bcm47xx/irq.o
> In file included from arch/mips/bcm47xx/irq.c:32:0:
> ./arch/mips/include/asm/mach-bcm47xx/bcm47xx.h:34:1: error: empty enum is
> +invalid
>  };
>  ^
> scripts/Makefile.build:302: recipe for target 'arch/mips/bcm47xx/irq.o' failed
> make[1]: *** [arch/mips/bcm47xx/irq.o] Error 1
> Makefile:1663: recipe for target 'arch/mips/bcm47xx/irq.o' failed
> 
>   Ralf
> 

Re: BC47xx build errors

[Hauke Mehrtens]

On 06/28/2017 06:46 AM, Florian Fainelli wrote:
> On 27/06/2017 16:16, Ralf Baechle wrote:
>> A less than smart build test system has flagged the following build error:
>>
>>   CC      arch/mips/bcm47xx/irq.o
>> In file included from arch/mips/bcm47xx/irq.c:32:0:
>> ./arch/mips/include/asm/mach-bcm47xx/bcm47xx.h:34:1: error: expected identifier
>> +before
>> +‘}’ token
>>  };
>>
>> I don't have any .config or anything for this error.  While trying to
>> reproduce this error I tried to build bcm47xx_defconfig but with
>> CONFIG_BCM47XX_SSB and CONFIG_BCM47XX_BCMA disabled.  That resulted in
>> the following build error:
> 
> I am not sure if we should define an invalid bus type enum value just to
> avoid creating an empty enum or simply making sure that neither
> CONFIG_BCM47XX_SSB nor CONFIG_BCM47XX_BCMA can be disabled with
> CONFIG_BCM47XX, as clearly this would not result in a functioning
> kernel, Rafal, Hauke, thoughts?
> 

What about adding a BUILD_BUG() with a message when neither SSB or BCMA
support is selected?

The kernel will be unusable anyway and you also can not test compile
anything which you could not test compile with bcma or ssb selected.

Hauke