From: Paul Burton <paul.burton@imgtec.com>
To: <linux-mips@linux-mips.org>
Cc: Paul Burton <paul.burton@imgtec.com>, Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH] fixup: MIPS: CPS: Cluster support for topology functions
Date: Tue, 29 Aug 2017 13:08:03 -0700 [thread overview]
Message-ID: <20170829200803.856-1-paul.burton@imgtec.com> (raw)
In-Reply-To: <20170813024943.14989-19-paul.burton@imgtec.com>
From CM 3.5 onwards we might read information that has typically come
from the CM using registers which mirror that information in the CPC.
This requires that we include support for the CPC.
Ensure that CONFIG_MIPS_CPC is enabled along with CONFIG_MIPS_CM so that
we always include that support. Otherwise we fail to link due to the
missing mips_cpc_base symbol when the topology functions call CPC
register accessors.
Signed-off-by: Paul Burton <paul.burton@imgtec.com>
Fixes: 20fb90f7620d ("MIPS: CPS: Cluster support for topology functions")
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-mips@linux-mips.org
---
arch/mips/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 2d1651797651..5284dfc38e78 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2385,7 +2385,6 @@ config MIPS_CPS
bool "MIPS Coherent Processing System support"
depends on SYS_SUPPORTS_MIPS_CPS
select MIPS_CM
- select MIPS_CPC
select MIPS_CPS_PM if HOTPLUG_CPU
select SMP
select SYNC_R4K if (CEVT_R4K || CSRC_R4K)
@@ -2402,11 +2401,11 @@ config MIPS_CPS
config MIPS_CPS_PM
depends on MIPS_CPS
- select MIPS_CPC
bool
config MIPS_CM
bool
+ select MIPS_CPC
config MIPS_CPC
bool
--
2.14.1
WARNING: multiple messages have this Message-ID (diff)
From: Paul Burton <paul.burton@imgtec.com>
To: linux-mips@linux-mips.org
Cc: Paul Burton <paul.burton@imgtec.com>, Ralf Baechle <ralf@linux-mips.org>
Subject: [PATCH] fixup: MIPS: CPS: Cluster support for topology functions
Date: Tue, 29 Aug 2017 13:08:03 -0700 [thread overview]
Message-ID: <20170829200803.856-1-paul.burton@imgtec.com> (raw)
Message-ID: <20170829200803.pECoznjGgZ7y1c7j-1XyIXBLFy90XsfL5bEbi2uYdHU@z> (raw)
In-Reply-To: <20170813024943.14989-19-paul.burton@imgtec.com>
next prev parent reply other threads:[~2017-08-29 20:08 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-13 2:49 [PATCH 00/19] MIPS: Initial multi-cluster support Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 01/19] MIPS: CM: Rename mips_cm_base to mips_gcr_base Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 02/19] MIPS: CM: Specify register size when generating accessors Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 03/19] MIPS: CM: Use BIT/GENMASK for register fields, order & drop shifts Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-29 20:05 ` [PATCH] fixup: " Paul Burton
2017-08-29 20:05 ` Paul Burton
2017-08-13 2:49 ` [PATCH 04/19] MIPS: CPC: Use common CPS accessor generation macros Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 05/19] MIPS: CPC: Use BIT/GENMASK for register fields, order & drop shifts Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 06/19] MIPS: CPS: Introduce register modify (set/clear/change) accessors Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 07/19] MIPS: CPS: Use change_*, set_* & clear_* where appropriate Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 08/19] MIPS: CPS: Add CM/CPC 3.5 register definitions Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 09/19] MIPS: Add accessor & bit definitions for GlobalNumber Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 10/19] MIPS: CPS: Use GlobalNumber macros rather than magic numbers Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 11/19] MIPS: Abstract CPU core & VP(E) ID access through accessor functions Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 12/19] MIPS: Store core & VP IDs in GlobalNumber-style variable Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 13/19] MIPS: Unify checks for sibling CPUs Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-26 12:27 ` Ralf Baechle
2017-08-26 12:49 ` Rafael J. Wysocki
2017-08-29 7:42 ` Daniel Lezcano
2017-08-13 2:49 ` [PATCH 14/19] MIPS: Add CPU cluster number accessors Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 15/19] MIPS: CM: Add cluster & block args to mips_cm_lock_other() Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 16/19] MIPS: SMP: Allow boot_secondary SMP op to return errors Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-13 2:49 ` [PATCH 17/19] MIPS: CPS: Have asm/mips-cps.h include CM & CPC headers Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-29 20:07 ` [PATCH] fixup: " Paul Burton
2017-08-29 20:07 ` Paul Burton
2017-08-13 2:49 ` [PATCH 18/19] MIPS: CPS: Cluster support for topology functions Paul Burton
2017-08-13 2:49 ` Paul Burton
2017-08-29 20:08 ` Paul Burton [this message]
2017-08-29 20:08 ` [PATCH] fixup: " Paul Burton
2017-08-13 2:49 ` [PATCH 19/19] MIPS: CPS: Detect CPUs in secondary clusters Paul Burton
2017-08-13 2:49 ` Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829200803.856-1-paul.burton@imgtec.com \
--to=paul.burton@imgtec.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox