* [PATCH 07/11] MIPS: BCM63XX: kconfig: Remove blank help text
[not found] <20180131093434.20050-1-ulfalizer@gmail.com>
@ 2018-01-31 9:34 ` Ulf Magnusson
2018-01-31 9:34 ` [PATCH 08/11] MIPS: " Ulf Magnusson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Magnusson @ 2018-01-31 9:34 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, yamada.masahiro, mcgrof, rdunlap, dan.carpenter,
pebolle, Ulf Magnusson, Ralf Baechle, James Hogan,
Florian Fainelli, bcm-kernel-feedback-list, Kate Stewart,
Greg Kroah-Hartman, Thomas Gleixner, Philippe Ombredanne,
linux-mips, linux-arm-kernel
Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).
Best to remove them, IMO.
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
arch/mips/bcm63xx/boards/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/bcm63xx/boards/Kconfig b/arch/mips/bcm63xx/boards/Kconfig
index 6ff0a7481081..f60d96610ace 100644
--- a/arch/mips/bcm63xx/boards/Kconfig
+++ b/arch/mips/bcm63xx/boards/Kconfig
@@ -7,6 +7,5 @@ choice
config BOARD_BCM963XX
bool "Generic Broadcom 963xx boards"
select SSB
- help
endchoice
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 08/11] MIPS: kconfig: Remove blank help text
[not found] <20180131093434.20050-1-ulfalizer@gmail.com>
2018-01-31 9:34 ` [PATCH 07/11] MIPS: BCM63XX: kconfig: Remove blank help text Ulf Magnusson
@ 2018-01-31 9:34 ` Ulf Magnusson
2018-02-01 17:11 ` Masahiro Yamada
1 sibling, 1 reply; 3+ messages in thread
From: Ulf Magnusson @ 2018-01-31 9:34 UTC (permalink / raw)
To: linux-kbuild
Cc: linux-kernel, yamada.masahiro, mcgrof, rdunlap, dan.carpenter,
pebolle, Ulf Magnusson, Ralf Baechle, James Hogan, linux-mips
Blank help texts are probably either a typo, a Kconfig misunderstanding,
or some kind of half-committing to adding a help text (in which case a
TODO comment would be clearer, if the help text really can't be added
right away).
Best to remove them, IMO.
Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
---
arch/mips/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index ab98569994f0..57cd591e7b28 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2326,7 +2326,6 @@ config MIPS_VPE_LOADER_TOM
config MIPS_VPE_APSP_API
bool "Enable support for AP/SP API (RTLX)"
depends on MIPS_VPE_LOADER
- help
config MIPS_VPE_APSP_API_CMP
bool
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 08/11] MIPS: kconfig: Remove blank help text
2018-01-31 9:34 ` [PATCH 08/11] MIPS: " Ulf Magnusson
@ 2018-02-01 17:11 ` Masahiro Yamada
0 siblings, 0 replies; 3+ messages in thread
From: Masahiro Yamada @ 2018-02-01 17:11 UTC (permalink / raw)
To: Ulf Magnusson
Cc: Linux Kbuild mailing list, Linux Kernel Mailing List,
Luis R. Rodriguez, Randy Dunlap, Dan Carpenter, Paul Bolle,
Ralf Baechle, James Hogan, Linux-MIPS
2018-01-31 18:34 GMT+09:00 Ulf Magnusson <ulfalizer@gmail.com>:
> Blank help texts are probably either a typo, a Kconfig misunderstanding,
> or some kind of half-committing to adding a help text (in which case a
> TODO comment would be clearer, if the help text really can't be added
> right away).
>
> Best to remove them, IMO.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@gmail.com>
> ---
FYI.
I picked up this patch to kbuild
because I need this to suppress warning messages
introduced by 11/11.
I am planning to send a PR for this series next week.
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-01 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180131093434.20050-1-ulfalizer@gmail.com>
2018-01-31 9:34 ` [PATCH 07/11] MIPS: BCM63XX: kconfig: Remove blank help text Ulf Magnusson
2018-01-31 9:34 ` [PATCH 08/11] MIPS: " Ulf Magnusson
2018-02-01 17:11 ` Masahiro Yamada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox