Re: [PATCH] MIPS: BMIPS: Fix section mismatch warning

[James Hogan <jhogan@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]

On Tue, Feb 06, 2018 at 12:13:21PM +0900, Jaedon Shin wrote:
> Remove the __init annotation from bmips_cpu_setup() to avoid the
> following warning.
> 
> WARNING: vmlinux.o(.text+0x35c950): Section mismatch in reference from the function brcmstb_pm_s3() to the function .init.text:bmips_cpu_setup()
> The function brcmstb_pm_s3() references
> the function __init bmips_cpu_setup().
> This is often because brcmstb_pm_s3 lacks a __init
> annotation or the annotation of bmips_cpu_setup is wrong.
> 
> Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>

Reviewed-by: James Hogan <jhogan@kernel.org>

Should CONFIG_BRCMSTB_PM=y be in any of the bmips defconfigs to get some
build coverage of this?

Thanks
James

> ---
>  arch/mips/kernel/smp-bmips.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/kernel/smp-bmips.c b/arch/mips/kernel/smp-bmips.c
> index 87dcac2447c8..9d41732a9146 100644
> --- a/arch/mips/kernel/smp-bmips.c
> +++ b/arch/mips/kernel/smp-bmips.c
> @@ -572,7 +572,7 @@ asmlinkage void __weak plat_wired_tlb_setup(void)
>  	 */
>  }
>  
> -void __init bmips_cpu_setup(void)
> +void bmips_cpu_setup(void)
>  {
>  	void __iomem __maybe_unused *cbr = BMIPS_GET_CBR();
>  	u32 __maybe_unused cfg;
> -- 
> 2.16.1
> 

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]