Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: James Hogan <jhogan@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Jaedon Shin <jaedon.shin@gmail.com>,
	Ralf Baechle <ralf@linux-mips.org>,
	Kevin Cernekee <cernekee@gmail.com>,
	linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: BMIPS: Fix section mismatch warning
Date: Thu, 15 Feb 2018 22:14:12 +0000	[thread overview]
Message-ID: <20180215221412.GN3986@saruman> (raw)
In-Reply-To: <8e34b651-165e-5a07-2764-337cbe7b9ffb@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

On Tue, Feb 06, 2018 at 12:09:48PM -0800, Florian Fainelli wrote:
> On 02/06/2018 09:35 AM, James Hogan wrote:
> > On Tue, Feb 06, 2018 at 12:13:21PM +0900, Jaedon Shin wrote:
> >> Remove the __init annotation from bmips_cpu_setup() to avoid the
> >> following warning.
> >>
> >> WARNING: vmlinux.o(.text+0x35c950): Section mismatch in reference from the function brcmstb_pm_s3() to the function .init.text:bmips_cpu_setup()
> >> The function brcmstb_pm_s3() references
> >> the function __init bmips_cpu_setup().
> >> This is often because brcmstb_pm_s3 lacks a __init
> >> annotation or the annotation of bmips_cpu_setup is wrong.
> >>
> >> Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
> > 
> > Reviewed-by: James Hogan <jhogan@kernel.org>
> > 
> > Should CONFIG_BRCMSTB_PM=y be in any of the bmips defconfigs to get some
> > build coverage of this?
> 
> That would be a good idea, Jaedon, do you want to submit a patch doing
> that or should I?
> 
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Applied for 4.16,

Thanks
James

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2018-02-15 22:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-06  3:13 [PATCH] MIPS: BMIPS: Fix section mismatch warning Jaedon Shin
2018-02-06 17:35 ` James Hogan
2018-02-06 20:09   ` Florian Fainelli
2018-02-15 22:14     ` James Hogan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180215221412.GN3986@saruman \
    --to=jhogan@kernel.org \
    --cc=cernekee@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=jaedon.shin@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox