* [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT
@ 2018-03-01 2:37 Huacai Chen
2018-03-01 2:37 ` [PATCH V2 2/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_SERIO Huacai Chen
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Huacai Chen @ 2018-03-01 2:37 UTC (permalink / raw)
To: Ralf Baechle
Cc: James Hogan, Steven J . Hill, linux-mips, Fuxin Zhang,
Zhangjin Wu, Huacai Chen
Commit a211a0820d3c8e7a ("MIPS: Push ARCH_MIGHT_HAVE_PC_PARPORT down to
platform level") moves the global MIPS ARCH_MIGHT_HAVE_PC_PARPORT
select down to various platforms, but doesn't add it to Loongson64
platforms which need it, so add the selects to these platforms too.
Fixes: a211a0820d3c8e7a ("MIPS: Push ARCH_MIGHT_HAVE_PC_PARPORT down to platform level")
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
arch/mips/loongson64/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/mips/loongson64/Kconfig b/arch/mips/loongson64/Kconfig
index bc2fdbf..12812a8b 100644
--- a/arch/mips/loongson64/Kconfig
+++ b/arch/mips/loongson64/Kconfig
@@ -7,6 +7,7 @@ choice
config LEMOTE_FULOONG2E
bool "Lemote Fuloong(2e) mini-PC"
select ARCH_SPARSEMEM_ENABLE
+ select ARCH_MIGHT_HAVE_PC_PARPORT
select CEVT_R4K
select CSRC_R4K
select SYS_HAS_CPU_LOONGSON2E
@@ -33,6 +34,7 @@ config LEMOTE_FULOONG2E
config LEMOTE_MACH2F
bool "Lemote Loongson 2F family machines"
select ARCH_SPARSEMEM_ENABLE
+ select ARCH_MIGHT_HAVE_PC_PARPORT
select BOARD_SCACHE
select BOOT_ELF32
select CEVT_R4K if ! MIPS_EXTERNAL_TIMER
@@ -62,6 +64,7 @@ config LEMOTE_MACH2F
config LOONGSON_MACH3X
bool "Generic Loongson 3 family machines"
select ARCH_SPARSEMEM_ENABLE
+ select ARCH_MIGHT_HAVE_PC_PARPORT
select GENERIC_ISA_DMA_SUPPORT_BROKEN
select BOOT_ELF32
select BOARD_SCACHE
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH V2 2/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_SERIO
2018-03-01 2:37 [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT Huacai Chen
@ 2018-03-01 2:37 ` Huacai Chen
2018-03-02 12:07 ` [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT Maciej W. Rozycki
2018-03-05 10:03 ` James Hogan
2 siblings, 0 replies; 8+ messages in thread
From: Huacai Chen @ 2018-03-01 2:37 UTC (permalink / raw)
To: Ralf Baechle
Cc: James Hogan, Steven J . Hill, linux-mips, Fuxin Zhang,
Zhangjin Wu, Huacai Chen
Commit 7a407aa5e0d3e587 ("MIPS: Push ARCH_MIGHT_HAVE_PC_SERIO down to
platform level") moves the global MIPS ARCH_MIGHT_HAVE_PC_SERIO select
down to various platforms, but doesn't add it to Loongson64 platforms
which need it, so add the selects to these platforms too.
Fixes: 7a407aa5e0d3e587 ("MIPS: Push ARCH_MIGHT_HAVE_PC_SERIO down to platform level")
Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
arch/mips/loongson64/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/mips/loongson64/Kconfig b/arch/mips/loongson64/Kconfig
index 12812a8b..72af0c1 100644
--- a/arch/mips/loongson64/Kconfig
+++ b/arch/mips/loongson64/Kconfig
@@ -8,6 +8,7 @@ config LEMOTE_FULOONG2E
bool "Lemote Fuloong(2e) mini-PC"
select ARCH_SPARSEMEM_ENABLE
select ARCH_MIGHT_HAVE_PC_PARPORT
+ select ARCH_MIGHT_HAVE_PC_SERIO
select CEVT_R4K
select CSRC_R4K
select SYS_HAS_CPU_LOONGSON2E
@@ -35,6 +36,7 @@ config LEMOTE_MACH2F
bool "Lemote Loongson 2F family machines"
select ARCH_SPARSEMEM_ENABLE
select ARCH_MIGHT_HAVE_PC_PARPORT
+ select ARCH_MIGHT_HAVE_PC_SERIO
select BOARD_SCACHE
select BOOT_ELF32
select CEVT_R4K if ! MIPS_EXTERNAL_TIMER
@@ -65,6 +67,7 @@ config LOONGSON_MACH3X
bool "Generic Loongson 3 family machines"
select ARCH_SPARSEMEM_ENABLE
select ARCH_MIGHT_HAVE_PC_PARPORT
+ select ARCH_MIGHT_HAVE_PC_SERIO
select GENERIC_ISA_DMA_SUPPORT_BROKEN
select BOOT_ELF32
select BOARD_SCACHE
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT
2018-03-01 2:37 [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT Huacai Chen
2018-03-01 2:37 ` [PATCH V2 2/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_SERIO Huacai Chen
@ 2018-03-02 12:07 ` Maciej W. Rozycki
2018-03-02 12:07 ` Maciej W. Rozycki
2018-03-03 7:08 ` Jiaxun Yang
2018-03-05 10:03 ` James Hogan
2 siblings, 2 replies; 8+ messages in thread
From: Maciej W. Rozycki @ 2018-03-02 12:07 UTC (permalink / raw)
To: Huacai Chen
Cc: Ralf Baechle, James Hogan, Steven J . Hill, linux-mips,
Fuxin Zhang, Zhangjin Wu
On Wed, 28 Feb 2018, Huacai Chen wrote:
> diff --git a/arch/mips/loongson64/Kconfig b/arch/mips/loongson64/Kconfig
> index bc2fdbf..12812a8b 100644
> --- a/arch/mips/loongson64/Kconfig
> +++ b/arch/mips/loongson64/Kconfig
> @@ -7,6 +7,7 @@ choice
> config LEMOTE_FULOONG2E
> bool "Lemote Fuloong(2e) mini-PC"
> select ARCH_SPARSEMEM_ENABLE
> + select ARCH_MIGHT_HAVE_PC_PARPORT
> select CEVT_R4K
> select CSRC_R4K
> select SYS_HAS_CPU_LOONGSON2E
Hmm, I don't think the Fuloong(2e) machine has a parallel port connector.
The chipset may support the port, but with no external connection I think
there's no point in enabling it. Or am I missing something?
Maciej
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT
2018-03-02 12:07 ` [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT Maciej W. Rozycki
@ 2018-03-02 12:07 ` Maciej W. Rozycki
2018-03-03 7:08 ` Jiaxun Yang
1 sibling, 0 replies; 8+ messages in thread
From: Maciej W. Rozycki @ 2018-03-02 12:07 UTC (permalink / raw)
To: Huacai Chen
Cc: Ralf Baechle, James Hogan, Steven J . Hill, linux-mips,
Fuxin Zhang, Zhangjin Wu
On Wed, 28 Feb 2018, Huacai Chen wrote:
> diff --git a/arch/mips/loongson64/Kconfig b/arch/mips/loongson64/Kconfig
> index bc2fdbf..12812a8b 100644
> --- a/arch/mips/loongson64/Kconfig
> +++ b/arch/mips/loongson64/Kconfig
> @@ -7,6 +7,7 @@ choice
> config LEMOTE_FULOONG2E
> bool "Lemote Fuloong(2e) mini-PC"
> select ARCH_SPARSEMEM_ENABLE
> + select ARCH_MIGHT_HAVE_PC_PARPORT
> select CEVT_R4K
> select CSRC_R4K
> select SYS_HAS_CPU_LOONGSON2E
Hmm, I don't think the Fuloong(2e) machine has a parallel port connector.
The chipset may support the port, but with no external connection I think
there's no point in enabling it. Or am I missing something?
Maciej
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT
2018-03-02 12:07 ` [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT Maciej W. Rozycki
2018-03-02 12:07 ` Maciej W. Rozycki
@ 2018-03-03 7:08 ` Jiaxun Yang
2018-03-03 9:38 ` Maciej W. Rozycki
1 sibling, 1 reply; 8+ messages in thread
From: Jiaxun Yang @ 2018-03-03 7:08 UTC (permalink / raw)
To: Maciej W. Rozycki, Huacai Chen
Cc: Ralf Baechle, James Hogan, Steven J . Hill, linux-mips,
Fuxin Zhang, Zhangjin Wu
在 2018-03-02五的 12:07 +0000，Maciej W. Rozycki写道：
> On Wed, 28 Feb 2018, Huacai Chen wrote:
>
> > diff --git a/arch/mips/loongson64/Kconfig
> > b/arch/mips/loongson64/Kconfig
> > index bc2fdbf..12812a8b 100644
> > --- a/arch/mips/loongson64/Kconfig
> > +++ b/arch/mips/loongson64/Kconfig
> > @@ -7,6 +7,7 @@ choice
> > config LEMOTE_FULOONG2E
> > bool "Lemote Fuloong(2e) mini-PC"
> > select ARCH_SPARSEMEM_ENABLE
> > + select ARCH_MIGHT_HAVE_PC_PARPORT
> > select CEVT_R4K
> > select CSRC_R4K
> > select SYS_HAS_CPU_LOONGSON2E
>
> Hmm, I don't think the Fuloong(2e) machine has a parallel port
> connector.
> The chipset may support the port, but with no external connection I
> think
> there's no point in enabling it. Or am I missing something?
Thanks for your advice.
Some other Loongson-2E devices share the same kernel entry with
Fuloong-2E.
And the 2E desktop PC has a parallel port. So we enable it for these
devices.
>
> Maciej
>
--
Jiaxun Yang <jiaxun.yang@flygoat.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT
2018-03-03 7:08 ` Jiaxun Yang
@ 2018-03-03 9:38 ` Maciej W. Rozycki
2018-03-03 9:38 ` Maciej W. Rozycki
0 siblings, 1 reply; 8+ messages in thread
From: Maciej W. Rozycki @ 2018-03-03 9:38 UTC (permalink / raw)
To: Jiaxun Yang
Cc: Huacai Chen, Ralf Baechle, James Hogan, Steven J . Hill,
linux-mips, Fuxin Zhang, Zhangjin Wu
On Fri, 2 Mar 2018, Jiaxun Yang wrote:
> > Hmm, I don't think the Fuloong(2e) machine has a parallel port
> > connector.
> > The chipset may support the port, but with no external connection I
> > think
> > there's no point in enabling it. Or am I missing something?
> Thanks for your advice.
> Some other Loongson-2E devices share the same kernel entry with
> Fuloong-2E.
> And the 2E desktop PC has a parallel port. So we enable it for these
> devices.
Ah, OK then, thanks for the clarification. Would you mind updating the
Kconfig description for LEMOTE_FULOONG2E to actually list the systems it
covers then?
Maciej
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT
2018-03-03 9:38 ` Maciej W. Rozycki
@ 2018-03-03 9:38 ` Maciej W. Rozycki
0 siblings, 0 replies; 8+ messages in thread
From: Maciej W. Rozycki @ 2018-03-03 9:38 UTC (permalink / raw)
To: Jiaxun Yang
Cc: Huacai Chen, Ralf Baechle, James Hogan, Steven J . Hill,
linux-mips, Fuxin Zhang, Zhangjin Wu
On Fri, 2 Mar 2018, Jiaxun Yang wrote:
> > Hmm, I don't think the Fuloong(2e) machine has a parallel port
> > connector.
> > The chipset may support the port, but with no external connection I
> > think
> > there's no point in enabling it. Or am I missing something?
> Thanks for your advice.
> Some other Loongson-2E devices share the same kernel entry with
> Fuloong-2E.
> And the 2E desktop PC has a parallel port. So we enable it for these
> devices.
Ah, OK then, thanks for the clarification. Would you mind updating the
Kconfig description for LEMOTE_FULOONG2E to actually list the systems it
covers then?
Maciej
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT
2018-03-01 2:37 [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT Huacai Chen
2018-03-01 2:37 ` [PATCH V2 2/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_SERIO Huacai Chen
2018-03-02 12:07 ` [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT Maciej W. Rozycki
@ 2018-03-05 10:03 ` James Hogan
2 siblings, 0 replies; 8+ messages in thread
From: James Hogan @ 2018-03-05 10:03 UTC (permalink / raw)
To: Huacai Chen
Cc: Ralf Baechle, Steven J . Hill, linux-mips, Fuxin Zhang,
Zhangjin Wu
[-- Attachment #1: Type: text/plain, Size: 552 bytes --]
On Thu, Mar 01, 2018 at 10:37:41AM +0800, Huacai Chen wrote:
> Commit a211a0820d3c8e7a ("MIPS: Push ARCH_MIGHT_HAVE_PC_PARPORT down to
> platform level") moves the global MIPS ARCH_MIGHT_HAVE_PC_PARPORT
> select down to various platforms, but doesn't add it to Loongson64
> platforms which need it, so add the selects to these platforms too.
>
> Fixes: a211a0820d3c8e7a ("MIPS: Push ARCH_MIGHT_HAVE_PC_PARPORT down to platform level")
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
Thanks, both patches applied for 4.16.
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-03-05 10:03 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-01 2:37 [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT Huacai Chen
2018-03-01 2:37 ` [PATCH V2 2/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_SERIO Huacai Chen
2018-03-02 12:07 ` [PATCH V2 1/2] MIPS: Loongson64: Select ARCH_MIGHT_HAVE_PC_PARPORT Maciej W. Rozycki
2018-03-02 12:07 ` Maciej W. Rozycki
2018-03-03 7:08 ` Jiaxun Yang
2018-03-03 9:38 ` Maciej W. Rozycki
2018-03-03 9:38 ` Maciej W. Rozycki
2018-03-05 10:03 ` James Hogan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox