From: James Hogan <jhogan@kernel.org>
To: Dan Haab <riproute@gmail.com>
Cc: "Ralf Baechle" <ralf@linux-mips.org>,
linux-mips@linux-mips.org, "Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Dan Haab" <dan.haab@luxul.com>
Subject: Re: [PATCH] MIPS: BCM47XX: Add Luxul XAP1500/XWR1750 WiFi LEDs
Date: Tue, 13 Mar 2018 08:37:07 +0000 [thread overview]
Message-ID: <20180313083707.GG21642@saruman> (raw)
In-Reply-To: <1519767173-8918-1-git-send-email-riproute@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
On Tue, Feb 27, 2018 at 02:32:53PM -0700, Dan Haab wrote:
> @@ -528,6 +539,12 @@
> bcm47xx_leds_pdata.num_leds = ARRAY_SIZE(dev_leds); \
> } while (0)
>
> +static struct gpio_led_platform_data bcm47xx_leds_pdata_extra = {};
Any reason that couldn't be __initdata?
Thanks
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-13 8:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 21:32 [PATCH] MIPS: BCM47XX: Add Luxul XAP1500/XWR1750 WiFi LEDs Dan Haab
2018-03-13 8:37 ` James Hogan [this message]
2018-03-27 17:24 ` [PATCH V2] " Dan Haab
2018-03-28 15:09 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313083707.GG21642@saruman \
--to=jhogan@kernel.org \
--cc=dan.haab@luxul.com \
--cc=hauke@hauke-m.de \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=riproute@gmail.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox