From: James Hogan <jhogan@kernel.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-mips@linux-mips.org, david.daney@cavium.com,
paul.burton@mips.com, Ralf Baechle <ralf@linux-mips.org>,
Kevin Cernekee <cernekee@gmail.com>,
Huacai Chen <chenhc@lemote.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Doug Ledford <dledford@redhat.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] MIPS: Update dma-coherence.h files
Date: Tue, 13 Mar 2018 17:19:28 +0000 [thread overview]
Message-ID: <20180313171927.GH21642@saruman> (raw)
In-Reply-To: <1516758010-7641-3-git-send-email-f.fainelli@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2013 bytes --]
On Tue, Jan 23, 2018 at 05:40:10PM -0800, Florian Fainelli wrote:
> diff --git a/arch/mips/include/asm/mach-ath25/dma-coherence.h b/arch/mips/include/asm/mach-ath25/dma-coherence.h
> index d5defdde32db..63bce15fa54d 100644
> --- a/arch/mips/include/asm/mach-ath25/dma-coherence.h
> +++ b/arch/mips/include/asm/mach-ath25/dma-coherence.h
> +#define plat_unmap_dma_mem plat_unmap_dma_mem
> static inline void
> plat_unmap_dma_mem(struct device *dev, dma_addr_t dma_addr, size_t size,
> enum dma_data_direction direction)
> {
> }
This could presumably be removed too.
> diff --git a/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h b/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h
> index 9110988b92a1..165e13aba3ff 100644
> --- a/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h
> +++ b/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h
> +#define phys_to_dma phys_to_dma
> dma_addr_t phys_to_dma(struct device *dev, phys_addr_t paddr);
> +#define dma_to_phys dma_to_phys
> phys_addr_t dma_to_phys(struct device *dev, dma_addr_t daddr);
I suppose these #defines can be dropped since commit ea8c64ace866
("dma-mapping: move swiotlb arch helpers to a new header").
> diff --git a/arch/mips/include/asm/mach-loongson64/dma-coherence.h b/arch/mips/include/asm/mach-loongson64/dma-coherence.h
> index 1602a9e9e8c2..0a9bbc4c1449 100644
> --- a/arch/mips/include/asm/mach-loongson64/dma-coherence.h
> +++ b/arch/mips/include/asm/mach-loongson64/dma-coherence.h
> +#define phys_to_dma phys_to_dma
> extern dma_addr_t phys_to_dma(struct device *dev, phys_addr_t paddr);
> +#define dma_to_phys dma_to_phys
> extern phys_addr_t dma_to_phys(struct device *dev, dma_addr_t daddr);
same here
> +#define plat_dma_supported plat_dma_supported
> static inline int plat_dma_supported(struct device *dev, u64 mask)
> {
> /*
> @@ -69,6 +70,7 @@ static inline int plat_dma_supported(struct device *dev, u64 mask)
> return 1;
> }
That can be removed too, no?
Cheers
James
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-13 17:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 1:40 [PATCH 0/2] MIPS: generic dma-coherence.h inclusion Florian Fainelli
2018-01-24 1:40 ` Florian Fainelli
2018-01-24 1:40 ` [PATCH 1/2] MIPS: Allow including mach-generic/dma-coherence.h Florian Fainelli
2018-01-24 1:40 ` Florian Fainelli
2018-03-13 17:24 ` James Hogan
2018-01-24 1:40 ` [PATCH 2/2] MIPS: Update dma-coherence.h files Florian Fainelli
2018-01-24 1:40 ` Florian Fainelli
2018-03-13 17:19 ` James Hogan [this message]
2018-01-26 8:31 ` [PATCH 0/2] MIPS: generic dma-coherence.h inclusion Steven J. Hill
2018-01-29 20:10 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313171927.GH21642@saruman \
--to=jhogan@kernel.org \
--cc=bart.vanassche@sandisk.com \
--cc=cernekee@gmail.com \
--cc=chenhc@lemote.com \
--cc=david.daney@cavium.com \
--cc=dledford@redhat.com \
--cc=f.fainelli@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox